From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Cc: Jason Baron <jbaron@akamai.com>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Michal Marek <mmarek@suse.com>
Subject: Re: [RFC v3 6/8] kconfig: introduce "count"
Date: Thu, 12 Nov 2015 09:03:23 +0100 [thread overview]
Message-ID: <1447315403.2131.1.camel@sipsolutions.net> (raw)
In-Reply-To: <1447315173.2131.0.camel@sipsolutions.net> (sfid-20151112_085940_975706_EC9F10A3)
On Thu, 2015-11-12 at 08:59 +0100, Johannes Berg wrote:
> On Wed, 2015-11-11 at 23:15 +0100, Johannes Berg wrote:
> >
> > +static unsigned long long count_or_symbols(struct expr *e)
> > +{
> > + switch (e->type) {
> > + case E_SYMBOL:
> > + return 1;
>
> Oh, this is obviously bogus - I need to count the *enabled* symbols.
>
- return 1;
+ sym_calc_value(e->left.sym);
+ return e->left.sym->curr.tri != no;
works properly.
johannes
next prev parent reply other threads:[~2015-11-12 8:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 22:15 [RFC v3 0/8] mac80211: jump labels for HW flags Johannes Berg
2015-11-11 22:15 ` [RFC v3 1/8] mac80211: add ieee80211_hw_clear() Johannes Berg
2015-11-11 22:15 ` [RFC v3 2/8] mac80211: introduce ieee80211_local_check() Johannes Berg
2015-11-11 22:15 ` [RFC v3 3/8] mac80211: use static keys for hw flags Johannes Berg
2015-11-11 22:15 ` [RFC v3 4/8] mac80211: test the static key code Johannes Berg
2015-11-11 22:15 ` [RFC v3 5/8] mac80211: generate hw flags from include file Johannes Berg
2015-11-11 22:15 ` [RFC v3 6/8] kconfig: introduce "count" Johannes Berg
2015-11-12 7:59 ` Johannes Berg
2015-11-12 8:03 ` Johannes Berg [this message]
2015-11-11 22:15 ` [RFC v3 7/8] kconfig: regenerate the shipped files Johannes Berg
2015-11-11 22:15 ` [RFC v3 8/8] mac80211: use Kconfig counters to determine feature optimisation Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447315403.2131.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jbaron@akamai.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.