From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v4 1/9] libxc: reorganize domain builder guest memory allocator Date: Thu, 12 Nov 2015 11:20:47 +0000 Message-ID: <1447327247.18450.58.camel@citrix.com> References: <1446734195-20257-1-git-send-email-jgross@suse.com> <1446734195-20257-2-git-send-email-jgross@suse.com> <20151112111437.GA24281@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151112111437.GA24281@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Juergen Gross Cc: stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, roger.pau@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-11-12 at 11:14 +0000, Wei Liu wrote: > On Thu, Nov 05, 2015 at 03:36:27PM +0100, Juergen Gross wrote: > > Guest memory allocation in the domain builder of libxc is done via > > virtual addresses only. In order to be able to support preallocated > > areas not virtually mapped reorganize the memory allocator to keep > > track of allocated pages globally and in allocated segments. > > > > This requires an interface change of the allocate callback of the > > domain builder which currently is using the last mapped virtual > > address as a parameter. This is no problem as the only user of this > > callback is stubdom/grub/kexec.c using this virtual address to > > calculate the last used pfn. > > > > Signed-off-by: Juergen Gross > > One question: did you test building with pygrub after this change? I > think the code is correct but we'd better be sure it doesn't break > pygrub. Did you mean pvgrub? (with a Vee) pygrub (with a Why) runs way before the libxc domain builder gets in on the act, doesn't it. Ian.