From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2] ns16550: misc minor adjustments Date: Thu, 12 Nov 2015 15:47:28 +0000 Message-ID: <1447343248.18450.76.camel@citrix.com> References: <5644BF9302000078000B4535@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zwu6H-00013v-UO for xen-devel@lists.xenproject.org; Thu, 12 Nov 2015 15:47:50 +0000 In-Reply-To: <5644BF9302000078000B4535@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Keir Fraser , Ian Jackson , Tim Deegan List-Id: xen-devel@lists.xenproject.org On Thu, 2015-11-12 at 08:34 -0700, Jan Beulich wrote: > First and foremost: fix documentation: The use of "clock_hz", when > "base_baud" was meant, has taken me several hours (suspecting a more > complicated problem with the PCIe card I've been trying to get > working). At once correct the "gdb" option, which is more like > "console", not like "com". > > Next, fix the types of ns_{read,write}_reg(): Especially the former > having had a signed return type so far caused quite interesting effects > when determining to baud rate if "auto" was specified. In that same > code, also avoid dividing by zero when in fact the baud rate was not > previously set up. > > Further, accept I/O port based serial PCI cards with a port range wider > than 8 bytes. > > Finally, slightly rearrange struct ns16550 to reduce holes. > > Signed-off-by: Jan Beulich Acked-by: Ian Campbell