From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zwzbm-00061P-3E for ath10k@lists.infradead.org; Thu, 12 Nov 2015 21:40:43 +0000 Message-ID: <1447364413.2131.5.camel@sipsolutions.net> Subject: Re: [PATCH v2] cfg80211: add VHT support for Mesh From: Johannes Berg Date: Thu, 12 Nov 2015 22:40:13 +0100 In-Reply-To: <564505A6.9030001@codeaurora.org> References: <1447358605.2131.3.camel@sipsolutions.net> <564505A6.9030001@codeaurora.org> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Peter Oh , Peter Oh , ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org T24gVGh1LCAyMDE1LTExLTEyIGF0IDEzOjMzIC0wODAwLCBQZXRlciBPaCB3cm90ZToKPsKgCj4g QXQgdGhpcyBtb21lbnQgTWVzaCBQb2ludCBpcyBub3QgYWJsZSB0byBiZSBicm91Z2h0IHVwIGJ5 IHVzZXJzcGFjZQo+IHN1Y2ggCj4gYXMgd2FwX3N1cHBsaWNhbnQgYXQgVkhUIGRhdGEgcmF0ZXMg YmVjYXVzZSB0aGVyZSBpcyBubwo+IGV2ZW50cy9OTDgwMjExIAo+IGRlZmluZWQgdGhhdCB1c2Vy c3BhY2UgY2FuIGNoZWNrIG91dCBpZiBkcml2ZXJzIGNhbiBzdXBwb3J0IE1lc2gKPiBQb2ludCAK PiAoODAyLjExcykgYXQgVkhUIGRhdGEgcmF0ZXMgb3Igbm90LCBoZW5jZSBvbmx5IEhUIGRhdGEg cmF0ZXMgY2FuIGJlCj4gdXNlZCAKPiBmb3IKPiBNZXNoIFBvaW50IGJ5IHVzZXJzcGFjZSBub3cu Cj4gVGhpcyBwYXRjaCBpcyBpbnRyb2R1Y2luZyBOTDgwMjExIGV2ZW50IHRvIGNvdmVyIHRoZSBp c3N1ZS4KCk5vLi4uIHRoaXMgcGF0Y2ggZG9lc24ndCBpbnRyb2R1Y2UgYW4gbmw4MDIxMSBldmVu dC4gSXQgaW50cm9kdWNlcyBhCmZlYXR1cmUgZmxhZywgYnV0IEknbSBhcmd1aW5nIGl0J3MgdXNl bGVzcy4KCkxvb2sgLSB3aGF0J3MgdGhlIGRpZmZlcmVuY2UgdGhhdCB1c2Vyc3BhY2Ugd291bGQg ZG8gYmFzZWQgb24gdGhpcwpmbGFnPyBDbGVhcmx5LCBzZXR0aW5nIHRoZSBmbGFnIGluIHRoZSBk cml2ZXIgaGFzIG5vIGVmZmVjdCBvbiBrZXJuZWwKY29kZSB3aGF0c29ldmVyLCBzbyB5b3VyICJp cyBub3QgYWJsZSB0byBiZSBicm91Z2h0IHVwIiBtYWtlcyBubyBzZW5zZS4KClBlcmhhcHMgaXQn bGwgYmVjb21lIGNsZWFyZXIgb25jZSB5b3UgcG9zdCB0aGUgd3BhX3N1cHBsaWNhbnQgY29kZSwg YnV0CnlvdSBzaG91bGQgc3RpbGwgY29oZXJlbnRseSBleHBsYWluIGluIHRoZSBjb21taXQgbWVz c2FnZSB3aHkgdGhpcyBpcwpuZWNlc3NhcnkuIFNvIGZhciwgSSBkb24ndCBzZWUgaXQsIHNpbmNl IG5vIGtlcm5lbCBjb2RlIGV2ZXIgZGVwZW5kcyBvbgp0aGlzIGZsYWcuCgpqb2hhbm5lcwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBrIG1haWxp bmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:54886 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753668AbbKLVk1 (ORCPT ); Thu, 12 Nov 2015 16:40:27 -0500 Message-ID: <1447364413.2131.5.camel@sipsolutions.net> (sfid-20151112_224033_417377_94801D76) Subject: Re: [PATCH v2] cfg80211: add VHT support for Mesh From: Johannes Berg To: Peter Oh , Peter Oh , ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Date: Thu, 12 Nov 2015 22:40:13 +0100 In-Reply-To: <564505A6.9030001@codeaurora.org> References: <1447358605.2131.3.camel@sipsolutions.net> <564505A6.9030001@codeaurora.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2015-11-12 at 13:33 -0800, Peter Oh wrote: >  > At this moment Mesh Point is not able to be brought up by userspace > such > as wap_supplicant at VHT data rates because there is no > events/NL80211 > defined that userspace can check out if drivers can support Mesh > Point > (802.11s) at VHT data rates or not, hence only HT data rates can be > used > for > Mesh Point by userspace now. > This patch is introducing NL80211 event to cover the issue. No... this patch doesn't introduce an nl80211 event. It introduces a feature flag, but I'm arguing it's useless. Look - what's the difference that userspace would do based on this flag? Clearly, setting the flag in the driver has no effect on kernel code whatsoever, so your "is not able to be brought up" makes no sense. Perhaps it'll become clearer once you post the wpa_supplicant code, but you should still coherently explain in the commit message why this is necessary. So far, I don't see it, since no kernel code ever depends on this flag. johannes