From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zx8wC-0005LL-By for ath10k@lists.infradead.org; Fri, 13 Nov 2015 07:38:26 +0000 Message-ID: <1447400275.3271.2.camel@sipsolutions.net> Subject: Re: [PATCH v2] cfg80211: add VHT support for Mesh From: Johannes Berg Date: Fri, 13 Nov 2015 08:37:55 +0100 In-Reply-To: <56451B2F.3060704@codeaurora.org> References: <1447358605.2131.3.camel@sipsolutions.net> <564505A6.9030001@codeaurora.org> <1447364413.2131.5.camel@sipsolutions.net> <56451294.9060205@codeaurora.org> <1447367523.2131.6.camel@sipsolutions.net> <56451B2F.3060704@codeaurora.org> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Peter Oh , Peter Oh , ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org T24gVGh1LCAyMDE1LTExLTEyIGF0IDE1OjA1IC0wODAwLCBQZXRlciBPaCB3cm90ZToKPiBPbiAx MS8xMi8yMDE1IDAyOjMyIFBNLCBKb2hhbm5lcyBCZXJnIHdyb3RlOgo+ID4gT24gVGh1LCAyMDE1 LTExLTEyIGF0IDE0OjI4IC0wODAwLCBQZXRlciBPaCB3cm90ZToKPiA+ID4gwqAgCj4gPiA+IEV4 YWN0bHkgdGhlIHNhbWUgY29tbXVuaWNhdGlvbiBtZWNoYW5pc20gYW5kIHB1cnBvc2UgYXJlIHVz ZWQKPiA+ID4gd2l0aAo+ID4gPiBOTDgwMjExX0VYVF9GRUFUVVJFX1ZIVF9JQlNTIHdoaWNoIGlz IGFscmVhZHkgYSBwYXJ0IG9mIE5MODAyMTEKPiA+ID4gZmVhdHVyZQo+ID4gPiBmbGFnLgo+ID4g PiBUaGUgbmV3IGZlYXR1cmUgZmxhZywgTkw4MDIxMV9FWFRfRkVBVFVSRV9WSFRfTUVTSCwgZm9s bG93cyB0aGUKPiA+ID4gc2FtZQo+ID4gPiBwdXJwb3NlIGFuZCB1c2FnZS4KPiA+IE5vLCBpdCBk b2Vzbid0LiBDaGVjayBob3cgdGhlIF9JQlNTIG9uZSBpcyB1c2VkIGluIHRoZSBjb2RlIHRvCj4g PiBhY3R1YWxseQo+ID4gKmRvKiBzb21ldGhpbmcuCj4gdGhhdCdzIHJpZ2h0LiBzbyB0YWtlIGEg bG9vayByZXNldCBvZiBleHBsYW5hdGlvbiBmb3IgdGhpcyBwYXRjaC4KPiAKClN0aWxsIG5vdCBt YWtpbmcgc2Vuc2UuCgpJICpzdXNwZWN0KiB0aGF0IHlvdSB0aGluayB0aGF0IHRoZSBleGlzdGlu ZyBjb2RlIGlzIGJyb2tlbiwgYW5kIGNhbid0CnVzZSBWSFQgbWVzaCBhbmQgcmVxdWlyZXMgZHJp dmVyIGNoYW5nZXMgZm9yIGl0LCBidXQgdGhhdCdzIG5vdCB3aGF0CnlvdXIgYXRoMTBrIGNoYW5n ZSBzaG93cyBzaW5jZSBpdCBhbHNvIGRvZXMgbm90aGluZyBhdCBhbGwuCgpSaWdodCBub3csIEkg c2VlIG5vIHJlYXNvbiB3aGF0c29ldmVyIHRvIGFwcGx5IGVpdGhlciBvbmUgb2YgdGhvc2UgdHdv CnBhdGNoZXMuIFRoZXJlIGFyZSBubyBmdW5jdGlvbmFsIGNoYW5nZXMsIHNvIHdwYV9zdXBwbGlj YW50IGNvdWxkCmVuYWJsZSBWSFQgbWVzaCBieSBjaGVja2luZyBWSFQgY2FwYWJpbGl0aWVzIG9y IHNvIGluc3RlYWQgb2YgYSBzcGVjaWFsCmZlYXR1cmUgZmxhZy4KCkkgYWxzbyBzdXNwZWN0IHRo YXQgcGVyaGFwcyBtZXNoICpzaG91bGQqIGJlIGNoZWNraW5nIGxpa2UgSUJTUyBkb2VzLAphbHRo b3VnaCBJIGFsc28gd291bGQgYWN0dWFsbHkgKnByZWZlciogdGhhdCB3ZSBjYW4gYXNzdW1lIFZI VCBtZXNoCndvcmtzIGlmIHRoZSBkcml2ZXIgYWR2ZXJ0aXNlcyBWSFQgc3VwcG9ydCBhbmQgbWVz aCBzdXBwb3J0IHNlcGFyYXRlbHksCmkuZS4gYSBuZXcgZmVhdHVyZSBmbGFnIHJlYWxseSBpc24n dCBuZWNlc3NhcnkuCgpJbiBhbnkgY2FzZSwgdGhlIGFyZ3VtZW50cyBmb3IgdGhpcyBwYXRjaCBo YXZlbid0IGNvbnZpbmNlZCBtZS4gSSdtIG5vdApnb2luZyB0byBhcHBseSB0aGlzIHdpdGhvdXQg bXVjaCBiZXR0ZXIgb25lcy4KCmpvaGFubmVzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRo MTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:56932 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753070AbbKMHiD (ORCPT ); Fri, 13 Nov 2015 02:38:03 -0500 Message-ID: <1447400275.3271.2.camel@sipsolutions.net> (sfid-20151113_083859_246954_8A8917FD) Subject: Re: [PATCH v2] cfg80211: add VHT support for Mesh From: Johannes Berg To: Peter Oh , Peter Oh , ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Date: Fri, 13 Nov 2015 08:37:55 +0100 In-Reply-To: <56451B2F.3060704@codeaurora.org> References: <1447358605.2131.3.camel@sipsolutions.net> <564505A6.9030001@codeaurora.org> <1447364413.2131.5.camel@sipsolutions.net> <56451294.9060205@codeaurora.org> <1447367523.2131.6.camel@sipsolutions.net> <56451B2F.3060704@codeaurora.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2015-11-12 at 15:05 -0800, Peter Oh wrote: > On 11/12/2015 02:32 PM, Johannes Berg wrote: > > On Thu, 2015-11-12 at 14:28 -0800, Peter Oh wrote: > > >   > > > Exactly the same communication mechanism and purpose are used > > > with > > > NL80211_EXT_FEATURE_VHT_IBSS which is already a part of NL80211 > > > feature > > > flag. > > > The new feature flag, NL80211_EXT_FEATURE_VHT_MESH, follows the > > > same > > > purpose and usage. > > No, it doesn't. Check how the _IBSS one is used in the code to > > actually > > *do* something. > that's right. so take a look reset of explanation for this patch. > Still not making sense. I *suspect* that you think that the existing code is broken, and can't use VHT mesh and requires driver changes for it, but that's not what your ath10k change shows since it also does nothing at all. Right now, I see no reason whatsoever to apply either one of those two patches. There are no functional changes, so wpa_supplicant could enable VHT mesh by checking VHT capabilities or so instead of a special feature flag. I also suspect that perhaps mesh *should* be checking like IBSS does, although I also would actually *prefer* that we can assume VHT mesh works if the driver advertises VHT support and mesh support separately, i.e. a new feature flag really isn't necessary. In any case, the arguments for this patch haven't convinced me. I'm not going to apply this without much better ones. johannes