Re: [RFC v5 4/5] mac80211: use Kconfig counters to elide unnecessary code

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2015-11-13 at 20:48 +1100, Julian Calaby wrote:
> 
> Am I missing something or are you not actually doing anything with
> MAC80211_DRIVER_NO_HWFLAGS?
> 

Crap. I meant to pass it to the macro like this (I think):

#define __DEFINE_HWFLAG(_flg, _dyn, _on, _off)                         \
       HWFLAGS_STATE_##_flg = -1 + (!(_dyn)) * (((_on) ^ (_off)) * (1 + (_on))),
#define DEFINE_HWFLAG(_flg)                                            \
       __DEFINE_HWFLAG(_flg,                                           \
                       IS_ENABLED(CONFIG_MAC80211_HW_##_flg##_DYN) ||  \
                       (CONFIG_MAC80211_DRIVER_NO_HWFLAGS > 0),        \
                       CONFIG_MAC80211_HW_##_flg > 0,                  \
                       CONFIG_MAC80211_HW_##_flg < CONFIG_MAC80211_NUM_DRIVERS)

I'll take a closer look.

FWIW, I pushed this into the hwflags-elide branch in mac80211-next.git
(kernel.org) - will update there (also already fixed a compile issue)

johannes