From: Johannes Berg <johannes@sipsolutions.net>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-wireless@vger.kernel.org, Jason Baron <jbaron@akamai.com>,
Peter Zijlstra <peterz@infradead.org>,
Michal Marek <mmarek@suse.com>
Subject: Re: [RFC v4 3/8] mac80211: use static keys for hw flags
Date: Fri, 13 Nov 2015 17:30:36 +0100 [thread overview]
Message-ID: <1447432236.3271.17.camel@sipsolutions.net> (raw)
In-Reply-To: <20151113112236.0303675a@gandalf.local.home>
On Fri, 2015-11-13 at 11:22 -0500, Steven Rostedt wrote:
> This sure could use a comment.
>
> on = 0, off = 0, -1 + (0^0) * (1 + 0) = -1
> on = 0, off = 1, -1 + (0^1) * (1 + 0) = 0
> on = 1, off = 0, -1 + (1^0) * (1 + 1) = 1
> on = 1, off = 1, -1 + (1^1) * (1 + 1) = -1
>
> The I would also state:
>
> -1 means to simply use if logic (no jump labels/static keys)
> 0 means to use jump label to off
> 1 means to use jump label to on
Yeah, fair enough :)
FWIW, I changed my mind and redid all of this without the jump labels,
just actually eliding the code completely if possible. I've put it in
the hwflags-elide branch in my mac80211-next tree:
https://git.kernel.org/cgit/linux/kernel/git/jberg/mac80211-next.git/log/?h=hwflags-elide
johannes
next prev parent reply other threads:[~2015-11-13 16:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 8:47 [RFC v4 0/8] mac80211: jump labels for HW flags Johannes Berg
2015-11-12 8:47 ` [RFC v4 1/8] mac80211: add ieee80211_hw_clear() Johannes Berg
2015-11-12 8:47 ` [RFC v4 2/8] mac80211: introduce ieee80211_local_check() Johannes Berg
2015-11-12 8:47 ` [RFC v4 3/8] mac80211: use static keys for hw flags Johannes Berg
2015-11-13 16:22 ` Steven Rostedt
2015-11-13 16:30 ` Johannes Berg [this message]
2015-11-12 8:47 ` [RFC v4 4/8] mac80211: test the static key code Johannes Berg
2015-11-12 8:47 ` [RFC v4 5/8] mac80211: generate hw flags from include file Johannes Berg
2015-11-13 16:25 ` Steven Rostedt
2015-11-13 16:31 ` Johannes Berg
2015-11-12 8:47 ` [RFC v4 6/8] kconfig: introduce "count" Johannes Berg
2015-11-13 16:26 ` Steven Rostedt
2015-11-13 16:32 ` Johannes Berg
2015-11-12 8:47 ` [RFC v4 7/8] kconfig: regenerate the shipped files Johannes Berg
2015-11-12 8:47 ` [RFC v4 8/8] mac80211: use Kconfig counters to determine feature optimisation Johannes Berg
2015-11-13 16:29 ` Steven Rostedt
2015-11-13 16:35 ` Johannes Berg
2015-11-13 16:49 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447432236.3271.17.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jbaron@akamai.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.