From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Jiri Olsa <jolsa@redhat.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 2/5] perf buildid-list: Requires ordered events
Date: Fri, 13 Nov 2015 17:57:26 -0300 [thread overview]
Message-ID: <1447448249-22276-3-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1447448249-22276-1-git-send-email-acme@kernel.org>
From: Adrian Hunter <adrian.hunter@intel.com>
'perf buildid-list' processes events to determine hits (i.e. with-hits
option). That may not work if events are not sorted in order. i.e. MMAP
events must be processed before the samples that depend on them so that
sample processing can 'hit' the DSO to which the MMAP refers.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1447408112-1920-3-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/build-id.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c
index d909459fb54c..217b5a60e2ab 100644
--- a/tools/perf/util/build-id.c
+++ b/tools/perf/util/build-id.c
@@ -76,6 +76,7 @@ struct perf_tool build_id__mark_dso_hit_ops = {
.exit = perf_event__exit_del_thread,
.attr = perf_event__process_attr,
.build_id = perf_event__process_build_id,
+ .ordered_events = true,
};
int build_id__sprintf(const u8 *build_id, int len, char *bf)
--
2.1.0
next prev parent reply other threads:[~2015-11-13 20:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 20:57 [GIT PULL 0/5] perf/urgent fixes Arnaldo Carvalho de Melo
2015-11-13 20:57 ` [PATCH 1/5] perf symbols: Fix dso lookup by long name and missing buildids Arnaldo Carvalho de Melo
2015-11-13 20:57 ` Arnaldo Carvalho de Melo [this message]
2015-11-13 20:57 ` [PATCH 3/5] perf inject: Also re-pipe lost_samples event Arnaldo Carvalho de Melo
2015-11-13 20:57 ` [PATCH 4/5] perf probe: Fix memory leaking on failure by clearing all probe_trace_events Arnaldo Carvalho de Melo
2015-11-13 20:57 ` [PATCH 5/5] perf probe: Clear probe_trace_event when add_probe_trace_event() fails Arnaldo Carvalho de Melo
2015-11-18 5:57 ` [GIT PULL 0/5] perf/urgent fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447448249-22276-3-git-send-email-acme@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.