From: Ian Campbell <ian.campbell@citrix.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
Wei Liu <wei.liu2@citrix.com>
Cc: minios-devel@lists.xenproject.org,
Xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH MINI-OS v3 1/2] xenbus: notify the other end when necessary
Date: Mon, 16 Nov 2015 12:10:13 +0000 [thread overview]
Message-ID: <1447675813.27871.50.camel@citrix.com> (raw)
In-Reply-To: <20151027154643.GE2483@var.bordeaux.inria.fr>
On Tue, 2015-10-27 at 16:46 +0100, Samuel Thibault wrote:
> Wei Liu, le Tue 27 Oct 2015 15:43:28 +0000, a écrit :
> > The xenbus thread didn't send notification to other end when it
> > expected
> > more data or consumed responses, which led to stalling the ring from
> > time to time.
> >
> > This is the culprit that guest was less responsive when using stubdom
> > because the device model was stalled.
> >
> > Fix this by sending notification to the other end when it consumes a
> > message. A bunch of memory barriers are also added to ensure
> > correctness.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
> Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Applied.
> And it should clearly be backported to stable branches.
I don't think we have a mini-os branch for stable, but I'll let Ian J
figure out the right way to achieve this.
Ian
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-11-16 12:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 15:43 [PATCH MINI-OS v3 0/2] Two mini-os xenbus patches Wei Liu
2015-10-27 15:43 ` [PATCH MINI-OS v3 1/2] xenbus: notify the other end when necessary Wei Liu
2015-10-27 15:46 ` Samuel Thibault
2015-10-27 15:55 ` Wei Liu
2015-11-16 12:10 ` Ian Campbell [this message]
2015-10-27 15:43 ` [PATCH MINI-OS v3 2/2] xenbus: workaround oxenstored short-write Wei Liu
2015-10-27 15:47 ` Samuel Thibault
2015-11-16 11:30 ` Ian Campbell
2015-11-16 11:47 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447675813.27871.50.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=minios-devel@lists.xenproject.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.