All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arc: add stubs for map_physmem() and unmap_physmem()
Date: Mon, 16 Nov 2015 13:47:42 +0000	[thread overview]
Message-ID: <1447681662.6240.19.camel@synopsys.com> (raw)
In-Reply-To: <CAPnjgZ2-kN6JJCLE1pF+CsZVJABAAqe-4ssXWB=pNsks0MvpLw@mail.gmail.com>

Hi Simon, Stephen,

On Fri, 2015-11-13 at 19:03 -0700, Simon Glass wrote:
> On 13 November 2015 at 11:23, Alexey Brodkin
> <Alexey.Brodkin@synopsys.com> wrote:
> > Hi Simon,
> > 
> > On Fri, 2015-11-13 at 11:14 -0700, Simon Glass wrote:
> > > Hi Alexey,
> > > 
> > > On 12 November 2015 at 14:56, Alexey Brodkin
> > > <Alexey.Brodkin@synopsys.com> wrote:

[snip]

> > > > Up until now there was no need in those stubs.
> > > > 
> > > > But since following commit compilation of U-Boot on ARC is broken:
> > > > ------------------------>8----------------------
> > > > commit 7861204c9af7fec1ea9b41541c272516235a6c93
> > > > Author: Stephen Warren <swarren@wwwdotorg.org>
> > > > Date:   Sat Oct 3 13:56:46 2015 -0600
> > > > 
> > > >     itest: make memory access work under sandbox
> > > > 
> > > >     itest accesses memory, and hence must map/unmap it. Without doing so, it
> > > >     accesses invalid addresses and crashes.
> > > > 
> > > >     Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> > > >     Reviewed-by: Simon Glass <sjg@chromium.org>
> > > > ------------------------>8----------------------
> > > > 
> > > > That's because CMD_ITEST is enabled by default in common/Kconfig and now
> > > > map_physmem()/unmap_physmem() is used there.
> > > > 
> > > > So this patch adds missing stubs for ARC.
> > > > 
> > > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > > > Cc: Stephen Warren <swarren@wwwdotorg.org>
> > > > Cc: Simon Glass <sjg@chromium.org>
> > > > ---
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>

So should I move map_physmem()/unmap_physmem() in generic header and include
it in asm/io.h for every arch (as suggested by Stephen) or for starters I
may have stubs for ARC and once this patch is accepted do clean-up for
all arches at once?

-Alexey

  reply	other threads:[~2015-11-16 13:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-12 21:56 [U-Boot] [PATCH] arc: add stubs for map_physmem() and unmap_physmem() Alexey Brodkin
2015-11-12 23:00 ` Stephen Warren
2015-11-13 13:40   ` Alexey Brodkin
2015-11-13 16:06     ` Stephen Warren
2015-11-13 18:14 ` Simon Glass
2015-11-13 18:23   ` Alexey Brodkin
2015-11-14  2:03     ` Simon Glass
2015-11-16 13:47       ` Alexey Brodkin [this message]
2015-11-16 21:08         ` Simon Glass
2015-11-16 22:15           ` Alexey Brodkin
2015-11-16 23:15             ` Stephen Warren
2015-11-17 21:43               ` Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447681662.6240.19.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.