From: Ian Campbell <ian.campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>
Subject: Re: [PATCH] ns16550: reset bar_64 on each iteration
Date: Mon, 16 Nov 2015 16:46:20 +0000 [thread overview]
Message-ID: <1447692380.27871.113.camel@citrix.com> (raw)
In-Reply-To: <5644C52D.5090003@citrix.com>
On Thu, 2015-11-12 at 16:58 +0000, Andrew Cooper wrote:
> On 12/11/15 15:52, Jan Beulich wrote:
> > Re-using the possibly non-zero value from a previous iteration can't
> > do any good.
> >
> > Take the opportunity and
> > - limit a few other variables' scopes at once,
> > - adjust a few types.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
On that basis, Acked-by: Ian Campbell <ian.campbell@citrix.com>
prev parent reply other threads:[~2015-11-16 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 15:52 [PATCH] ns16550: reset bar_64 on each iteration Jan Beulich
2015-11-12 16:58 ` Andrew Cooper
2015-11-16 16:46 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447692380.27871.113.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.