All of lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: get runtime PM reference around GEM set_tiling IOCTL
Date: Tue, 17 Nov 2015 18:51:16 +0200	[thread overview]
Message-ID: <1447779076.9159.8.camel@intel.com> (raw)
In-Reply-To: <20151109205638.GM22414@nuc-i3427.alporthouse.com>

On ma, 2015-11-09 at 20:56 +0000, Chris Wilson wrote:
> On Mon, Nov 09, 2015 at 08:16:26PM +0200, Imre Deak wrote:
> > After fixing the same issue in the set_caching IOCTL and Chris'
> > request
> > to check out the possibilities for an improved RPM ref handling I
> > noticed that we have the same issue in the set_tiling IOCTL. Fix
> > this
> > up.I didn't see any bug reports about this one, but the GTT unbind
> > operation on this path accesses the HW, which needs the ref.
> > 
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> 
> The reason why we haven't seen a bug report is that we don't get the
> GTT
> mismatch on gen4+ devices (i.e. those with runtime pm). However, for
> the
> sake of completeness, it is better to wrap all the GGTT unbind access
> in
> the rpm reference (and future patches to reduce the wakelock will be
> more consistent).
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Pushed to dinq. Thanks for the review.


> -Chris
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2015-11-17 16:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09 18:16 [PATCH] drm/i915: get runtime PM reference around GEM set_tiling IOCTL Imre Deak
2015-11-09 20:56 ` Chris Wilson
2015-11-17 16:51   ` Imre Deak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447779076.9159.8.camel@intel.com \
    --to=imre.deak@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.