All of lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL
Date: Tue, 17 Nov 2015 21:22:10 +0200	[thread overview]
Message-ID: <1447788130.9159.12.camel@intel.com> (raw)
In-Reply-To: <20151117190055.GX16848@phenom.ffwll.local>

On ti, 2015-11-17 at 20:00 +0100, Daniel Vetter wrote:
> On Wed, Nov 04, 2015 at 05:47:12PM -0200, Paulo Zanoni wrote:
> > 2015-11-04 17:25 GMT-02:00 Imre Deak <imre.deak@intel.com>:
> > > After Damien's D3 fix I started to get runtime suspend residency
> > > for the
> > > first time and that revealed a breakage on the set_caching IOCTL
> > > path
> > > that accesses the HW but doesn't take an RPM ref. Fix this up.
> > 
> > Oh, well, that's the the RPM problem that prevents me from sleeping
> > at
> > night: how can we be 100% sure we wrapped every single possible
> > driver
> > entry point? At least we shout errors and warns when we detect the
> > problem.
> > 
> > By the way, we already have some tests for specific IOCTLs on
> > igt/pm_rpm, so adding a new one for this IOCTL wouldn't hurt :)
> 
> Yeah, rpm subtests for set_caching and set_tiling are indeed missing.
> Imre, can you please add them?

Ok, will add them.

--Imre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-11-17 19:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 19:25 [PATCH] drm/i915: get runtime PM reference around GEM set_caching IOCTL Imre Deak
2015-11-04 19:47 ` Paulo Zanoni
2015-11-16 13:33   ` Jani Nikula
2015-11-17 19:00   ` Daniel Vetter
2015-11-17 19:22     ` Imre Deak [this message]
2015-11-04 20:57 ` Chris Wilson
2015-11-05 11:28   ` Imre Deak
2015-11-05 11:56     ` Chris Wilson
2015-11-05 22:57       ` Imre Deak
2015-11-05 23:24         ` Imre Deak
2015-11-06  8:54         ` Chris Wilson
2015-11-09 13:09           ` Imre Deak
2015-11-09 13:25             ` Chris Wilson
2015-11-09 13:36               ` Imre Deak
2015-11-09 13:43                 ` Chris Wilson
2015-11-17 22:16       ` Daniel Vetter
2015-11-17 22:38         ` Chris Wilson
2015-11-17 22:49           ` Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447788130.9159.12.camel@intel.com \
    --to=imre.deak@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=przanoni@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.