Re: [meta-oe][PATCH V2 03/17] modemmanager: Add PACKAGECONFIGs

[Adrian Freihofer <adrian.freihofer@gmail.com>]

Hi Martin
Thank you for fixing the patches. After reading your comments I found another mistake. May I ask you to apply the
following fixup to this patch. It's true, bitbake does not consider versions for depends. But the recipe builds.


index a479072..f305bde 100644
@@ -24,9 +24,9 @@ PACKAGECONFIG ??= "mbim qmi polkit \
 PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=${systemd_unitdir}/system/,,"
 PACKAGECONFIG[polkit] = "--with-polkit=yes,--with-polkit=no,polkit"
 # Support WWAN modems and devices which speak the Mobile Interface Broadband Model (MBIM) protocol.
-PACKAGECONFIG[mbim] = "--with-mbim,--enable-mbim=no,libmbim,libmbim"
+PACKAGECONFIG[mbim] = "--with-mbim,--enable-mbim=no,libmbim"
 # Support WWAN modems and devices which speak the Qualcomm MSM Interface (QMI) protocol.
-PACKAGECONFIG[qmi] = "--with-qmi,--without-qmi,libqmi (>=1.12.4),libqmi (>=1.12.4)"
+PACKAGECONFIG[qmi] = "--with-qmi,--without-qmi,libqmi"
 
 FILES_${PN} += " \
     ${datadir}/icons \



On Mon, 2015-11-16 at 22:23 +0100, Martin Jansa wrote:
> On Wed, Nov 11, 2015 at 08:48:06PM +0100, Adrian Freihofer wrote:
> > Signed-off-by: Adrian Freihofer <adrian.freihofer@gmail.com>
> > ---
> >  .../modemmanager/modemmanager_1.4.12.bb                 | 17 ++++++++++++++++-
> >  1 file changed, 16 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.4.12.bb b/meta-oe/recipes
> > -connectivity/modemmanager/modemmanager_1.4.12.bb
> > index db7a28d..b1768ca 100644
> > --- a/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.4.12.bb
> > +++ b/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.4.12.bb
> > @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = " \
> >  
> >  inherit gnomebase gettext systemd
> >  
> > -DEPENDS = "glib-2.0 libmbim libqmi (>=1.12.4) polkit libgudev dbus-glib"
> > +DEPENDS = "glib-2.0 libgudev dbus-glib" 
> >  
> >  SRC_URI = "${GNOME_MIRROR}/ModemManager/ModemManager-${PV}.tar.xz"
> >  SRC_URI[md5sum] = "66cc7266b15525cb366253e6639fc564"
> > @@ -17,6 +17,21 @@ SRC_URI[sha256sum] = "7ef5035375a953b285a742591df0a65fd442f4641ce4d8f4392a41d6d6
> >  
> >  S = "${WORKDIR}/ModemManager-${PV}"
> >  
> > +# If you need a different configuration for modemmanager, add a statement
> > +# similar to the following example to your local.conf or distro config
> > +# PACKAGECONFIG_remove_pn-modemmanager = "polkit"
> > +PACKAGECONFIG ??= "mbim qmi polkit"
> > +
> > +EXTRA_OECONF = " \
> > +  ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '',
> > d)} \
> > +"
> 
> I've changed this to PACKAGECONFIG when cherry-picking to master-next
> 
> > +PACKAGECONFIG[polkit] = "--with-polkit=yes,--with-polkit=no,polkit"
> > +# Support WWAN modems and devices which speak the Mobile Interface Broadband Model (MBIM) protocol.
> > +PACKAGECONFIG[mbim] = "--with-mbim,--enable-mbim=no,libmbim,libmbim"
> > +# Support WWAN modems and devices which speak the Qualcomm MSM Interface (QMI) protocol.
> > +PACKAGECONFIG[qmi] = "--with-qmi,--without-qmi,libqmi (>=1.12.4),libqmi (>=1.12.4)"
> > +
> > +
> >  FILES_${PN} += " \
> >      ${datadir}/icons \
> >      ${datadir}/polkit-1 \
> > -- 
> > 2.4.3
> > 
> > -- 
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel