Re: [PATCH] base.bbclass: Add support to EXTRA_DISTRO_FEATURES

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Monday 29 July 2013 19:26:27 Otavio Salvador wrote:
> This allow the addition and removal of distro features easily. To add
> a feature, use:
> 
>  EXTRA_DISTRO_FEATURES += "wayland"
> 
> and to remove, use '~' prefix, as:
> 
>  EXTRA_DISTRO_FEATURES += "~x11"
> 
> This code has been mostly copied from Mentor Graphics public layer but
> changed the variable name for a more descriptive name. 

1) Isn't this just adding list subtraction via the back door, which Richard 
has already argued against (mostly because the interaction between it and 
_append/_prepend will be hard to predict)?

2) Why not just set DISTRO_FEATURES to contain just the items you want in your 
distro configuration instead of trying to add and subtract from some previous 
value? What if the previous value changes in a way that no longer fits your 
desired configuration? Surely it is better to just be explicit.

3) Even if we were to add this here wouldn't users expect this to work in all 
such variables and not just DISTRO_FEATURES?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre