From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH V8 3/7] libxl: add pvusb API Date: Wed, 18 Nov 2015 10:03:24 +0000 Message-ID: <1447841004.23626.13.camel@citrix.com> References: <1445418510-19614-1-git-send-email-cyliu@suse.com> <1445418510-19614-4-git-send-email-cyliu@suse.com> <20151113111921.GA16965@aepfle.de> <5649A988.7010609@citrix.com> <564C81CB0200006600084926@relay2.provo.novell.com> <20151118094410.GB21970@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151118094410.GB21970@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering , Chun Yan Liu Cc: Juergen Gross , wei.liu2@citrix.com, george.dunlap@eu.citrix.com, Ian.Jackson@eu.citrix.com, George Dunlap , xen-devel@lists.xen.org, Jim Fehlig , Simon Cao List-Id: xen-devel@lists.xenproject.org On Wed, 2015-11-18 at 10:44 +0100, Olaf Hering wrote: > On Tue, Nov 17, Chun Yan Liu wrote: > > > I think libxl_device_usb doesn't need to be changed into > > libxl_device_usbdev? > > In case of vscsi the struct and functions names are odd. It was not > obvious which one belongs to a ctrl and which one belongs to a device. > In the meantime I have changed everything related to a scsi host, it > contains now 'vscsictrl'. The names related to devices will follow. > > I suggest to do apply the same also to usb and make it clear what > belongs to a ctrl and what to a device. Havent checked your patch what > places that actually would be. Whatever you guys decide on please make sure the model used for these two device types are consistent with each other (and potentially other future device kinds using this model) and where it makes sense consistent with the controller-less device types whose template set of operations is already defined in libxl.h I'd been hoping that someone involved ion this would generate a patch adding a template for this controller+devices model to libxl.h, I've not seen anything since George's original RFC[0] "libxl: Introduce a template for devices with a controller". Ian. [0] <1432228052-15667-1-git-send-email-george.dunlap@eu.citrix.com>