All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, quintela@redhat.com, amit.shah@redhat.com
Cc: pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH 1/3] Set last_sent_block
Date: Wed, 18 Nov 2015 11:48:39 +0000	[thread overview]
Message-ID: <1447847321-20132-2-git-send-email-dgilbert@redhat.com> (raw)
In-Reply-To: <1447847321-20132-1-git-send-email-dgilbert@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

In a82d593b61054b3dea43 I accidentally removed the setting of
last_sent_block,  put it back.

Symptoms:
  Multithreaded compression only uses one thread.
  Migration is a bit less efficient since it won't use 'cont' flags.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Fixes: a82d593b61054b3dea43
---
 migration/ram.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/migration/ram.c b/migration/ram.c
index 7f32696..1eb155a 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1249,6 +1249,7 @@ static int ram_save_target_page(MigrationState *ms, QEMUFile *f,
         if (unsentmap) {
             clear_bit(dirty_ram_abs >> TARGET_PAGE_BITS, unsentmap);
         }
+        last_sent_block = block;
     }
 
     return res;
-- 
2.5.0

  reply	other threads:[~2015-11-18 11:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 11:48 [Qemu-devel] [PATCH 0/3] [For 2.5] Migration fixes Dr. David Alan Gilbert (git)
2015-11-18 11:48 ` Dr. David Alan Gilbert (git) [this message]
2015-11-18 12:02   ` [Qemu-devel] [PATCH 1/3] Set last_sent_block Juan Quintela
2015-11-18 11:48 ` [Qemu-devel] [PATCH 2/3] migration: Dead assignment of current_time Dr. David Alan Gilbert (git)
2015-11-18 12:02   ` Juan Quintela
2015-11-18 11:48 ` [Qemu-devel] [PATCH 3/3] Unneeded NULL check Dr. David Alan Gilbert (git)
2015-11-18 12:02   ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447847321-20132-2-git-send-email-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.