From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH] drm/i915: Cleaning up intel_dp_hpd_pulse Date: Fri, 20 Nov 2015 16:03:34 +0200 Message-ID: <1448028214.2773.14.camel@gmail.com> References: <564ACCBB.2050600@intel.com> <1447742832-1303-1-git-send-email-shubhangi.shrivastava@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id 597306E6A0 for ; Fri, 20 Nov 2015 06:03:37 -0800 (PST) Received: by pabfh17 with SMTP id fh17so121305345pab.0 for ; Fri, 20 Nov 2015 06:03:36 -0800 (PST) In-Reply-To: <1447742832-1303-1-git-send-email-shubhangi.shrivastava@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shubhangi Shrivastava , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMDE1LTExLTE3IGF0IDEyOjE3ICswNTMwLCBTaHViaGFuZ2kgU2hyaXZhc3RhdmEg d3JvdGU6Cj4gQ3VycmVudCBEUCBkZXRlY3Rpb24gaGFzIERQQ0Qgb3BlcmF0aW9ucyBzcGxpdCBh Y3Jvc3MKPiBpbnRlbF9kcF9ocGRfcHVsc2UgYW5kIGludGVsX2RwX2RldGVjdCB3aGljaCBjb250 YWlucwo+IGR1cGxpY2F0ZXMgYXMgd2VsbC4gQWxzbyBpbnRlbF9kcF9kZXRlY3QgaXMgY2FsbGVk Cj4gZHVyaW5nIG1vZGVzIGVudW1lcmF0aW9uIGFzIHdlbGwgd2hpY2ggd2lsbCByZXN1bHQKPiBp biBtdWx0aXBsZSBkcGNkIG9wZXJhdGlvbnMuIFNvIHRoaXMgcGF0Y2ggdHJpZXMKPiB0byBzb2x2 ZSBib3RoIHRoZXNlIGJ5IGJyaW5naW5nIGFsbCBEUENEIG9wZXJhdGlvbnMKPiBpbiBvbmUgc2lu Z2xlIGZ1bmN0aW9uIGFuZCBtYWtlIGludGVsX2RwX2RldGVjdAo+IHVzZSBleGlzdGluZyB2YWx1 ZXMgaW5zdGVhZCBvZiByZXBlYXRpbmcgc2FtZSBzdGVwcy4KPiAKPiB2MjogUHVsbGVkIGluIGEg aHVuayBmcm9tIGxhc3QgcGF0Y2ggb2YgdGhlIHNlcmllcyB0bwo+ICAgICB0aGlzIHBhdGNoLiAo QW5kZXIpCj4gCj4gU2lnbmVkLW9mZi1ieTogU2l2YWt1bWFyIFRodWxhc2ltYW5pIDxzaXZha3Vt YXIudGh1bGFzaW1hbmlAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFNodWJoYW5naSBTaHJp dmFzdGF2YSA8c2h1YmhhbmdpLnNocml2YXN0YXZhQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyB8IDI5ICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0t LS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCBkZDJiOWRhLi5lNGQ2ZDMzIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gQEAgLTQ2NjgsNiArNDY2OCwxNiBAQCBpbnRlbF9k cF9sb25nX3B1bHNlKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IKPiAqaW50ZWxfY29ubmVjdG9yKQo+ ICAJCQlpbnRlbF9lbmNvZGVyLT50eXBlID0gSU5URUxfT1VUUFVUX0RJU1BMQVlQT1JUOwo+ICAJ CXN0YXR1cyA9IGNvbm5lY3Rvcl9zdGF0dXNfZGlzY29ubmVjdGVkOwo+ICAJCWdvdG8gb3V0Owo+ ICsJfSBlbHNlIGlmIChjb25uZWN0b3ItPnN0YXR1cyA9PSBjb25uZWN0b3Jfc3RhdHVzX2Nvbm5l Y3RlZCkgewo+ICsJCS8qCj4gKwkJICogSWYgZGlzcGxheSB3YXMgY29ubmVjdGVkIGFscmVhZHkg YW5kIGlzIHN0aWxsIGNvbm5lY3RlZAo+ICsJCSAqIGNoZWNrIGxpbmtzIHN0YXR1cywgdGhlcmUg aGFzIGJlZW4ga25vd24gaXNzdWVzIG9mCj4gKwkJICogbGluayBsb3NzIHRyaWdnZXJyaW5nIGxv bmcgcHVsc2UhISEhCj4gKwkJICovCj4gKwkJZHJtX21vZGVzZXRfbG9jaygmZGV2LT5tb2RlX2Nv bmZpZy5jb25uZWN0aW9uX211dGV4LCBOVUxMKTsKPiArCQlpbnRlbF9kcF9jaGVja19saW5rX3N0 YXR1cyhpbnRlbF9kcCk7Cj4gKwkJZHJtX21vZGVzZXRfdW5sb2NrKCZkZXYtPm1vZGVfY29uZmln LmNvbm5lY3Rpb25fbXV0ZXgpOwo+ICsJCWdvdG8gb3V0Owo+ICAJfQo+ICAKPiAgCWludGVsX2Rw X3NldF9lZGlkKGludGVsX2RwKTsKPiBAQCAtNDcxNSw3ICs0NzI1LDggQEAgaW50ZWxfZHBfZGV0 ZWN0KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsIGJvb2wKPiBmb3JjZSkKPiAgCQly ZXR1cm4gY29ubmVjdG9yX3N0YXR1c19kaXNjb25uZWN0ZWQ7Cj4gIAl9Cj4gIAo+IC0JaW50ZWxf ZHBfbG9uZ19wdWxzZShpbnRlbF9kcC0+YXR0YWNoZWRfY29ubmVjdG9yKTsKPiArCWlmIChmb3Jj ZSkKPiArCQlpbnRlbF9kcF9sb25nX3B1bHNlKGludGVsX2RwLT5hdHRhY2hlZF9jb25uZWN0b3Ip Owo+ICAKPiAgCWlmIChpbnRlbF9jb25uZWN0b3ItPmRldGVjdF9lZGlkKQo+ICAJCXJldHVybiBj b25uZWN0b3Jfc3RhdHVzX2Nvbm5lY3RlZDsKPiBAQCAtNTA0NSwyMSArNTA1Niw5IEBAIGludGVs X2RwX2hwZF9wdWxzZShzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0Cj4gKmludGVsX2RpZ19wb3J0 LCBib29sIGxvbmdfaHBkKQo+ICAJCS8qIGluZGljYXRlIHRoYXQgd2UgbmVlZCB0byByZXN0YXJ0 IGxpbmsgdHJhaW5pbmcgKi8KPiAgCQlpbnRlbF9kcC0+dHJhaW5fc2V0X3ZhbGlkID0gZmFsc2U7 Cj4gIAo+IC0JCWlmICghaW50ZWxfZGlnaXRhbF9wb3J0X2Nvbm5lY3RlZChkZXZfcHJpdiwgaW50 ZWxfZGlnX3BvcnQpKQo+IC0JCQlnb3RvIG1zdF9mYWlsOwo+IC0KPiAtCQlpZiAoIWludGVsX2Rw X2dldF9kcGNkKGludGVsX2RwKSkgewo+IC0JCQlnb3RvIG1zdF9mYWlsOwo+IC0JCX0KPiAtCj4g LQkJaW50ZWxfZHBfcHJvYmVfb3VpKGludGVsX2RwKTsKPiArCQlpbnRlbF9kcF9sb25nX3B1bHNl KGludGVsX2RwLT5hdHRhY2hlZF9jb25uZWN0b3IpOwo+ICsJCWdvdG8gcHV0X3Bvd2VyOwoKVGhp cyBoYXMgdGhlIHByb2JsZW0gd2l0aCBoYW5kbGluZyBhbiBtc3QgZGV2aWNlIHRoYXQgaXMgZ29u ZSB3aGljaCBTaXZha3VtYXIKYW5kIEkgZGlzY3Vzc2VkIG9uIElSQy4KCkknbSB0aGlua2luZyB3 aGV0aGVyIGl0IG1ha2VzIHNlbnNlIHRvIG1vdmUgdGhlIGNvZGUgaW4gdGhlIG1zdF9mYWlsIGxh YmVsIHRvIAppbnRlbF9kcF9kZXRlY3QoKSwgc2luY2UgaXQgZ2V0cyBjYWxsZWQgZXZlcnkgdGlt ZSB3ZSByZWFjaCB0aGF0IGxhYmVsLiBXZSB3b3VsZApqdXN0IG5lZWQgYSB3YXkgdG8gdGVsbCBp dCBhYm91dCB0aGUgZmFpbHVyZSwgc2luY2Ugd2UgY2FuJ3QgcmVseSBvbiBjb25uZWN0b3IKc3Rh dHVzIGJlaW5nIGRpc2Nvbm5lY3RlZCAoYmVjYXVzZSBvZiBNU1QpLiBUaGF0IGNvdWxkIGhlbHAg dXMgY2xlYW4gdXAKaW50ZWxfZHBfaHBkX3B1bHNlIGV2ZW4gbW9yZS4KVGhvdWdodHM/CgpBbmRl cgoKPiAgCj4gLQkJaWYgKCFpbnRlbF9kcF9wcm9iZV9tc3QoaW50ZWxfZHApKSB7Cj4gLQkJCWRy bV9tb2Rlc2V0X2xvY2soJmRldi0+bW9kZV9jb25maWcuY29ubmVjdGlvbl9tdXRleCwKPiBOVUxM KTsKPiAtCQkJaW50ZWxfZHBfY2hlY2tfbGlua19zdGF0dXMoaW50ZWxfZHApOwo+IC0JCQlkcm1f bW9kZXNldF91bmxvY2soJmRldgo+IC0+bW9kZV9jb25maWcuY29ubmVjdGlvbl9tdXRleCk7Cj4g LQkJCWdvdG8gbXN0X2ZhaWw7Cj4gLQkJfQo+ICAJfSBlbHNlIHsKPiAgCQlpZiAoaW50ZWxfZHAt PmlzX21zdCkgewo+ICAJCQlpZiAoaW50ZWxfZHBfY2hlY2tfbXN0X3N0YXR1cyhpbnRlbF9kcCkg PT0gLUVJTlZBTCkKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK