From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST v2] Add $gho->{Suite} field to guest objects from {prepare, select}guest() Date: Mon, 23 Nov 2015 16:19:34 +0000 Message-ID: <1448295574.4973.64.camel@citrix.com> References: <1448275201.4973.36.camel@citrix.com> <1448282132-28614-1-git-send-email-ian.campbell@citrix.com> <22099.15086.667496.183873@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <22099.15086.667496.183873@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-11-23 at 16:12 +0000, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST v2] Add $gho->{Suite} field to guest > objects from {prepare,select}guest()"): > > Currently those places which want this open code a lookup of the > > {ident}_suite runvar with a fallback to the configuration file. > > > > However selecthost was missing such a lookup in the case where it is > > constructing a nested L1 host (which begins from the selectguest > > template), which lead to ts-xen-install on Jessie missing the > > installation of libnl-route-3-200. > > > > Fix this by having prepareguest() store a {ident}_suite runvar (taking > > care to handle the case where one is already set by e.g. make-flight) > > and have selectguest() initialise $gho->Suite from it. > > Having thought about this, ISTM that this will cause strangenesses > such as runvars called `redhat_suite' with value `jessie' (or > whatever). > > Perhaps ts-debian*install could call some new function > debian_guest_suite in Debian.pm ? Sure. Should it return the suite (to be put into $gho->{Suite} by the caller) or initialise $gho->{Suite} itself? I lean towards the latter. Ian.