From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 1/3] libxl: re-name libxl__xs_write() to libxl__xs_printf()... Date: Tue, 24 Nov 2015 16:22:41 +0000 Message-ID: <1448382161.26412.53.camel@citrix.com> References: <1447682423-1638-1-git-send-email-paul.durrant@citrix.com> <1447682423-1638-2-git-send-email-paul.durrant@citrix.com> <22090.3904.336845.189819@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a1GNS-0007zw-Bx for xen-devel@lists.xenproject.org; Tue, 24 Nov 2015 16:23:34 +0000 In-Reply-To: <22090.3904.336845.189819@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , Paul Durrant Cc: xen-devel@lists.xenproject.org, Wei Liu , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Mon, 2015-11-16 at 17:15 +0000, Ian Jackson wrote: > Paul Durrant writes ("[PATCH v2 1/3] libxl: re-name libxl__xs_write() to > libxl__xs_printf()..."): > > ...to denote what it actually does. > > > > The name libxl__xs_write() suggests something taking a buffer and > > length, > > akin to write(2), whereas the semantics of the function are actually > > more > > akin to printf(3). > > > > This patch is a textual substitution of libxl__xs_write with > > libxl__xs_printf with some associated formatting fixes. > > Acked-by: Ian Jackson Did you have opinions on the other two patches and/or shall I just apply this one in the meantime? Ian.