Re: [PATCH] video: fbdev: fsl: fix kernel crash when diu_ops is not implemented

[Scott Wood <scottwood@freescale.com>]

On Tue, 2015-11-24 at 12:16 -0500, Timur Tabi wrote:
> On Tue, Nov 24, 2015 at 12:05 PM, Scott Wood <scottwood@freescale.com>
> wrote:
> 
> > I asked Dongsheng to put it in probe() during internal review because at
> > the
> > time he was printing an error, and I didn't want the error to be printed
> > if
> > the device wasn't present.  Again, there's another non-bugfix patch
> > pending
> > that moves all the rest into probe() where it belongs.
> 
> I think it should be in _init, and not display an error.

As long as it doesn't display anything I don't care much either way.

> > > Third, you should probably add a boolean field
> > > to platform_diu_data_ops that gets set to True if/when the platform
> > > code initializes the rest of the structure.
> > 
> > Why do you want to complicate a simple bugfix with a requirement to modify
> > all
> > platforms that use the driver, introducing a possible regression if one is
> > missed?
> 
> Fair enough, but I think it should at least be documented by saying
> something about set_pixel_clock must be defined, so if it isn't, then
> that means the platform code does not support DIU at all, so just
> abort.

Sure.

-Scott