From: Joe Perches <joe@perches.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>, davem@davemloft.net
Cc: Mitch Williams <mitch.a.williams@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com
Subject: Re: [net-next 11/16] i40e/i40evf: clean up error messages
Date: Tue, 24 Nov 2015 16:49:26 -0800 [thread overview]
Message-ID: <1448412566.20113.17.camel@perches.com> (raw)
In-Reply-To: <1448409886-90686-12-git-send-email-jeffrey.t.kirsher@intel.com>
On Tue, 2015-11-24 at 16:04 -0800, Jeff Kirsher wrote:
> Clean up and enhance error messages related to VF MAC/VLAN filters.
> Indicate which VF is having issues, and if possible indicate the MAC
> address or VLAN involved.
trivia:
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
[]
> @@ -1623,7 +1623,8 @@ static int i40e_vc_add_mac_addr_msg(struct i40e_vf *vf, u8 *msg, u16 msglen)
>
> if (!f) {
> dev_err(&pf->pdev->dev,
> - "Unable to add VF MAC filter\n");
> + "Unable to add MAC filter %pM for VF %d\n",
> + al->list[i].addr, vf->vf_id);
Maybe use %hu for %d?
(here and elsewhere)
next prev parent reply other threads:[~2015-11-25 0:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 0:04 [net-next 00/16][pull request] Intel Wired LAN Driver Updates 2015-11-24 Jeff Kirsher
2015-11-25 0:04 ` [net-next 01/16] fm10k: use napi_schedule_irqoff() Jeff Kirsher
2015-11-25 0:04 ` [net-next 02/16] i40e/i40evf: remove unused tunnel parameter Jeff Kirsher
2015-11-25 0:04 ` [net-next 03/16] i40e: Change BUG_ON to WARN_ON in service event complete Jeff Kirsher
2015-11-25 0:04 ` [net-next 04/16] i40e: remove BUG_ON from feature string building Jeff Kirsher
2015-11-25 0:04 ` [net-next 05/16] i40e: remove BUG_ON from FCoE setup Jeff Kirsher
2015-11-25 0:04 ` [net-next 06/16] i40e: Properly cast type for arithmetic Jeff Kirsher
2015-11-25 0:43 ` Joe Perches
2015-11-25 1:57 ` David Miller
2015-11-25 10:46 ` Jeff Kirsher
2015-11-25 10:55 ` David Laight
2015-11-25 10:58 ` Joe Perches
2015-11-25 17:12 ` Rustad, Mark D
2015-11-25 0:04 ` [net-next 07/16] i40e: Workaround fix for mss < 256 issue Jeff Kirsher
2015-11-25 0:04 ` [net-next 08/16] i40e/i40evf: Add a stat to track how many times we have to do a force WB Jeff Kirsher
2015-11-25 0:04 ` [net-next 09/16] i40e: Move the saving of old link info from handle_link_event to link_event Jeff Kirsher
2015-11-25 0:04 ` [net-next 10/16] i40e/i40evf: Add comment to #endif Jeff Kirsher
2015-11-25 0:04 ` [net-next 11/16] i40e/i40evf: clean up error messages Jeff Kirsher
2015-11-25 0:49 ` Joe Perches [this message]
2015-11-25 0:04 ` [net-next 12/16] i40evf: handle many MAC filters correctly Jeff Kirsher
2015-11-25 0:04 ` [net-next 13/16] i40e: return the number of enabled queues for ETHTOOL_GRXRINGS Jeff Kirsher
2015-11-25 0:04 ` [net-next 14/16] i40e: rework the functions to configure RSS with similar parameters Jeff Kirsher
2015-11-25 0:04 ` [net-next 15/16] i40e: create a generic configure rss function Jeff Kirsher
2015-11-25 0:04 ` [net-next 16/16] i40e: Bump version to 1.4.2 Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448412566.20113.17.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jogreene@redhat.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.