From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH 03/12] drm/i915/skl: Update watermarks before the crtc is disabled. Date: Wed, 25 Nov 2015 11:33:13 +0200 Message-ID: <1448443993.2907.11.camel@gmail.com> References: <1447945645-32005-1-git-send-email-maarten.lankhorst@linux.intel.com> <1447945645-32005-4-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 017A26EA69 for ; Wed, 25 Nov 2015 01:33:20 -0800 (PST) Received: by padhx2 with SMTP id hx2so52314674pad.1 for ; Wed, 25 Nov 2015 01:33:19 -0800 (PST) In-Reply-To: <1447945645-32005-4-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org Cc: stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyMDE1LTExLTE5IGF0IDE2OjA3ICswMTAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90 ZToKPiBPbiBza3lsYWtlIHNvbWUgb2YgdGhlIHJlZ2lzdGVycyBhcmUgb25seSB3cml0YWJsZSB3 aGVuIHRoZSBjb3JyZWN0Cj4gcG93ZXIgd2VsbHMgYXJlIGVuYWJsZWQuIEJlY2F1c2Ugb2YgdGhp cyB3YXRlcm1hcmtzIGhhdmUgdG8gYmUgdXBkYXRlZAo+IGJlZm9yZSB0aGUgY3J0YyB0dXJucyBv ZmYsIG9yIHlvdSBnZXQgdW5jbGFpbWVkIHJlZ2lzdGVyIHJlYWQgYW5kIHdyaXRlCj4gd2Fybmlu Z3MuCj4gCj4gVGhpcyBwYXRjaCBuZWVkcyB0byBiZSBtb2RpZmllZCBzbGlnaHRseSB0byBhcHBs eSB0byAtZml4ZXMuCj4gCj4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcv c2hvd19idWcuY2dpP2lkPTkyMTgxCj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3Qg PG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiBDYzogc3RhYmxlQHZnZXIua2Vy bmVsLm9yZwo+IENjOiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgoKUmV2 aWV3ZWQtYnk6IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWlyYSA8Y29uc2VsdmFuMkBnbWFpbC5j b20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA1ICsr KystCj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCBkYjQ5OTU0MDYyNzcu LjUzNDVmZmNjZTUxZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBA QCAtNDc1Myw3ICs0NzUzLDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfcG9zdF9wbGFuZV91cGRhdGUo c3RydWN0IGludGVsX2NydGMKPiAqY3J0YykKPiAgCj4gIAljcnRjLT53bS5jeHNyX2FsbG93ZWQg PSB0cnVlOwo+ICAKPiAtCWlmIChwaXBlX2NvbmZpZy0+d21fY2hhbmdlZCkKPiArCWlmIChwaXBl X2NvbmZpZy0+d21fY2hhbmdlZCAmJiBwaXBlX2NvbmZpZy0+YmFzZS5hY3RpdmUpCj4gIAkJaW50 ZWxfdXBkYXRlX3dhdGVybWFya3MoJmNydGMtPmJhc2UpOwo+ICAKPiAgCWlmIChhdG9taWMtPnVw ZGF0ZV9mYmMpCj4gQEAgLTEzMzYyLDYgKzEzMzYyLDkgQEAgc3RhdGljIGludCBpbnRlbF9hdG9t aWNfY29tbWl0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJCWRldl9wcml2LT5kaXNwbGF5 LmNydGNfZGlzYWJsZShjcnRjKTsKPiAgCQkJaW50ZWxfY3J0Yy0+YWN0aXZlID0gZmFsc2U7Cj4g IAkJCWludGVsX2Rpc2FibGVfc2hhcmVkX2RwbGwoaW50ZWxfY3J0Yyk7Cj4gKwo+ICsJCQlpZiAo IWNydGMtPnN0YXRlLT5hY3RpdmUpCj4gKwkJCQlpbnRlbF91cGRhdGVfd2F0ZXJtYXJrcyhjcnRj KTsKPiAgCQl9Cj4gIAl9Cj4gIApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f51.google.com ([209.85.220.51]:34158 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750709AbbKYJdU (ORCPT ); Wed, 25 Nov 2015 04:33:20 -0500 Received: by padhx2 with SMTP id hx2so52314673pad.1 for ; Wed, 25 Nov 2015 01:33:19 -0800 (PST) Message-ID: <1448443993.2907.11.camel@gmail.com> Subject: Re: [Intel-gfx] [PATCH 03/12] drm/i915/skl: Update watermarks before the crtc is disabled. From: Ander Conselvan De Oliveira To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org Cc: stable@vger.kernel.org Date: Wed, 25 Nov 2015 11:33:13 +0200 In-Reply-To: <1447945645-32005-4-git-send-email-maarten.lankhorst@linux.intel.com> References: <1447945645-32005-1-git-send-email-maarten.lankhorst@linux.intel.com> <1447945645-32005-4-git-send-email-maarten.lankhorst@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Thu, 2015-11-19 at 16:07 +0100, Maarten Lankhorst wrote: > On skylake some of the registers are only writable when the correct > power wells are enabled. Because of this watermarks have to be updated > before the crtc turns off, or you get unclaimed register read and write > warnings. > > This patch needs to be modified slightly to apply to -fixes. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92181 > Signed-off-by: Maarten Lankhorst > Cc: stable@vger.kernel.org > Cc: Matt Roper Reviewed-by: Ander Conselvan de Oliveira > --- > drivers/gpu/drm/i915/intel_display.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index db4995406277..5345ffcce51e 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -4753,7 +4753,7 @@ static void intel_post_plane_update(struct intel_crtc > *crtc) > > crtc->wm.cxsr_allowed = true; > > - if (pipe_config->wm_changed) > + if (pipe_config->wm_changed && pipe_config->base.active) > intel_update_watermarks(&crtc->base); > > if (atomic->update_fbc) > @@ -13362,6 +13362,9 @@ static int intel_atomic_commit(struct drm_device *dev, > dev_priv->display.crtc_disable(crtc); > intel_crtc->active = false; > intel_disable_shared_dpll(intel_crtc); > + > + if (!crtc->state->active) > + intel_update_watermarks(crtc); > } > } >