From: Ian Campbell <ian.campbell@citrix.com>
To: Paul Durrant <Paul.Durrant@citrix.com>,
Ian Jackson <Ian.Jackson@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Stefano Stabellini <Stefano.Stabellini@citrix.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [RFC PATCH 2/6] libxl: stop using libxl__xs_mkdir() for ~/control/shutdown
Date: Wed, 25 Nov 2015 11:02:09 +0000 [thread overview]
Message-ID: <1448449329.17688.64.camel@citrix.com> (raw)
In-Reply-To: <9AAE0902D5BC7E449B7C8E4E778ABCD02F697254@AMSPEX01CL01.citrite.net>
On Wed, 2015-11-25 at 10:46 +0000, Paul Durrant wrote:
> > Or maybe this is the behaviour of XS_MKDIR on a path/node which already
> > exists?
> >
>
> Yes, that's exactly it. I believe XS_MKDIR does guarantee to create a
> path empty, but will not clear an existing one.
Thanks.
I suppose clearing a node on mkdir would be an equally surprising semantic,
after all mkdir(1) doesn't remove all files in an existing directory.
It's a pity MKDIR doesn't follow mkdir(1) and return EEXIST, but we are
stuck with that I guess.
As well as the changes being considered here I wonder if any
libxl__xs_mkdir alike ought to include the existence check and error
return?
Ian.
next prev parent reply other threads:[~2015-11-25 11:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 16:18 [RFC PATCH 0/6] libxl: xenstore related changes Paul Durrant
2015-11-11 16:18 ` [RFC PATCH 1/6] libxl: re-name libxl__xs_write() to libxl__xs_printf() Paul Durrant
2015-11-11 16:18 ` [RFC PATCH 2/6] libxl: stop using libxl__xs_mkdir() for ~/control/shutdown Paul Durrant
2015-11-16 12:55 ` Ian Campbell
2015-11-16 13:16 ` Paul Durrant
2015-11-16 13:42 ` Ian Campbell
2015-11-16 13:45 ` Paul Durrant
2015-11-16 17:20 ` Ian Jackson
2015-11-16 17:22 ` Paul Durrant
2015-11-16 17:30 ` Ian Jackson
2015-11-16 17:33 ` Paul Durrant
2015-11-24 16:34 ` Ian Jackson
2015-11-24 17:20 ` Paul Durrant
2015-11-24 17:24 ` Ian Jackson
2015-11-24 17:28 ` Paul Durrant
2015-11-24 17:38 ` Ian Jackson
2015-11-24 17:41 ` Paul Durrant
2015-11-24 17:44 ` Ian Jackson
2015-11-25 10:42 ` Ian Campbell
2015-11-25 10:46 ` Paul Durrant
2015-11-25 11:02 ` Ian Campbell [this message]
2015-11-25 11:07 ` Paul Durrant
2015-11-25 11:13 ` Ian Jackson
2015-11-25 11:14 ` Paul Durrant
2015-11-25 11:11 ` Ian Jackson
2015-11-11 16:18 ` [RFC PATCH 3/6] libxl: implement control feature checking Paul Durrant
2015-11-16 17:24 ` Ian Jackson
2015-11-11 16:18 ` [RFC PATCH 4/6] libxl: add guest writable xenstore area for driver versions Paul Durrant
2015-11-16 17:26 ` Ian Jackson
2015-11-16 17:26 ` Ian Jackson
2015-11-11 16:18 ` [RFC PATCH 5/6] libxl: add guest writable xenstore area for feature advertisement Paul Durrant
2015-11-16 17:27 ` Ian Jackson
2015-11-11 16:18 ` [RFC PATCH 6/6] libxl: create path for advertisement of network attributes Paul Durrant
2015-11-16 17:29 ` Ian Jackson
2015-11-16 17:31 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448449329.17688.64.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=Stefano.Stabellini@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.