From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 3/4] gdbsx: prefer privcmd character device Date: Wed, 25 Nov 2015 11:13:02 +0000 Message-ID: <1448449982.17688.70.camel@citrix.com> References: <1448390855-13505-1-git-send-email-cardoe@cardoe.com> <1448390855-13505-3-git-send-email-cardoe@cardoe.com> <22100.45608.914912.205420@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <22100.45608.914912.205420@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , Doug Goldstein Cc: Mukesh Rathor , Stefano Stabellini , Wei Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-11-24 at 18:53 +0000, Ian Jackson wrote: > Doug Goldstein writes ("[PATCH 3/4] gdbsx: prefer privcmd character > device"): > > Prefer using the character device over the proc file if the character > > device exists. > > I think this common logic (which also appears in your 1/4 patch) > should be factored out. > For reasons I don't really understand gdbsc appears to avoid the use of libxenctrl completely and has it's own h/call wrapper and such. (Perhaps a legacy of it being out of tree?)