From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50788)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1a1rDC-00067l-Oz
	for qemu-devel@nongnu.org; Thu, 26 Nov 2015 02:43:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1a1rD8-0003Ub-O9
	for qemu-devel@nongnu.org; Thu, 26 Nov 2015 02:43:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46394)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1a1rD8-0003UH-IT
	for qemu-devel@nongnu.org; Thu, 26 Nov 2015 02:43:22 -0500
Message-ID: <1448523799.8613.7.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 26 Nov 2015 08:43:19 +0100
In-Reply-To: <5654969F.3000306@redhat.com>
References: <5654969F.3000306@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [SeaBIOS] bug: incorrect uuid in seabios output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cole Robinson <crobinso@redhat.com>
Cc: seabios@seabios.org, qemu-devel <qemu-devel@nongnu.org>

On Di, 2015-11-24 at 11:55 -0500, Cole Robinson wrote:
> Hi,
> 
> The UUID seabios reports in its boot output doesn't match what is passed via
> qemu -uuid option. An example is reported here:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1284259
> 
> This is due to:
> 
> commit caad057bb6ce86a9cb71520af395fd0bd04a659f
> Author: Eduardo Habkost <ehabkost@redhat.com>
> Date:   Wed Oct 29 11:26:08 2014 -0200
> 
>     smbios: Encode UUID according to SMBIOS specification
> 
>     Differently from older versions, SMBIOS version 2.6 is explicit about
>     the encoding of UUID fields:
> 
>     > Although RFC 4122 recommends network byte order for all fields, the PC
>     > industry (including the ACPI, UEFI, and Microsoft specifications) has
>     > consistently used little-endian byte encoding for the first three fields:
>     > time_low, time_mid, time_hi_and_version. The same encoding, also known as
>     > wire format, should also be used for the SMBIOS representation of the UUID.
>     >
>     > The UUID {00112233-4455-6677-8899-AABBCCDDEEFF} would thus be represented
>     > as 33 22 11 00 55 44 77 66 88 99 AA BB CC DD EE FF.
> 
>     The dmidecode tool implements this and decodes the above "wire format"
>     when SMBIOS version >= 2.6. We moved from SMBIOS version 2.4 to 2.8 when
>     we started building the SMBIOS entry point inside QEMU, on commit
>     c97294ec1b9e36887e119589d456557d72ab37b5.
> 
> 
> seabios doesn't seem to handle this special UUID format when reading from smbios.

Hmm.  Changing the ordering in display_uuid() is easy.  There seems to
be no easy way to figure which format to use though.  Checking the
version like dmidecode doesn't fly as there are qemu versions with old
format but version smbios 2.8 in the wild ...

cheers,
  Gerd