From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] libxl: Be more careful with error handling in libxl__dm_runas_helper() Date: Thu, 26 Nov 2015 10:15:12 +0100 Message-ID: <1448529312.7833.208.camel@citrix.com> References: <1448488569-3003-1-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7060844950635667468==" Return-path: In-Reply-To: <1448488569-3003-1-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky , ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com, wei.liu2@citrix.com Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============7060844950635667468== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-vt5Aew/LeWGLZPyQSNSB" --=-vt5Aew/LeWGLZPyQSNSB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 T24gV2VkLCAyMDE1LTExLTI1IGF0IDE2OjU2IC0wNTAwLCBCb3JpcyBPc3Ryb3Zza3kgd3JvdGU6 Cj4gZ2V0cHduYW1fcigpIGhhcyBmYWlybHkgY29tcGxpY2F0ZWQgcmV0dXJuIHJ1bGVzLiBGcm9t IG1hbiBwYWdlczoKPiAKPiDCoCBSRVRVUk4gVkFMVUUKPiDCoMKgwqDCoMKgwqAuLi4KPiDCoMKg wqDCoMKgwqBPbiBzdWNjZXNzLCBnZXRwd25hbV9yKCkgYW5kIGdldHB3dWlkX3IoKSByZXR1cm4g emVybywgYW5kIHNldAo+IMKgwqDCoMKgwqDCoCpyZXN1bHQgdG8gcHdkLsKgwqBJZiBubyBtYXRj aGluZ8KgwqBwYXNzd29yZCByZWNvcmQgd2FzIGZvdW5kLAo+IHRoZXNlCj4gwqDCoMKgwqDCoMKg ZnVuY3Rpb25zIHJldHVybiAwIGFuZCBzdG9yZSBOVUxMIGluICpyZXN1bHQuIEluIGNhc2Ugb2Yg ZXJyb3IsCj4gwqDCoMKgwqDCoMKgYW4gZXJyb3IgbnVtYmVyIGlzIHJldHVybmVkLCBhbmQgTlVM TCBpcyBzdG9yZWQgaW4gKnJlc3VsdC4KPiDCoCBFUlJPUlMKPiDCoMKgwqDCoMKgwqAwIG9yIEVO T0VOVCBvciBFU1JDSCBvciBFQkFERiBvciBFUEVSTSBvciAuLi4KPiDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqBUaGUgZ2l2ZW4gbmFtZSBvciB1aWQgd2FzIG5vdCBmb3VuZC4KPiAKV293ISBHaXZl biBob3cgbXVjaCBoZSBsaWtlcyBlcnJvciBoYW5kbGluZywgSSBjYW4ndCB3YWl0IHRvIHNlZSBJ YW4KSmFja3NvbiBqdW1waW5nIG9uIHRoaXMhIDotUFAKCj4gV2hpbGUgaXQncyBub3QgY2xlYXIg d2hhdCBlbGxpcHNlcyBhcmUgbWVhbnQgdG8gYmUsIHRoZSB3YXkgd2UKPiBjdXJyZW50bHkKPiB0 cmVhdCByZXR1cm4gdmFsdWVzIGZyb20gZ2V0cHduYW1fcigpIGlzIG5vIHN1ZmZpY2llbnQuIElu IGZhY3QsIHR3bwo+IG9mCj4gbXkgc3lzdGVtcyBiZWhhdmUgZGlmZmVyZW50bHkgd2hlbiB1c2Vy bmFtZSBpcyBub3QgZm91bmQ6IG9uZSByZXR1cm5zCj4gRU5PRU5UIGFuZCB0aGUgb3RoZXIgcmV0 dXJucyAwLiBCb3RoIHNldCAqcmVzdWx0IHRvIE5VTEwuCj4gCk5pY2UuIE9yIG5vdC4gOi0vCgpB bnl3YXksIGdpdmVuIGV4YWN0bHkgdGhvc2UgZWxsaXBzZXMsIHdvdWxkbid0IGl0IGJlIHNhZmVy IHRvIGdvIHRoZQpvdGhlciB3YXkgcm91bmQ/IEkgbWVhbiBzb21ldGhpbmcgbGlrZToKCj4gQEAg LTc0MCwxMiArNzQwLDE3IEBAIHN0YXRpYyBpbnQgbGlieGxfX2RtX3J1bmFzX2hlbHBlcihsaWJ4 bF9fZ2MKPiAqZ2MsIGNvbnN0IGNoYXIgKnVzZXJuYW1lKQo+IMKgwqDCoMKgwqDCoMKgwqDCoHJl dCA9IGdldHB3bmFtX3IodXNlcm5hbWUsICZwd2QsIGJ1ZiwgYnVmX3NpemUsICZ1c2VyKTsKPiDC oMKgwqDCoMKgwqDCoMKgwqBpZiAocmV0ID09IEVSQU5HRSkgewo+IMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgYnVmX3NpemUgKz0gMTI4Owo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBpZiAo cmV0cnlfY250KysgPiAxMCkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoHJldHVybiBFUlJPUl9GQUlMOwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgY29udGlu dWU7Cj4gwqDCoMKgwqDCoMKgwqDCoMKgfQo+IC3CoMKgwqDCoMKgwqDCoMKgaWYgKHJldCAhPSAw KQo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZXR1cm4gRVJST1JfRkFJTDsKPiAtwqDCoMKg wqDCoMKgwqDCoGlmICh1c2VyICE9IE5VTEwpCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJl dHVybiAxOwo+ICvCoMKgwqDCoMKgwqDCoMKgaWYgKHVzZXIgPT0gTlVMTCkgewo+ICvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqBpZiAoIXJldCB8fCAocmV0ID09IEVOT0VOVCkgfHwgKHJldCA9PSBF U1JDSCkgfHwKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAocmV0ID09IEVCQURG KSB8fCAocmV0ID09IEVQRVJNKSkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBy ZXR1cm4gRVJST1JfTk9URk9VTkQ7Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGVsc2UKPiAr wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZXR1cm4gRVJST1JfRkFJTDsKPiArwqDC oMKgwqDCoMKgwqDCoH0KPgrCoCBpZiAodXNlciA9PSBOVUxMKSB7CsKgIMKgIMKgIGlmIChyZXQg PT0gRUlOVFIgfHwgcmV0ID09IEVJTyB8fCByZXQgPT0gRU1GSUxFIHx8CsKgIMKgIMKgIMKgIMKg IHJldCA9PSBFTkZJTEUgfHwgcmV0ID09IEVOT01FTSkKwqAgwqAgwqAgwqAgwqAgcmV0dXJuIEVS Uk9SX0ZBSUw7CsKgIMKgIMKgIGVsc2UKwqAgwqAgwqAgwqAgwqAgcmV0dXJuIEVSUk9SX05PVEZP VU5EOwrCoCB9CgpBbHNvLCBjb25zaWRlcmluZyBsaWJ4bCBhdHRpdHVkZSB0b3dhcmQgb3V0LW9m LW1lbW9yeSBlcnJvcnMsIHNob3VsZCB3ZQpkZWFsIHdpdGggRU5PTUVNIGluIGEgc3BlY2lhbCB3 YXk/CgpSZWdhcmRzLApEYXJpbwotLSAKPDxUaGlzIGhhcHBlbnMgYmVjYXVzZSBJIGNob29zZSBp dCB0byBoYXBwZW4hPj4gKFJhaXN0bGluIE1hamVyZSkKLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KRGFyaW8gRmFnZ2lvbGks IFBoLkQsIGh0dHA6Ly9hYm91dC5tZS9kYXJpby5mYWdnaW9saQpTZW5pb3IgU29mdHdhcmUgRW5n aW5lZXIsIENpdHJpeCBTeXN0ZW1zIFImRCBMdGQuLCBDYW1icmlkZ2UgKFVLKQoK --=-vt5Aew/LeWGLZPyQSNSB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlZWzaAACgkQk4XaBE3IOsQI6ACgi56axysREGmHsPJZWsEtwYAU 57wAoKUa6nFpXWdv4lvjNVrYEqhlqoOt =3Xk4 -----END PGP SIGNATURE----- --=-vt5Aew/LeWGLZPyQSNSB-- --===============7060844950635667468== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7060844950635667468==--