From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] libxl: Be more careful with error handling in libxl__dm_runas_helper() Date: Thu, 26 Nov 2015 10:03:35 +0000 Message-ID: <1448532215.12165.14.camel@citrix.com> References: <1448488569-3003-1-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1448488569-3003-1-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky , ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gV2VkLCAyMDE1LTExLTI1IGF0IDE2OjU2IC0wNTAwLCBCb3JpcyBPc3Ryb3Zza3kgd3JvdGU6 Cj4gZ2V0cHduYW1fcigpIGhhcyBmYWlybHkgY29tcGxpY2F0ZWQgcmV0dXJuIHJ1bGVzLiBGcm9t IG1hbiBwYWdlczoKPiAKPiDCoCBSRVRVUk4gVkFMVUUKPiDCoMKgwqDCoMKgwqAuLi4KPiDCoMKg wqDCoMKgwqBPbiBzdWNjZXNzLCBnZXRwd25hbV9yKCkgYW5kIGdldHB3dWlkX3IoKSByZXR1cm4g emVybywgYW5kIHNldAo+IMKgwqDCoMKgwqDCoCpyZXN1bHQgdG8gcHdkLsKgwqBJZiBubyBtYXRj aGluZ8KgwqBwYXNzd29yZCByZWNvcmQgd2FzIGZvdW5kLCB0aGVzZQo+IMKgwqDCoMKgwqDCoGZ1 bmN0aW9ucyByZXR1cm4gMCBhbmQgc3RvcmUgTlVMTCBpbiAqcmVzdWx0LiBJbiBjYXNlIG9mIGVy cm9yLAo+IMKgwqDCoMKgwqDCoGFuIGVycm9yIG51bWJlciBpcyByZXR1cm5lZCwgYW5kIE5VTEwg aXMgc3RvcmVkIGluICpyZXN1bHQuCj4gwqAgRVJST1JTCj4gwqDCoMKgwqDCoMKgMCBvciBFTk9F TlQgb3IgRVNSQ0ggb3IgRUJBREYgb3IgRVBFUk0gb3IgLi4uCj4gwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgVGhlIGdpdmVuIG5hbWUgb3IgdWlkIHdhcyBub3QgZm91bmQuCgpNeSByZWZlcmVuY2Ug d2hlbiByZXZpZXdpbmcgdGhpcyBpcyB0aGUgKElNSE8gbW9yZSBjYW5vbmljYWwpwqBodHRwOi8v cHVicy5vCnBlbmdyb3VwLm9yZy9vbmxpbmVwdWJzLzk2OTk5MTk3OTkvZnVuY3Rpb25zL2dldHB3 bmFtLmh0bWzCoC4KCkkgc3VwcG9zZSB5b3UgYXJlIGxvb2tpbmcgYXQgdGhlIExpbnV4IGFuZC9v ciBnbGliYyBtYW4gcGFnZXM/Cgo+IFdoaWxlIGl0J3Mgbm90IGNsZWFyIHdoYXQgZWxsaXBzZXMg YXJlIG1lYW50IHRvIGJlLCB0aGUgd2F5IHdlIGN1cnJlbnRseQo+IHRyZWF0IHJldHVybiB2YWx1 ZXMgZnJvbSBnZXRwd25hbV9yKCkgaXMgbm8gc3VmZmljaWVudC4gSW4gZmFjdCwgdHdvIG9mCj4g bXkgc3lzdGVtcyBiZWhhdmUgZGlmZmVyZW50bHkgd2hlbiB1c2VybmFtZSBpcyBub3QgZm91bmQ6 IG9uZSByZXR1cm5zCj4gRU5PRU5UIGFuZCB0aGUgb3RoZXIgcmV0dXJucyAwLgoKV2hpY2ggdHdv IHN5c3RlbXMgYXJlIHRoZXNlPyBXaGVuIHlvdSBzYXkgInJldHVybnMiIGRvIHlvdSBtZWFuICJy ZXR1cm5zIDAKYW5kIHNldHMgZXJybm8gdG8gWFhYIiBvciBsaXRlcmFsbHkgcmV0dXJucyBFTk9F TlQ/Cgo+ICBCb3RoIHNldCAqcmVzdWx0IHRvIE5VTEwuCj4gCj4gVGhpcyBwYXRjaCBhZGp1c3Rz IHJldHVybiB2YWx1ZSBtYW5hZ2VtZW50IHRvIGJlIG1vcmUgaW4gbGluZSB3aXRoIG1hbgo+IHBh Z2VzLgo+IAo+IFdoaWxlIGF0IGl0LCBhbHNvIG1ha2Ugc3VyZSB3ZSBkb24ndCBnZXQgc3R1Y2sg b24gRVJBTkdFLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEJvcmlzIE9zdHJvdnNreSA8Ym9yaXMub3N0 cm92c2t5QG9yYWNsZS5jb20+Cj4gLS0tCj4gwqB0b29scy9saWJ4bC9saWJ4bF9kbS5jIHwgMjMg KysrKysrKysrKysrKystLS0tLS0tLS0KPiDCoDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25z KCspLCA5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS90b29scy9saWJ4bC9saWJ4bF9k bS5jIGIvdG9vbHMvbGlieGwvbGlieGxfZG0uYwo+IGluZGV4IGE0OTM0ZGYuLmJkM2RhZWIgMTAw NjQ0Cj4gLS0tIGEvdG9vbHMvbGlieGwvbGlieGxfZG0uYwo+ICsrKyBiL3Rvb2xzL2xpYnhsL2xp YnhsX2RtLmMKPiBAQCAtNzI2LDcgKzcyNiw3IEBAIHN0YXRpYyBpbnQgbGlieGxfX2RtX3J1bmFz X2hlbHBlcihsaWJ4bF9fZ2MgKmdjLAo+IGNvbnN0IGNoYXIgKnVzZXJuYW1lKQo+IMKgwqDCoMKg wqBzdHJ1Y3QgcGFzc3dkIHB3ZCwgKnVzZXIgPSBOVUxMOwo+IMKgwqDCoMKgwqBjaGFyICpidWYg PSBOVUxMOwo+IMKgwqDCoMKgwqBsb25nIGJ1Zl9zaXplOwo+IC3CoMKgwqDCoGludCByZXQ7Cj4g K8KgwqDCoMKgaW50IHJldCwgcmV0cnlfY250ID0gMDsKPiDCoAo+IMKgwqDCoMKgwqBidWZfc2l6 ZSA9IHN5c2NvbmYoX1NDX0dFVFBXX1JfU0laRV9NQVgpOwo+IMKgwqDCoMKgwqBpZiAoYnVmX3Np emUgPCAwKSB7Cj4gQEAgLTc0MCwxMiArNzQwLDE3IEBAIHN0YXRpYyBpbnQgbGlieGxfX2RtX3J1 bmFzX2hlbHBlcihsaWJ4bF9fZ2MgKmdjLAo+IGNvbnN0IGNoYXIgKnVzZXJuYW1lKQo+IMKgwqDC oMKgwqDCoMKgwqDCoHJldCA9IGdldHB3bmFtX3IodXNlcm5hbWUsICZwd2QsIGJ1ZiwgYnVmX3Np emUsICZ1c2VyKTsKPiDCoMKgwqDCoMKgwqDCoMKgwqBpZiAocmV0ID09IEVSQU5HRSkgewo+IMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgYnVmX3NpemUgKz0gMTI4Owo+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqBpZiAocmV0cnlfY250KysgPiAxMCkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiBFUlJPUl9GQUlMOwo+IMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgY29udGludWU7Cj4gwqDCoMKgwqDCoMKgwqDCoMKgfQo+IC3CoMKgwqDCoMKgwqDC oMKgaWYgKHJldCAhPSAwKQo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZXR1cm4gRVJST1Jf RkFJTDsKPiAtwqDCoMKgwqDCoMKgwqDCoGlmICh1c2VyICE9IE5VTEwpCj4gLcKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoHJldHVybiAxOwo+ICvCoMKgwqDCoMKgwqDCoMKgaWYgKHVzZXIgPT0gTlVM TCkgewo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBpZiAoIXJldCB8fCAocmV0ID09IEVOT0VO VCkgfHwgKHJldCA9PSBFU1JDSCkgfHwKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAocmV0ID09IEVCQURGKSB8fCAocmV0ID09IEVQRVJNKSkKPiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqByZXR1cm4gRVJST1JfTk9URk9VTkQ7Cj4gK8KgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoGVsc2UKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZXR1cm4gRVJS T1JfRkFJTDsKPiArwqDCoMKgwqDCoMKgwqDCoH0KPiDCoMKgwqDCoMKgwqDCoMKgwqByZXR1cm4g MDsKPiDCoMKgwqDCoMKgfQo+IMKgfQo+IEBAIC0xMjYxLDE2ICsxMjY2LDE2IEBAIHN0YXRpYyBp bnQKPiBsaWJ4bF9fYnVpbGRfZGV2aWNlX21vZGVsX2FyZ3NfbmV3KGxpYnhsX19nYyAqZ2MsCj4g wqAKPiDCoMKgwqDCoMKgwqDCoMKgwqB1c2VyID0gR0NTUFJJTlRGKCIlcyVkIiwgTElCWExfUUVN VV9VU0VSX0JBU0UsIGd1ZXN0X2RvbWlkKTsKPiDCoMKgwqDCoMKgwqDCoMKgwqByZXQgPSBsaWJ4 bF9fZG1fcnVuYXNfaGVscGVyKGdjLCB1c2VyKTsKPiAtwqDCoMKgwqDCoMKgwqDCoGlmIChyZXQg PCAwKQo+ICvCoMKgwqDCoMKgwqDCoMKgaWYgKHJldCAmJiAocmV0ICE9IEVSUk9SX05PVEZPVU5E KSkKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiByZXQ7Cj4gLcKgwqDCoMKgwqDC oMKgwqBpZiAocmV0ID4gMCkKPiArwqDCoMKgwqDCoMKgwqDCoGlmICghcmV0KQo+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgZ290byBlbmRfc2VhcmNoOwo+IMKgCj4gwqDCoMKgwqDCoMKgwqDC oMKgdXNlciA9IExJQlhMX1FFTVVfVVNFUl9TSEFSRUQ7Cj4gwqDCoMKgwqDCoMKgwqDCoMKgcmV0 ID0gbGlieGxfX2RtX3J1bmFzX2hlbHBlcihnYywgdXNlcik7Cj4gLcKgwqDCoMKgwqDCoMKgwqBp ZiAocmV0IDwgMCkKPiArwqDCoMKgwqDCoMKgwqDCoGlmIChyZXQgJiYgKHJldCAhPSBFUlJPUl9O T1RGT1VORCkpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZXR1cm4gcmV0Owo+IC3CoMKg wqDCoMKgwqDCoMKgaWYgKHJldCA+IDApIHsKPiArwqDCoMKgwqDCoMKgwqDCoGlmICghcmV0KSB7 Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBMT0coV0FSTiwgIkNvdWxkIG5vdCBmaW5kIHVz ZXIgJXMlZCwgZmFsbGluZyBiYWNrIHRvICVzIiwKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqBMSUJYTF9RRU1VX1VTRVJfQkFTRSwgZ3Vlc3RfZG9taWQsCj4gTElC WExfUUVNVV9VU0VSX1NIQVJFRCk7Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBnb3RvIGVu ZF9zZWFyY2g7Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Clhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xp c3RzLnhlbi5vcmcveGVuLWRldmVsCg==