From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] libxl: Be more careful with error handling
 in libxl__dm_runas_helper()
Date: Thu, 26 Nov 2015 10:16:55 +0000
Message-ID: <1448533015.12165.15.camel@citrix.com>
References: <1448488569-3003-1-git-send-email-boris.ostrovsky@oracle.com>
	<1448532215.12165.14.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1448532215.12165.14.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

T24gVGh1LCAyMDE1LTExLTI2IGF0IDEwOjAzICswMDAwLCBJYW4gQ2FtcGJlbGwgd3JvdGU6Cj4g
T24gV2VkLCAyMDE1LTExLTI1IGF0IDE2OjU2IC0wNTAwLCBCb3JpcyBPc3Ryb3Zza3kgd3JvdGU6
Cj4gPiBnZXRwd25hbV9yKCkgaGFzIGZhaXJseSBjb21wbGljYXRlZCByZXR1cm4gcnVsZXMuIEZy
b20gbWFuIHBhZ2VzOgo+ID4gCj4gPiDCoCBSRVRVUk4gVkFMVUUKPiA+IMKgwqDCoMKgwqDCoC4u
Lgo+ID4gwqDCoMKgwqDCoMKgT24gc3VjY2VzcywgZ2V0cHduYW1fcigpIGFuZCBnZXRwd3VpZF9y
KCkgcmV0dXJuIHplcm8sIGFuZCBzZXQKPiA+IMKgwqDCoMKgwqDCoCpyZXN1bHQgdG8gcHdkLsKg
wqBJZiBubyBtYXRjaGluZ8KgwqBwYXNzd29yZCByZWNvcmQgd2FzIGZvdW5kLCB0aGVzZQo+ID4g
wqDCoMKgwqDCoMKgZnVuY3Rpb25zIHJldHVybiAwIGFuZCBzdG9yZSBOVUxMIGluICpyZXN1bHQu
IEluIGNhc2Ugb2YgZXJyb3IsCj4gPiDCoMKgwqDCoMKgwqBhbiBlcnJvciBudW1iZXIgaXMgcmV0
dXJuZWQsIGFuZCBOVUxMIGlzIHN0b3JlZCBpbiAqcmVzdWx0Lgo+ID4gwqAgRVJST1JTCj4gPiDC
oMKgwqDCoMKgwqAwIG9yIEVOT0VOVCBvciBFU1JDSCBvciBFQkFERiBvciBFUEVSTSBvciAuLi4K
PiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoFRoZSBnaXZlbiBuYW1lIG9yIHVpZCB3YXMgbm90
IGZvdW5kLgo+IAo+IE15IHJlZmVyZW5jZSB3aGVuIHJldmlld2luZyB0aGlzIGlzIHRoZSAoSU1I
TyBtb3JlIGNhbm9uaWNhbCnCoGh0dHA6Ly9wdWJzLm8KPiBwZW5ncm91cC5vcmcvb25saW5lcHVi
cy85Njk5OTE5Nzk5L2Z1bmN0aW9ucy9nZXRwd25hbS5odG1swqAuCgpNYXliZSB3ZSBzaG91bGQg
YmUgY29uc2lkZXJpbmcgd2hldGhlciAiQXBwbGljYXRpb25zIHdpc2hpbmcgdG8gY2hlY2sgZm9y
CmVycm9yIHNpdHVhdGlvbnMgc2hvdWxkIHNldCBlcnJubyB0byAwIGJlZm9yZSBjYWxsaW5nIGdl
dHB3bmFtKCkuIElmCmdldHB3bmFtKCkgcmV0dXJucyBhIG51bGwgcG9pbnRlciBhbmQgZXJybm8g
aXMgbm9uLXplcm8sIGFuIGVycm9yCm9jY3VycmVkLiIgb3VnaHQgdG8gYmUgYXBwbGllcyB0byBn
ZXRwd25hbV9yIHRvbz8KCj4gCj4gSSBzdXBwb3NlIHlvdSBhcmUgbG9va2luZyBhdCB0aGUgTGlu
dXggYW5kL29yIGdsaWJjIG1hbiBwYWdlcz8KPiAKPiA+IFdoaWxlIGl0J3Mgbm90IGNsZWFyIHdo
YXQgZWxsaXBzZXMgYXJlIG1lYW50IHRvIGJlLCB0aGUgd2F5IHdlCj4gPiBjdXJyZW50bHkKPiA+
IHRyZWF0IHJldHVybiB2YWx1ZXMgZnJvbSBnZXRwd25hbV9yKCkgaXMgbm8gc3VmZmljaWVudC4g
SW4gZmFjdCwgdHdvIG9mCj4gPiBteSBzeXN0ZW1zIGJlaGF2ZSBkaWZmZXJlbnRseSB3aGVuIHVz
ZXJuYW1lIGlzIG5vdCBmb3VuZDogb25lIHJldHVybnMKPiA+IEVOT0VOVCBhbmQgdGhlIG90aGVy
IHJldHVybnMgMC4KPiAKPiBXaGljaCB0d28gc3lzdGVtcyBhcmUgdGhlc2U/IFdoZW4geW91IHNh
eSAicmV0dXJucyIgZG8geW91IG1lYW4gInJldHVybnMKPiAwCj4gYW5kIHNldHMgZXJybm8gdG8g
WFhYIiBvciBsaXRlcmFsbHkgcmV0dXJucyBFTk9FTlQ/Cj4gCj4gPiDCoEJvdGggc2V0ICpyZXN1
bHQgdG8gTlVMTC4KPiA+IAo+ID4gVGhpcyBwYXRjaCBhZGp1c3RzIHJldHVybiB2YWx1ZSBtYW5h
Z2VtZW50IHRvIGJlIG1vcmUgaW4gbGluZSB3aXRoIG1hbgo+ID4gcGFnZXMuCj4gPiAKPiA+IFdo
aWxlIGF0IGl0LCBhbHNvIG1ha2Ugc3VyZSB3ZSBkb24ndCBnZXQgc3R1Y2sgb24gRVJBTkdFLgo+
ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBCb3JpcyBPc3Ryb3Zza3kgPGJvcmlzLm9zdHJvdnNreUBv
cmFjbGUuY29tPgo+ID4gLS0tCj4gPiDCoHRvb2xzL2xpYnhsL2xpYnhsX2RtLmMgfCAyMyArKysr
KysrKysrKysrKy0tLS0tLS0tLQo+ID4gwqAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygr
KSwgOSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhs
X2RtLmMgYi90b29scy9saWJ4bC9saWJ4bF9kbS5jCj4gPiBpbmRleCBhNDkzNGRmLi5iZDNkYWVi
IDEwMDY0NAo+ID4gLS0tIGEvdG9vbHMvbGlieGwvbGlieGxfZG0uYwo+ID4gKysrIGIvdG9vbHMv
bGlieGwvbGlieGxfZG0uYwo+ID4gQEAgLTcyNiw3ICs3MjYsNyBAQCBzdGF0aWMgaW50IGxpYnhs
X19kbV9ydW5hc19oZWxwZXIobGlieGxfX2djICpnYywKPiA+IGNvbnN0IGNoYXIgKnVzZXJuYW1l
KQo+ID4gwqDCoMKgwqDCoHN0cnVjdCBwYXNzd2QgcHdkLCAqdXNlciA9IE5VTEw7Cj4gPiDCoMKg
wqDCoMKgY2hhciAqYnVmID0gTlVMTDsKPiA+IMKgwqDCoMKgwqBsb25nIGJ1Zl9zaXplOwo+ID4g
LcKgwqDCoMKgaW50IHJldDsKPiA+ICvCoMKgwqDCoGludCByZXQsIHJldHJ5X2NudCA9IDA7Cj4g
PiDCoAo+ID4gwqDCoMKgwqDCoGJ1Zl9zaXplID0gc3lzY29uZihfU0NfR0VUUFdfUl9TSVpFX01B
WCk7Cj4gPiDCoMKgwqDCoMKgaWYgKGJ1Zl9zaXplIDwgMCkgewo+ID4gQEAgLTc0MCwxMiArNzQw
LDE3IEBAIHN0YXRpYyBpbnQgbGlieGxfX2RtX3J1bmFzX2hlbHBlcihsaWJ4bF9fZ2MgKmdjLAo+
ID4gY29uc3QgY2hhciAqdXNlcm5hbWUpCj4gPiDCoMKgwqDCoMKgwqDCoMKgwqByZXQgPSBnZXRw
d25hbV9yKHVzZXJuYW1lLCAmcHdkLCBidWYsIGJ1Zl9zaXplLCAmdXNlcik7Cj4gPiDCoMKgwqDC
oMKgwqDCoMKgwqBpZiAocmV0ID09IEVSQU5HRSkgewo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqBidWZfc2l6ZSArPSAxMjg7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgaWYgKHJl
dHJ5X2NudCsrID4gMTApCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoHJldHVybiBFUlJPUl9GQUlMOwo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBjb250
aW51ZTsKPiA+IMKgwqDCoMKgwqDCoMKgwqDCoH0KPiA+IC3CoMKgwqDCoMKgwqDCoMKgaWYgKHJl
dCAhPSAwKQo+ID4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiBFUlJPUl9GQUlMOwo+
ID4gLcKgwqDCoMKgwqDCoMKgwqBpZiAodXNlciAhPSBOVUxMKQo+ID4gLcKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoHJldHVybiAxOwo+ID4gK8KgwqDCoMKgwqDCoMKgwqBpZiAodXNlciA9PSBOVUxM
KSB7Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgaWYgKCFyZXQgfHwgKHJldCA9PSBFTk9F
TlQpIHx8IChyZXQgPT0gRVNSQ0gpIHx8Cj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqAocmV0ID09IEVCQURGKSB8fCAocmV0ID09IEVQRVJNKSkKPiA+ICvCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiBFUlJPUl9OT1RGT1VORDsKPiA+ICvCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqBlbHNlCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBy
ZXR1cm4gRVJST1JfRkFJTDsKPiA+ICvCoMKgwqDCoMKgwqDCoMKgfQo+ID4gwqDCoMKgwqDCoMKg
wqDCoMKgcmV0dXJuIDA7Cj4gPiDCoMKgwqDCoMKgfQo+ID4gwqB9Cj4gPiBAQCAtMTI2MSwxNiAr
MTI2NiwxNiBAQCBzdGF0aWMgaW50Cj4gPiBsaWJ4bF9fYnVpbGRfZGV2aWNlX21vZGVsX2FyZ3Nf
bmV3KGxpYnhsX19nYyAqZ2MsCj4gPiDCoAo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgdXNlciA9IEdD
U1BSSU5URigiJXMlZCIsIExJQlhMX1FFTVVfVVNFUl9CQVNFLCBndWVzdF9kb21pZCk7Cj4gPiDC
oMKgwqDCoMKgwqDCoMKgwqByZXQgPSBsaWJ4bF9fZG1fcnVuYXNfaGVscGVyKGdjLCB1c2VyKTsK
PiA+IC3CoMKgwqDCoMKgwqDCoMKgaWYgKHJldCA8IDApCj4gPiArwqDCoMKgwqDCoMKgwqDCoGlm
IChyZXQgJiYgKHJldCAhPSBFUlJPUl9OT1RGT1VORCkpCj4gPiDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoHJldHVybiByZXQ7Cj4gPiAtwqDCoMKgwqDCoMKgwqDCoGlmIChyZXQgPiAwKQo+ID4g
K8KgwqDCoMKgwqDCoMKgwqBpZiAoIXJldCkKPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
Z290byBlbmRfc2VhcmNoOwo+ID4gwqAKPiA+IMKgwqDCoMKgwqDCoMKgwqDCoHVzZXIgPSBMSUJY
TF9RRU1VX1VTRVJfU0hBUkVEOwo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgcmV0ID0gbGlieGxfX2Rt
X3J1bmFzX2hlbHBlcihnYywgdXNlcik7Cj4gPiAtwqDCoMKgwqDCoMKgwqDCoGlmIChyZXQgPCAw
KQo+ID4gK8KgwqDCoMKgwqDCoMKgwqBpZiAocmV0ICYmIChyZXQgIT0gRVJST1JfTk9URk9VTkQp
KQo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZXR1cm4gcmV0Owo+ID4gLcKgwqDCoMKg
wqDCoMKgwqBpZiAocmV0ID4gMCkgewo+ID4gK8KgwqDCoMKgwqDCoMKgwqBpZiAoIXJldCkgewo+
ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBMT0coV0FSTiwgIkNvdWxkIG5vdCBmaW5kIHVz
ZXIgJXMlZCwgZmFsbGluZyBiYWNrIHRvICVzIiwKPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoExJQlhMX1FFTVVfVVNFUl9CQVNFLCBndWVzdF9kb21pZCwKPiA+
IExJQlhMX1FFTVVfVVNFUl9TSEFSRUQpOwo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBn
b3RvIGVuZF9zZWFyY2g7Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX18KPiBYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Cj4gWGVuLWRldmVsQGxpc3RzLnhlbi5v
cmcKPiBodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwKX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2
ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK