From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
David Ahern <dsahern@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 11/13] perf stat: Clear sample_(type|period) for counting
Date: Thu, 26 Nov 2015 17:46:09 -0300 [thread overview]
Message-ID: <1448570771-5430-12-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1448570771-5430-1-git-send-email-acme@kernel.org>
From: Jiri Olsa <jolsa@kernel.org>
Clear sample_(type|period) for counting, as it only confuses debug
output with unwanted sampling details:
Before:
$ sudo perf stat -e 'raw_syscalls:sys_enter' -vv ls
------------------------------------------------------------
perf_event_attr:
type 2
size 112
config 0x11
{ sample_period, sample_freq } 1
sample_type TIME|CPU|PERIOD|RAW
read_format TOTAL_TIME_ENABLED|TOTAL_TIME_RUNNING
disabled 1
inherit 1
enable_on_exec 1
exclude_guest 1
...
After:
$ sudo perf stat -e 'raw_syscalls:sys_enter' -vv ls
------------------------------------------------------------
perf_event_attr:
type 2
size 112
config 0x11
read_format TOTAL_TIME_ENABLED|TOTAL_TIME_RUNNING
disabled 1
inherit 1
enable_on_exec 1
exclude_guest 1
...
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1448465815-27404-1-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-stat.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index e77880b5094d..df2fbf046ee2 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -161,6 +161,13 @@ static int create_perf_stat_counter(struct perf_evsel *evsel)
attr->inherit = !no_inherit;
+ /*
+ * Some events get initialized with sample_(period/type) set,
+ * like tracepoints. Clear it up for counting.
+ */
+ attr->sample_period = 0;
+ attr->sample_type = 0;
+
if (target__has_cpu(&target))
return perf_evsel__open_per_cpu(evsel, perf_evsel__cpus(evsel));
--
2.1.0
next prev parent reply other threads:[~2015-11-26 20:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 20:45 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-11-26 20:45 ` [PATCH 01/13] perf callchain: Honor hide_unresolved Arnaldo Carvalho de Melo
2015-11-26 20:46 ` [PATCH 02/13] perf top: Fix freeze on --call-graph flat/folded Arnaldo Carvalho de Melo
2015-11-26 20:46 ` [PATCH 03/13] perf script: Remove default_scripting_ops Arnaldo Carvalho de Melo
2015-11-26 20:46 ` [PATCH 04/13] perf build: Fix traceevent plugins build race Arnaldo Carvalho de Melo
2015-11-26 20:46 ` [PATCH 05/13] perf machine: Adjust dso->long_name for offline module Arnaldo Carvalho de Melo
2015-11-26 20:46 ` [PATCH 06/13] perf tools: Correctly identify anon_hugepage when generating map (v2) Arnaldo Carvalho de Melo
2015-11-26 20:46 ` [PATCH 07/13] perf script: Pass perf_script into process_event Arnaldo Carvalho de Melo
2015-11-26 20:46 ` [PATCH 08/13] tools build: Use fixdep with OUTPUT path prefix Arnaldo Carvalho de Melo
2015-11-26 20:46 ` [PATCH 09/13] perf symbols: Refactor vmlinux_path__init() to ease path additions Arnaldo Carvalho de Melo
2015-11-26 20:46 ` [PATCH 10/13] perf symbols: Add the path to vmlinux.debug Arnaldo Carvalho de Melo
2015-11-26 20:46 ` Arnaldo Carvalho de Melo [this message]
2015-11-26 20:46 ` [PATCH 12/13] perf evlist: Display WEIGHT sample type bit Arnaldo Carvalho de Melo
2015-11-26 20:46 ` [PATCH 13/13] bpf tools: Add helper function for updating bpf maps elements Arnaldo Carvalho de Melo
2015-11-27 7:30 ` [GIT PULL 00/13] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448570771-5430-12-git-send-email-acme@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.