From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] libxl: Be more careful with error handling
 in libxl__dm_runas_helper()
Date: Fri, 27 Nov 2015 09:40:31 +0000
Message-ID: <1448617231.13576.56.camel@citrix.com>
References: <1448488569-3003-1-git-send-email-boris.ostrovsky@oracle.com>
	<22103.17713.650054.585156@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <22103.17713.650054.585156@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: xen-devel@lists.xen.org, wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

T24gVGh1LCAyMDE1LTExLTI2IGF0IDE3OjQ1ICswMDAwLCBJYW4gSmFja3NvbiB3cm90ZToKPiBC
b3JpcyBPc3Ryb3Zza3kgd3JpdGVzICgiW1BBVENIXSBsaWJ4bDogQmUgbW9yZSBjYXJlZnVsIHdp
dGggZXJyb3IKPiBoYW5kbGluZyBpbiBsaWJ4bF9fZG1fcnVuYXNfaGVscGVyKCkiKToKPiA+IGdl
dHB3bmFtX3IoKSBoYXMgZmFpcmx5IGNvbXBsaWNhdGVkIHJldHVybiBydWxlcy4gRnJvbSBtYW4g
cGFnZXM6Cj4gPiAKPiA+IMKgIFJFVFVSTiBWQUxVRQo+ID4gwqDCoMKgwqDCoMKgLi4uCj4gPiDC
oMKgwqDCoMKgwqBPbiBzdWNjZXNzLCBnZXRwd25hbV9yKCkgYW5kIGdldHB3dWlkX3IoKSByZXR1
cm4gemVybywgYW5kIHNldAo+ID4gwqDCoMKgwqDCoMKgKnJlc3VsdCB0byBwd2QuwqDCoElmIG5v
IG1hdGNoaW5nwqDCoHBhc3N3b3JkIHJlY29yZCB3YXMgZm91bmQsIHRoZXNlCj4gPiDCoMKgwqDC
oMKgwqBmdW5jdGlvbnMgcmV0dXJuIDAgYW5kIHN0b3JlIE5VTEwgaW4gKnJlc3VsdC4gSW4gY2Fz
ZSBvZiBlcnJvciwKPiA+IMKgwqDCoMKgwqDCoGFuIGVycm9yIG51bWJlciBpcyByZXR1cm5lZCwg
YW5kIE5VTEwgaXMgc3RvcmVkIGluICpyZXN1bHQuCj4gCj4gSSBjYW4ndCBzZWUgYW55dGhpbmcg
aW4gdGhlIFN1UyBkb2NzICh3aGljaCBJYW4gQyByZWZlcnJlZCB0bykgc2F5aW5nCj4gdGhhdCAq
cmVzdWx0IGlzIHVwZGF0ZWQgZXZlbiBvbiBlcnJvci7CoMKgU28gSSB0aGluayB5b3UgbmVlZCB0
byBjaGVjawo+IHRoZSByZXR1cm4gdmFsdWUgZmlyc3QsIGFuZCBvbmx5IHRoZW4gKnJlc3VsdC4K
CkFjdHVhbGx5LCB0aGUgZm91cnRoIHBhcmEgb2YgZGVzY3JpcHRpb24gaW4gWzBdIChzdGFydGlu
ZyAiVGhlIGdldHB3bmFtX3IoKQpmdW5jdGlvbiBzaGFsbC4uLiIpIGVuZHM6CgogICAgQSBudWxs
IHBvaW50ZXIgc2hhbGwgYmUgcmV0dXJuZWQgYXQgdGhlIGxvY2F0aW9uIHBvaW50ZWQgdG8gYnkg
cmVzdWx0IG9uCiAgICBlcnJvciBvciBpZiB0aGUgcmVxdWVzdGVkIGVudHJ5IGlzIG5vdCBmb3Vu
ZC4KCkkgYWxzbyBqdXN0IHJlYWxpc2VkIChsb25nIGFmdGVyIGV2ZXJ5b25lIGVsc2UsIGFwcGFy
ZW50bHkpIHRoYXQgdGhpcwpmdW5jdGlvbiByZXR1cm5zICgrdmUpIEV4eHggdmFsdWVzLCBub3Qg
LTEgYW5kIHNldHRpbmcgZXJybm8uCgpUb2dldGhlciB3aXRoIGNvbWJpbmluZyBnZXRwd25hbSBh
bmQgZ2V0cHduYW1fciBpbiB0aGUgc2FtZSBkb2MgaXQncyBhbG1vc3QKbGlrZSBzb21lb25lIHdh
cyB3aWxmdWxseSB0cnlpbmcgdG8gbWFrZSB0aGlzIGZ1bmN0aW9uIGRpZmZpY3VsdCB0byBmaWd1
cmUKb3V0Li4uCgo+IAo+ID4gwqAgRVJST1JTCj4gPiDCoMKgwqDCoMKgwqAwIG9yIEVOT0VOVCBv
ciBFU1JDSCBvciBFQkFERiBvciBFUEVSTSBvciAuLi4KPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoFRoZSBnaXZlbiBuYW1lIG9yIHVpZCB3YXMgbm90IGZvdW5kLgo+ID4gCj4gPiBXaGlsZSBp
dCdzIG5vdCBjbGVhciB3aGF0IGVsbGlwc2VzIGFyZSBtZWFudCB0byBiZSwgdGhlIHdheSB3ZQo+
ID4gY3VycmVudGx5Cj4gPiB0cmVhdCByZXR1cm4gdmFsdWVzIGZyb20gZ2V0cHduYW1fcigpIGlz
IG5vIHN1ZmZpY2llbnQuIEluIGZhY3QsIHR3byBvZgo+ID4gbXkgc3lzdGVtcyBiZWhhdmUgZGlm
ZmVyZW50bHkgd2hlbiB1c2VybmFtZSBpcyBub3QgZm91bmQ6IG9uZSByZXR1cm5zCj4gPiBFTk9F
TlQgYW5kIHRoZSBvdGhlciByZXR1cm5zIDAuIEJvdGggc2V0ICpyZXN1bHQgdG8gTlVMTC4KPiAK
PiBJIGRvbid0IGtub3cgd2hlcmUgYWxsIHRoYXQgc3R1ZmYgYWJvdXQgRU5PRU5UIGNvbWVzIGZy
b20uwqDCoEknbQo+IHRlbXB0ZWQgdG8gc2F5IHRoaXMgaXMgYSBidWcgaW4geW91ciBDIGxpYnJh
cnkuwqDCoEJ1dCBJIGRvbid0IG1pbmQKPiB0cmVhdGluZyBFTk9FTlQgb3IgRVNSQ0ggYXMgRVJS
T1JfTk9URk9VTkQuCj4gCj4gSSBkbyBtaW5kIHRyZWF0aW5nIEVCQURGIG9yIEVQRVJNIHRoYXQg
d2F5LgoKRldJVyB0aGUgTGludXggbWFucGFnZSB3aGljaCBCb3JpcyBoYXMgcmVmZXJyZWQgdG8g
c2F5cyB1bmRlciBOT1RFUzoKCiAgICBFeHBlcmltZW50cyBvbiB2YXJpb3VzIFVOSVgtbGlrZSBz
eXN0ZW1zIHNob3cgdGhhdCBsb3RzwqDCoG9mIMKgIMKgIMKgCiAgICBkaWZmZXJlbnQgdmFsdWVz
IG9jY3VyIGluIHRoaXMgc2l0dWF0aW9uOiAwLCBFTk9FTlQsIEVCQURGLCBFU1JDSCwKICAgIEVX
T1VMREJMT0NLLCBFUEVSTSwgYW5kIHByb2JhYmx5IG90aGVycwoKInZhcmlvdXMiIHByb2JhYmx5
IGluY2x1ZGVzIGFsbCBzb3J0cyBvZiByYW5kb20gVU5JWC1saWtlIHN5c3RlbXMgb3V0c2lkZQp0
aGUgc21hbGwgc2V0IHdoaWNoIGFyZSBhY3R1YWxseSB1c2VkIHdpdGggWGVuLiBJJ2QgYmUgaW5j
bGluZWQgdG8gYWdyZWUKd2l0aCBub3QgaW5jbHVkaW5nIEVCQURGLCBFUEVSTSBpbiB0aGlzIHdh
eSBhdCBsZWFzdCB1bnRpbCBhbiBhY3R1YWwKcGxhdGZvcm0gcnVubmluZyBYZW4gaXMgZm91bmQg
d2hpY2ggcmV0dXJucyBzdWNoIGVycm9ycyAobm90IHN1Z2dlc3RpbmcKYW55b25lIHByb2FjdGl2
ZWx5IGNoZWNraW5nLCBidXQganVzdCB0aGF0IHdlIHNob3VsZCBiZSBwcmVwYXJlZCB0byBhY2Nl
cHQKdGhlIHBvc3NpYmlsaXR5IHdoZW4gc29tZW9uZSBub3RpY2VzIGFuZCByZXBvcnRzIGl0KS4K
Cklhbi4KClswXcKgaHR0cDovL3B1YnMub3Blbmdyb3VwLm9yZy9vbmxpbmVwdWJzLzk2OTk5MTk3
OTkvZnVuY3Rpb25zL2dldHB3bmFtLmh0bWwKCj4gCj4gPiBXaGlsZSBhdCBpdCwgYWxzbyBtYWtl
IHN1cmUgd2UgZG9uJ3QgZ2V0IHN0dWNrIG9uIEVSQU5HRS4KPiAKPiBJZiB5b3UgYXJlIGdvaW5n
IHRvIGRvIGFueXRoaW5nIHRvIHRoaXMsIHlvdSBzaG91bGQgdXNlIGFuCj4gZXhwb25lbnRpYWxs
eSBpbmNyZWFzaW5nIGJ1ZmZlciBzaXplLsKgwqBCZWFyIGluIG1pbmQgdGhhdCBnZXRwd25hbV9y
IGlzCj4gYWxyZWFkeSBpbnNpZGUgdGhlIHRydXN0IGJvdW5kYXJ5Lgo+IAo+IFRoYW5rcywKPiBJ
YW4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4t
ZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54
ZW4ub3JnL3hlbi1kZXZlbAo=