All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] wireless: airo: re-use mac_pton()
Date: Fri, 27 Nov 2015 11:53:07 +0200	[thread overview]
Message-ID: <1448617987.15393.102.camel@linux.intel.com> (raw)
In-Reply-To: <87poywnawt.fsf@kamboji.qca.qualcomm.com>

On Thu, 2015-11-26 at 15:32 +0200, Kalle Valo wrote:
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> 
> > mac_pton() converts 6-byte MAC / BSSID to binary format. Change an
> > open coded
> > variant by the generic one.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> This breaks compilation:
> 
>   CC [M]  drivers/net/wireless/cisco/airo.o
> drivers/net/wireless/cisco/airo.c: In function
> ‘proc_APList_on_close’:
> drivers/net/wireless/cisco/airo.c:5141:49: error: request for member
> ‘ap’ in something not a structure or union

Sorry for that, seems rebase issue since it was an old fix in my local
tree.

Seems it should be
  mac_pton(data->wbuffer + i * 6 * 3, APList_rid->ap[i]);

I will send updated version later.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy


      reply	other threads:[~2015-11-27  9:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 14:16 [PATCH 1/1] wireless: airo: re-use mac_pton() Andy Shevchenko
2015-11-26 13:32 ` Kalle Valo
2015-11-27  9:53   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448617987.15393.102.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.