From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: From: "Winkler, Tomas" To: "linux@roeck-us.net" , "gregkh@linuxfoundation.org" , "wim@iguana.be" CC: "linux-kernel@vger.kernel.org" , "Usyskin, Alexander" , "linux-watchdog@vger.kernel.org" Subject: Re: [char-misc-next 6/6] mei: wd: re-register device on event Date: Tue, 1 Dec 2015 11:59:38 +0000 Message-ID: <1448971132.30677.20.camel@intel.com> References: <1448541081-11299-1-git-send-email-tomas.winkler@intel.com> <1448541081-11299-7-git-send-email-tomas.winkler@intel.com> <565C8281.9070909@roeck-us.net> In-Reply-To: <565C8281.9070909@roeck-us.net> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <08226932A9824D4B97AD01152F456F83@intel.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 List-ID: T24gTW9uLCAyMDE1LTExLTMwIGF0IDA5OjA4IC0wODAwLCBHdWVudGVyIFJvZWNrIHdyb3RlOg0K PiBPbiAxMS8yNi8yMDE1IDA0OjMxIEFNLCBUb21hcyBXaW5rbGVyIHdyb3RlOg0KPiA+IEZyb206 IEFsZXhhbmRlciBVc3lza2luIDxhbGV4YW5kZXIudXN5c2tpbkBpbnRlbC5jb20+DQo+ID4gDQo+ ID4gRm9yIEludGVsIFNLTCBwbGF0Zm9ybSB0aGUgTUUgZGV2aWNlIGNhbiBpbmZvcm0gdGhlIGhv c3QgdmlhDQo+ID4gYXN5bmNocm9ub3VzIG5vdGlmaWNhdGlvbiB0aGF0IHRoZSB3YXRjaGRvZyBm ZWF0dXJlIHdhcyBhY3RpdmF0ZWQNCj4gPiBvbiB0aGUNCj4gPiBkZXZpY2UuIFRoZSBhY3RpdmF0 aW9uIGRvZXNuJ3QgcmVxdWlyZSByZWJvb3QuDQo+ID4gSW4gdGhhdCBjYXNlIHRoZSBkcml2ZXIg cmVnaXN0ZXIgdGhlIHdhdGNoZG9nIGRldmljZSB3aXRoIHRoZQ0KPiA+IGtlcm5lbC4NCj4gPiAN Cj4gDQo+IENhbiB0aGUgd2F0Y2hkb2cgZGV2aWNlIGFsc28gYmUgZGlzYWJsZWQgb24gdGhlIGZs eSA/DQpZZXMsIGl0IGNhbiBiZSBkaXNhYmxlZCBhbHNvIG9uIHRoZSBmbHksIGJ1dCB0aGlzIGlz IG5vdCBkZWxpdmVyZWQgdmlhDQphbiBldmVudCwgdGhpcyBpcyBoYW5kbGVkIHZpYSBwaW5nIHJl dHVybiB2YWx1ZS4gDQoNCj4gDQo+ID4gU2lnbmVkLW9mZi1ieTogQWxleGFuZGVyIFVzeXNraW4g PGFsZXhhbmRlci51c3lza2luQGludGVsLmNvbT4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBUb21hcyBX aW5rbGVyIDx0b21hcy53aW5rbGVyQGludGVsLmNvbT4NCj4gPiAtLS0NCj4gPiAgIGRyaXZlcnMv d2F0Y2hkb2cvbWVpX3dkdC5jIHwgMjYgKysrKysrKysrKysrKysrKysrKysrKysrLS0NCj4gPiAg IDEgZmlsZSBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPiA+IA0K PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3dhdGNoZG9nL21laV93ZHQuYw0KPiA+IGIvZHJpdmVy cy93YXRjaGRvZy9tZWlfd2R0LmMNCj4gPiBpbmRleCA0N2YwZGMyZTgyMmEuLmVlM2I1ZDEyYjFi MiAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL3dhdGNoZG9nL21laV93ZHQuYw0KPiA+ICsrKyBi L2RyaXZlcnMvd2F0Y2hkb2cvbWVpX3dkdC5jDQo+ID4gQEAgLTI3OSw2ICsyNzksMjEgQEAgb3V0 Og0KPiA+ICAgCQljb21wbGV0ZSgmd2R0LT5yZXNwb25zZSk7DQo+ID4gICB9DQo+ID4gDQo+ID4g Ky8qDQo+ID4gKyAqIG1laV93ZHRfZXZlbnRfbm90aWYgLSBjYWxsYmFjayBmb3Igbm90aWZpY2F0 aW9uDQo+ID4gKyAqDQo+ID4gKyAqIEBjbGRldjogYnVzIGRldmljZQ0KPiA+ICsgKi8NCj4gPiAr c3RhdGljIHZvaWQgbWVpX3dkdF9ldmVudF9ub3RpZihzdHJ1Y3QgbWVpX2NsX2RldmljZSAqY2xk ZXYpDQo+ID4gK3sNCj4gPiArCXN0cnVjdCBtZWlfd2R0ICp3ZHQgPSBtZWlfY2xkZXZfZ2V0X2Ry dmRhdGEoY2xkZXYpOw0KPiA+ICsNCj4gPiArCWlmICh3ZHQtPnN0YXRlID09IE1FSV9XRFRfTk9U X1JFUVVJUkVEKSB7DQo+ID4gKwkJbWVpX3dkdF9yZWdpc3Rlcih3ZHQpOw0KPiA+ICsJCXdkdC0+ c3RhdGUgPSBNRUlfV0RUX0lETEU7DQo+ID4gKwl9DQo+ID4gK30NCj4gPiArDQo+ID4gICAvKioN Cj4gPiAgICAqIG1laV93ZHRfZXZlbnQgLSBjYWxsYmFjayBmb3IgZXZlbnQgcmVjZWl2ZQ0KPiA+ ICAgICoNCj4gPiBAQCAtMjkxLDYgKzMwNiw5IEBAIHN0YXRpYyB2b2lkIG1laV93ZHRfZXZlbnQo c3RydWN0IG1laV9jbF9kZXZpY2UNCj4gPiAqY2xkZXYsDQo+ID4gICB7DQo+ID4gICAJaWYgKGV2 ZW50cyAmIEJJVChNRUlfQ0xfRVZFTlRfUlgpKQ0KPiA+ICAgCQltZWlfd2R0X2V2ZW50X3J4KGNs ZGV2KTsNCj4gPiArDQo+ID4gKwlpZiAoZXZlbnRzICYgQklUKE1FSV9DTF9FVkVOVF9OT1RJRikp DQo+ID4gKwkJbWVpX3dkdF9ldmVudF9ub3RpZihjbGRldik7DQo+ID4gICB9DQo+ID4gDQo+ID4g ICAvKioNCj4gPiBAQCAtNDY2LDkgKzQ4NCwxMyBAQCBzdGF0aWMgaW50IG1laV93ZHRfcHJvYmUo c3RydWN0IG1laV9jbF9kZXZpY2UNCj4gPiAqY2xkZXYsDQo+ID4gDQo+ID4gICAJd2RfaW5mby5m aXJtd2FyZV92ZXJzaW9uID0gbWVpX2NsZGV2X3ZlcihjbGRldik7DQo+ID4gDQo+ID4gLQlyZXQg PSBtZWlfY2xkZXZfcmVnaXN0ZXJfZXZlbnRfY2Iod2R0LT5jbGRldiwNCj4gPiBCSVQoTUVJX0NM X0VWRU5UX1JYKSwNCj4gPiArCXJldCA9IG1laV9jbGRldl9yZWdpc3Rlcl9ldmVudF9jYih3ZHQt PmNsZGV2LA0KPiA+ICsJCQkJCSAgQklUKE1FSV9DTF9FVkVOVF9SWCkgfA0KPiA+ICsJCQkJCSAg QklUKE1FSV9DTF9FVkVOVF9OT1RJRiksDQo+ID4gICAJCQkJCSAgbWVpX3dkdF9ldmVudCwgTlVM TCk7DQo+ID4gLQlpZiAocmV0KSB7DQo+ID4gKw0KPiA+ICsJLyogb24gbGVnYWN5IGRldmljZXMg bm90aWZpY2F0aW9uIGlzIG5vdCBzdXBwb3J0ZWQgKi8NCj4gPiArCWlmIChyZXQgJiYgcmV0ICE9 IC1FT1BOT1RTVVBQKSB7DQo+ID4gICAJCWRldl9lcnIoJmNsZGV2LT5kZXYsICJDb3VsZCBub3Qg cmVnaXN0ZXIgZXZlbnQNCj4gPiByZXQ9JWRcbiIsIHJldCk7DQo+ID4gICAJCWdvdG8gZXJyX2Rp c2FibGU7DQo+ID4gICAJfQ0KPiA+IA0KPiBEb2Vzbid0IHRoYXQgbWVhbiwgdGhvdWdoLCB0aGF0 IHRoZSBSWCBldmVudCBpcyBub3QgcmVnaXN0ZXJlZA0KPiBlaXRoZXIsDQo+IGV2ZW4gaWYgaXQg aXMgc3VwcG9ydGVkID8gSWYgc28sIHNob3VsZCB5b3UgcmV0cnkgYW5kIHJlZ2lzdGVyIG9ubHkN Cj4gTUVJX0NMX0VWRU5UX1JYID8NCg0KVGhlIGNvZGUgaXMgY29ycmVjdCBidXQgd2UgZGVmaW5p dGVseSBuZWVkIHRvIHRoaW5rIG9mIGJldHRlciBBUEkgDQpUb21hcw0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756156AbbLAMAE (ORCPT ); Tue, 1 Dec 2015 07:00:04 -0500 Received: from mga11.intel.com ([192.55.52.93]:59898 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756109AbbLAMAB (ORCPT ); Tue, 1 Dec 2015 07:00:01 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,368,1444719600"; d="scan'208";a="697824243" From: "Winkler, Tomas" To: "linux@roeck-us.net" , "gregkh@linuxfoundation.org" , "wim@iguana.be" CC: "linux-kernel@vger.kernel.org" , "Usyskin, Alexander" , "linux-watchdog@vger.kernel.org" Subject: Re: [char-misc-next 6/6] mei: wd: re-register device on event Thread-Topic: [char-misc-next 6/6] mei: wd: re-register device on event Thread-Index: AQHRK5Ix19o7xiyWKUOb5yshRb8qWp615p8A Date: Tue, 1 Dec 2015 11:59:38 +0000 Message-ID: <1448971132.30677.20.camel@intel.com> References: <1448541081-11299-1-git-send-email-tomas.winkler@intel.com> <1448541081-11299-7-git-send-email-tomas.winkler@intel.com> <565C8281.9070909@roeck-us.net> In-Reply-To: <565C8281.9070909@roeck-us.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.87.84] Content-Type: text/plain; charset="utf-8" Content-ID: <08226932A9824D4B97AD01152F456F83@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tB1C0BdI027330 On Mon, 2015-11-30 at 09:08 -0800, Guenter Roeck wrote: > On 11/26/2015 04:31 AM, Tomas Winkler wrote: > > From: Alexander Usyskin > > > > For Intel SKL platform the ME device can inform the host via > > asynchronous notification that the watchdog feature was activated > > on the > > device. The activation doesn't require reboot. > > In that case the driver register the watchdog device with the > > kernel. > > > > Can the watchdog device also be disabled on the fly ? Yes, it can be disabled also on the fly, but this is not delivered via an event, this is handled via ping return value. > > > Signed-off-by: Alexander Usyskin > > Signed-off-by: Tomas Winkler > > --- > > drivers/watchdog/mei_wdt.c | 26 ++++++++++++++++++++++++-- > > 1 file changed, 24 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/watchdog/mei_wdt.c > > b/drivers/watchdog/mei_wdt.c > > index 47f0dc2e822a..ee3b5d12b1b2 100644 > > --- a/drivers/watchdog/mei_wdt.c > > +++ b/drivers/watchdog/mei_wdt.c > > @@ -279,6 +279,21 @@ out: > > complete(&wdt->response); > > } > > > > +/* > > + * mei_wdt_event_notif - callback for notification > > + * > > + * @cldev: bus device > > + */ > > +static void mei_wdt_event_notif(struct mei_cl_device *cldev) > > +{ > > + struct mei_wdt *wdt = mei_cldev_get_drvdata(cldev); > > + > > + if (wdt->state == MEI_WDT_NOT_REQUIRED) { > > + mei_wdt_register(wdt); > > + wdt->state = MEI_WDT_IDLE; > > + } > > +} > > + > > /** > > * mei_wdt_event - callback for event receive > > * > > @@ -291,6 +306,9 @@ static void mei_wdt_event(struct mei_cl_device > > *cldev, > > { > > if (events & BIT(MEI_CL_EVENT_RX)) > > mei_wdt_event_rx(cldev); > > + > > + if (events & BIT(MEI_CL_EVENT_NOTIF)) > > + mei_wdt_event_notif(cldev); > > } > > > > /** > > @@ -466,9 +484,13 @@ static int mei_wdt_probe(struct mei_cl_device > > *cldev, > > > > wd_info.firmware_version = mei_cldev_ver(cldev); > > > > - ret = mei_cldev_register_event_cb(wdt->cldev, > > BIT(MEI_CL_EVENT_RX), > > + ret = mei_cldev_register_event_cb(wdt->cldev, > > + BIT(MEI_CL_EVENT_RX) | > > + BIT(MEI_CL_EVENT_NOTIF), > > mei_wdt_event, NULL); > > - if (ret) { > > + > > + /* on legacy devices notification is not supported */ > > + if (ret && ret != -EOPNOTSUPP) { > > dev_err(&cldev->dev, "Could not register event > > ret=%d\n", ret); > > goto err_disable; > > } > > > Doesn't that mean, though, that the RX event is not registered > either, > even if it is supported ? If so, should you retry and register only > MEI_CL_EVENT_RX ? The code is correct but we definitely need to think of better API Tomas {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I