From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751691AbbLAPXB (ORCPT ); Tue, 1 Dec 2015 10:23:01 -0500 Received: from mout.gmx.net ([212.227.17.21]:55779 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795AbbLAPW7 (ORCPT ); Tue, 1 Dec 2015 10:22:59 -0500 Message-ID: <1448983357.3225.148.camel@gmx.de> Subject: cpuset: return -EINVAL for legacy non-subset child creation attempt From: Mike Galbraith To: Li Zefan Cc: lkml Date: Tue, 01 Dec 2015 16:22:37 +0100 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:XNgny7J5V3CZp8wKl9Ayfvm9lDyV/2xvZXrzRvIcTyz4J4kLKqJ RePxommMjxr6jUvsSmIgdPUdYwOXlQMCoZGDB5r6MP9N9cR1wGd0Zra0n98RNFXDAS76C9t ErFH00hed+JsEX75Fo+955KO4FUduPABMrLs25Cz6NugbSh1vuBKJChfA+VKi0Q8Sx7U0qr gjnVyvboCWWv/HjZ0Sxlg== X-UI-Out-Filterresults: notjunk:1;V01:K0:63Hhgr5Bufs=:8h8fwhgGC9AQNoIKz3cD2Z Zaz0rtBj5f3ccYRQXyx6aCuAc6L476o3vt+MRUM+A0NnbmPvaL+LjsFthybJsztT7Gbysacdi 2ywz/xeFN0a66VwW5MKOcIaf5jgXayuHKTSrU8cYljABHVFPW7SvpdiDjAU7yQy1mLp9e0iN1 gZiyax7ZcoOjQOyMYvuWPATjHrngaZRYj1g4LkgUU4WreiNtwOvo2hY4cCknJp5rHoZ6/HiOM 7FTR3/Zyh6sVMKU8QTPbSVN/NrY/SiLji/at/s22ePacZlNgW/x0llydPMupUgMtH/hmj++mI hdLorATWoIja85+zRtsLjUEru6eMOl9r7izjdXQXlAU0e/nwG5LPgH8yaCY2sW+vYs7P7E6yc M+kRzfgUEMV31MHFqTJno1kiIdsTvu8iu/PwMxqbSLSPeBx269IKvnRAdIZwBpGauCcxqVwPd lOP18pYd3McTJWEw/I1UDOPxXT7ghTRdV8bE6a6vkRpAM+DN6WaR4lOlIDoJZAUzHiyPdntc7 AKzznOeRqbnl6zPwd3XFEEHY0+z7fDnW7BUg3rD9rT+jXsOFYzswwICSpZrbsu2yAPrpGhM+o JckLEsVXRviPLpwKmeBkmbQYf5OCYuCwUmwiX0fwu7tt91+n6h+MPUKRi9LJMMY8zRjypa9Fe AFF3fjBEk99fKoZe6cRClEQY/5M8yHgKAIPDQfm8+pVPM3xeuWm4hmuIl+ud9ir2IHcPPBfzO vDaiEDIvzm3PiH7GZ+50AWsVhVDCsr6g1WW3BcofIxWiFN6/MTZUUzggDYO9ccVAT8f8p87l9 bKOyqZH Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A legacy hierarchy child set that is not a subset of its parent is not a permissions issue, it's an invalid configuration. Return -EINVAL. Signed-off-by: Mike Galbraith --- kernel/cpuset.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/kernel/cpuset.c +++ b/kernel/cpuset.c @@ -472,7 +472,7 @@ static int validate_change(struct cpuset par = parent_cs(cur); /* On legacy hiearchy, we must be a subset of our parent cpuset. */ - ret = -EACCES; + ret = -EINVAL; if (!cgroup_subsys_on_dfl(cpuset_cgrp_subsys) && !is_cpuset_subset(trial, par)) goto out; @@ -481,7 +481,6 @@ static int validate_change(struct cpuset * If either I or some sibling (!= me) is exclusive, we can't * overlap */ - ret = -EINVAL; cpuset_for_each_child(c, css, par) { if ((is_cpu_exclusive(trial) || is_cpu_exclusive(c)) && c != cur &&