From: Chin Liang See <clsee@altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] mmc: dwmmc: socfpga: Convert to DM
Date: Wed, 2 Dec 2015 13:42:52 +0800 [thread overview]
Message-ID: <1449034972.2029.1.camel@altera.com> (raw)
In-Reply-To: <201512011942.43555.marex@denx.de>
On Tue, 2015-12-01 at 19:42 +0100, Marek Vasut wrote:
> On Tuesday, December 01, 2015 at 06:24:51 AM, Chin Liang See wrote:
> > Hi Marek,
> >
> > On Mon, 2015-11-30 at 20:48 +0100, Marek Vasut wrote:
> > > Convert the SoCFPGA shim for registering the DWMMC driver to DM.
> > >
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Chin Liang See <clsee@altera.com>
> > > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > > Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
> > > Cc: Simon Glass <sjg@chromium.org>
> > > Cc: Tom Rini <trini@konsulko.com>
> > > ---
> > >
> > > drivers/mmc/socfpga_dw_mmc.c | 119 ++++++++++++++++++++---------
> > > ----
> >
> > I cannot applied this successfully to u-boot-socfpga.git. I tried
> > git
> > am and also patch -1.
> >
> > > ----------
> > >
> > > 1 file changed, 56 insertions(+), 63 deletions(-)
> > >
> > > diff --git a/drivers/mmc/socfpga_dw_mmc.c
> > > b/drivers/mmc/socfpga_dw_mmc.c
> > > index 8076761..dd2b30a 100644
> > > --- a/drivers/mmc/socfpga_dw_mmc.c
> > > +++ b/drivers/mmc/socfpga_dw_mmc.c
> > > @@ -5,20 +5,28 @@
> > >
> > > */
> > >
> > > #include <common.h>
> > >
> > > -#include <malloc.h>
> > > -#include <fdtdec.h>
> > > -#include <libfdt.h>
> > > -#include <dwmmc.h>
> > > -#include <errno.h>
> > > -#include <asm/arch/dwmmc.h>
> > >
> > > #include <asm/arch/clock_manager.h>
> > >
> > > +#include <asm/arch/dwmmc.h>
> > >
> > > #include <asm/arch/system_manager.h>
> > >
> > > +#include <dm.h>
> > > +#include <dwmmc.h>
> > > +#include <errno.h>
> > > +#include <fdtdec.h>
> > > +#include <libfdt.h>
> > > +#include <linux/err.h>
> > > +#include <malloc.h>
> > > +
> > > +DECLARE_GLOBAL_DATA_PTR;
> > >
> > > static const struct socfpga_clock_manager *clock_manager_base =
> > >
> > > (void *)SOCFPGA_CLKMGR_ADDRESS;
> > >
> > > static const struct socfpga_system_manager *system_manager_base
> > > =
> > >
> > > (void *)SOCFPGA_SYSMGR_ADDRESS;
> > >
> > > +struct socfpga_dwmmc_priv {
> > > + struct dwmci_host host;
> > > +};
> > > +
> >
> > There is a new structure added when we add the dts support for
> > drvsel
> > and smplsel. It's not reflected here.
>
> I see now. Fixed and applied all three. This leaves USB the only
> dangling
> thing which is not probed from OF. That's next on my list.
Cool, thanks
Chin Liang
next prev parent reply other threads:[~2015-12-02 5:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 19:48 [U-Boot] [PATCH 1/3] arm: socfpga: Remove cpu_mmc_init() Marek Vasut
2015-11-30 19:48 ` [U-Boot] [PATCH 2/3] mmc: dwmmc: socfpga: Convert to DM Marek Vasut
2015-12-01 5:24 ` Chin Liang See
2015-12-01 13:18 ` Marek Vasut
2015-12-01 18:42 ` Marek Vasut
2015-12-02 5:42 ` Chin Liang See [this message]
2015-12-01 5:36 ` Simon Glass
2015-11-30 19:48 ` [U-Boot] [PATCH 3/3] arm: socfpga: Enable CONFIG_DM_MMC Marek Vasut
2015-12-01 5:25 ` Chin Liang See
2015-12-01 13:22 ` Marek Vasut
2015-12-01 5:21 ` [U-Boot] [PATCH 1/3] arm: socfpga: Remove cpu_mmc_init() Chin Liang See
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449034972.2029.1.camel@altera.com \
--to=clsee@altera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.