All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	linux-kernel@vger.kernel.org,
	Luiz Capitulino <lcapitulino@redhat.com>,
	Chao Peng <chao.p.peng@linux.intel.com>,
	Vikas Shivappa <vikas.shivappa@intel.com>
Subject: Re: [PATCH] cgroups: move cpuset specific checks from generic code to cpuset_can_attach (v2)
Date: Wed, 02 Dec 2015 07:21:28 +0100	[thread overview]
Message-ID: <1449037288.656.23.camel@gmail.com> (raw)
In-Reply-To: <20151201164916.GE12922@mtj.duckdns.org>

On Tue, 2015-12-01 at 11:49 -0500, Tejun Heo wrote:
> On Thu, Nov 26, 2015 at 08:32:32PM -0200, Marcelo Tosatti wrote:
> > 
> > Move PF_NO_SETAFFINITY and kthreadd_task checks to cpuset cgroups,  
> > where they belong. This makes it possible to attach PF_NO_SETAFFINITY 
> > tasks to Intel CAT cgroup.
> > 
> > Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
> > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> > Reviewed-by: Chao Peng <chao.p.peng@linux.intel.com>
> > 
> > v2: "PF_NO_SETAFFINITY check" -> "PF_NO_SETAFFINITY and kthreadd_task
> > checks"
> 
> This wasn't just for cpuset.  It's for all controllers.

Hm, indeed.  Workers landing in a throttled cfs rq wouldn't be as
painful as an rt worker being born in an rq with no rt_runtime, but
could sting.  Workers stuffed into the freezer would sting mightily.

	-Mike


      reply	other threads:[~2015-12-02  6:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 22:01 [PATCH] cgroups: move cpuset specific checks from generic code to cpuset_can_attach Marcelo Tosatti
2015-11-26  8:00 ` Chao Peng
2015-11-26 12:09 ` Mike Galbraith
2015-11-26 22:32   ` [PATCH] cgroups: move cpuset specific checks from generic code to cpuset_can_attach (v2) Marcelo Tosatti
2015-11-26 23:42     ` Mike Galbraith
2015-12-01 16:49     ` Tejun Heo
2015-12-02  6:21       ` Mike Galbraith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449037288.656.23.camel@gmail.com \
    --to=umgwanakikbuti@gmail.com \
    --cc=chao.p.peng@linux.intel.com \
    --cc=lcapitulino@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=tj@kernel.org \
    --cc=vikas.shivappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.