From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Han, Huaitong" <huaitong.han@intel.com>
Subject: Re: [V2 PATCH 8/9] x86/hvm: pkeys,
	add xstate support for pkeys
Date: Wed, 2 Dec 2015 07:20:47 +0000
Message-ID: <1449040852.4010.3.camel@intel.com>
References: <1448617923-10884-1-git-send-email-huaitong.han@intel.com>
	<1448617923-10884-9-git-send-email-huaitong.han@intel.com>
	<565E068A.3030803@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <565E068A.3030803@citrix.com>
Content-Language: en-US
Content-ID: <964DA5086A66DD4782AEED3053E3BECC@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "jbeulich@suse.com" <jbeulich@suse.com>, "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org


> Does this even compile?  There is already
> 
> static void *get_xsave_addr(void *xsave, unsigned int xfeature_idx)
> 
> higher in the same file.
> 
> That function should be augmented to take a struct xsave_struct
> *xsave,
> look at whether the representation is compressed or not, and use the
> appropriate offset array.
> 
Just because I have pulled staging branch when "static void
*get_xsave_addr(void *xsave, unsigned int xfeature_idx)" is not added.