From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <richard@nod.at>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-mtd@lists.infradead.org, tglx@linutronix.de
Subject: Re: [PATCH 3/3] mtd: ubi: wl: avoid erasing a PEB which is empty
Date: Wed, 02 Dec 2015 13:56:08 +0200 [thread overview]
Message-ID: <1449057368.20917.31.camel@gmail.com> (raw)
In-Reply-To: <565DF901.40208@nod.at>
On Tue, 2015-12-01 at 20:46 +0100, Richard Weinberger wrote:
> Am 26.11.2015 um 21:23 schrieb Sebastian Andrzej Siewior:
> > wear_leveling_worker() currently unconditionally puts a PEB on
> > erase in
> > the error case even it just been taken from the free_list and never
> > used.
> > In case the PEB was never used it can be put back on the free list
> > saving a precious erase cycle.
> >
> > v1…v2:
> > - to_leb_clean -> dst_leb_clean
> > - use the nested option for ensure_wear_leveling()
> > - do_sync_erase() can't go -ENOMEM so we can just go into
> > RO-mode now.
> >
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> Thanks a lot for the error handling cleanup and this improvement!
> All three patches look good to me.
> Artem, unless you have objections I'd merge them.
Sure, thanks!
prev parent reply other threads:[~2015-12-02 11:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 20:23 [PATCH 1/3] mtd: ubi: fixup error correction in do_sync_erase() Sebastian Andrzej Siewior
2015-11-26 20:23 ` [PATCH 2/3] mtd: ubi: don't leak e if schedule_erase() fails Sebastian Andrzej Siewior
2015-11-26 20:23 ` [PATCH 3/3] mtd: ubi: wl: avoid erasing a PEB which is empty Sebastian Andrzej Siewior
2015-12-01 19:46 ` Richard Weinberger
2015-12-02 11:56 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449057368.20917.31.camel@gmail.com \
--to=dedekind1@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.