From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: [PATCH 1/7] perf tools: Use event maps directly in perf_evsel__enable
Date: Thu, 3 Dec 2015 10:06:40 +0100 [thread overview]
Message-ID: <1449133606-14429-2-git-send-email-jolsa@kernel.org> (raw)
In-Reply-To: <1449133606-14429-1-git-send-email-jolsa@kernel.org>
All events now share proper cpu and thread maps. There's
no need to pass those maps from evlist, it's safe to use
evsel maps for enabling event.
Link: http://lkml.kernel.org/n/tip-8758blril51rkn4e6wef1gcv@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/builtin-stat.c | 5 +----
tools/perf/util/evsel.c | 5 ++++-
tools/perf/util/evsel.h | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index df2fbf046ee2..813c52ad9303 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -256,12 +256,9 @@ static void handle_initial_delay(void)
struct perf_evsel *counter;
if (initial_delay) {
- const int ncpus = cpu_map__nr(evsel_list->cpus),
- nthreads = thread_map__nr(evsel_list->threads);
-
usleep(initial_delay * 1000);
evlist__for_each(evsel_list, counter)
- perf_evsel__enable(counter, ncpus, nthreads);
+ perf_evsel__enable(counter);
}
}
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 0a1f4d9e52fc..3a9b5068667d 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -981,8 +981,11 @@ int perf_evsel__append_filter(struct perf_evsel *evsel,
return -1;
}
-int perf_evsel__enable(struct perf_evsel *evsel, int ncpus, int nthreads)
+int perf_evsel__enable(struct perf_evsel *evsel)
{
+ int nthreads = thread_map__nr(evsel->threads);
+ int ncpus = cpu_map__nr(evsel->cpus);
+
return perf_evsel__run_ioctl(evsel, ncpus, nthreads,
PERF_EVENT_IOC_ENABLE,
0);
diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
index 0e49bd742c63..a721592a3200 100644
--- a/tools/perf/util/evsel.h
+++ b/tools/perf/util/evsel.h
@@ -227,7 +227,7 @@ int perf_evsel__append_filter(struct perf_evsel *evsel,
const char *op, const char *filter);
int perf_evsel__apply_filter(struct perf_evsel *evsel, int ncpus, int nthreads,
const char *filter);
-int perf_evsel__enable(struct perf_evsel *evsel, int ncpus, int nthreads);
+int perf_evsel__enable(struct perf_evsel *evsel);
int perf_evsel__open_per_cpu(struct perf_evsel *evsel,
struct cpu_map *cpus);
--
2.4.3
next prev parent reply other threads:[~2015-12-03 9:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 9:06 [PATCH 0/7] perf stat: Change event enable code Jiri Olsa
2015-12-03 9:06 ` Jiri Olsa [this message]
2015-12-08 4:33 ` [tip:perf/core] perf evsel: Use event maps directly in perf_evsel__enable tip-bot for Jiri Olsa
2015-12-03 9:06 ` [PATCH 2/7] perf tools: Introduce perf_evsel__disable function Jiri Olsa
2015-12-08 4:33 ` [tip:perf/core] perf evsel: Introduce disable() method tip-bot for Jiri Olsa
2015-12-03 9:06 ` [PATCH 3/7] perf tools: Factor perf_evlist__(enable|disable) functions Jiri Olsa
2015-12-08 4:33 ` [tip:perf/core] perf evlist: " tip-bot for Jiri Olsa
2015-12-03 9:06 ` [PATCH 4/7] perf stat: Use perf_evlist__enable in handle_initial_delay Jiri Olsa
2015-12-08 4:34 ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-12-03 9:06 ` [PATCH 5/7] perf stat: Create events as disabled Jiri Olsa
2015-12-08 4:34 ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-12-03 9:06 ` [PATCH 6/7] perf stat: Move enable_on_exec setup under earlier code Jiri Olsa
2015-12-08 4:34 ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-12-03 9:06 ` [RFC 7/7] perf tools: Remove perf_evlist__(enable|disable)_event functions Jiri Olsa
2015-12-03 9:09 ` [PATCH 0/7] perf stat: Change event enable code Jiri Olsa
2015-12-07 21:09 ` Arnaldo Carvalho de Melo
2015-12-08 7:29 ` Adrian Hunter
2015-12-08 13:53 ` Arnaldo Carvalho de Melo
2015-12-09 13:44 ` Adrian Hunter
2015-12-11 12:42 ` Adrian Hunter
2015-12-16 15:55 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449133606-14429-2-git-send-email-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.