Re: [osstest test] 64958: regressions - trouble: broken/fail/pass

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2015-12-02 at 18:33 -0700, Jim Fehlig wrote:
> On 11/25/2015 08:32 AM, Ian Campbell wrote:
> > On Wed, 2015-11-25 at 14:37 +0000, Ian Campbell wrote:
> > > 2015-11-21 23:06:44 Z executing ssh ... root@172.16.144.44 virsh
> > > domxml-from-native xen-xl /etc/xen/debian.jessie.guest.osstest.cfg >
> > > /etc/xen/debian.jessie.guest.osstest.cfg.xml 
> > > error: An error occurred, but the cause is unknown
> > This turned out to be the check of vcpus vs MAX_VIRT_CPUS in
> > xenParseCPUFeatures. 
> > 
> > MAX_VIRT_CPUS is defined (by libvirt) as XEN_LEGACY_MAX_VCPUS, which is
> > mostly wrong on x86 (which supports more than that for guests using
> > vcpu
> > placement) but is very wrong on ARM where we insist on vcpu placement
> > and
> > XEN_LEGACY_MAX_VCPUS is therefore 1.
> > 
> > This test was trying to create a 2 cpu guest.
> > 
> > Since this check is in xen_common.c I think it might take a little
> > unravelling to fix this, since it seems to have lead to various other
> > assumptions to do with CPU masks fitting into an unsigned long in the
> > libvirt code base.
> 
> Hi Ian,
> 
> Sorry for the delay. I'm still catching up on mail after some days away.

No problem!

> > /me rolls up sleeves.
> 
> I see that your toiling has produced some patches. I'm slowly making it through
> patch reviews too, and will get to those soon.

Cool, thanks. I gathered (since posting) that libvirt was in an rc/freeze
phase at the minute, in any case there's certainly no hurry in so far as
this issue is only visible in osstest after it has been upgraded to Debian
Jessie, which is blocked on other things right now.

Cheers,
Ian.

> 
> Regards,
> Jim
>