From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Thu, 03 Dec 2015 20:03:04 +0000 Subject: Re: use-after-free in sctp_do_sm Message-Id: <1449172984.12092.0.camel@perches.com> List-Id: References: <20151203130525.GB4164@mrl.redhat.com> <566098BD.6010803@akamai.com> In-Reply-To: <566098BD.6010803@akamai.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jason Baron , Aaron Conole , Dmitry Vyukov Cc: Eric Dumazet , syzkaller , Vladislav Yasevich , linux-sctp@vger.kernel.org, netdev , Kostya Serebryany , Alexander Potapenko , Sasha Levin On Thu, 2015-12-03 at 14:32 -0500, Jason Baron wrote: > On 12/03/2015 01:52 PM, Aaron Conole wrote: > > I think that as a minimum, the following patch should be evaluted, > > but am unsure to whom I should submit it (after I test): [] > Agreed - the intention here is certainly to have no side effects. It > looks like 'no_printk()' is used in quite a few other places that would > benefit from this change. So we probably want a generic > 'really_no_printk()' macro. https://lkml.org/lkml/2012/6/17/231 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: use-after-free in sctp_do_sm Date: Thu, 03 Dec 2015 12:03:04 -0800 Message-ID: <1449172984.12092.0.camel@perches.com> References: <20151203130525.GB4164@mrl.redhat.com> <566098BD.6010803@akamai.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Eric Dumazet , syzkaller , Vladislav Yasevich , linux-sctp@vger.kernel.org, netdev , Kostya Serebryany , Alexander Potapenko , Sasha Levin To: Jason Baron , Aaron Conole , Dmitry Vyukov Return-path: Received: from smtprelay0159.hostedemail.com ([216.40.44.159]:35176 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753285AbbLCUDI (ORCPT ); Thu, 3 Dec 2015 15:03:08 -0500 In-Reply-To: <566098BD.6010803@akamai.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 2015-12-03 at 14:32 -0500, Jason Baron wrote: > On 12/03/2015 01:52 PM, Aaron Conole wrote: > > I think that as a minimum, the following patch should be evaluted, > > but am unsure to whom I should submit it (after I test): [] > Agreed - the intention here is certainly to have no side effects. It > looks like 'no_printk()' is used in quite a few other places that would > benefit from this change. So we probably want a generic > 'really_no_printk()' macro. https://lkml.org/lkml/2012/6/17/231