From: Joe Perches <joe@perches.com>
To: Aaron Conole <aconole@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: fix pr_debug and pr_devel to elide function calls
Date: Thu, 03 Dec 2015 15:13:32 -0800 [thread overview]
Message-ID: <1449184412.17296.6.camel@perches.com> (raw)
In-Reply-To: <1449182754-19088-1-git-send-email-aconole@redhat.com>
On Thu, 2015-12-03 at 17:45 -0500, Aaron Conole wrote:
> Currently, pr_debug and pr_devel will not elide function call arguments
> appearing in calls to no_printk for these macros. This is because all
> side effects must be honored before proceeding to the 0-value assignment
> in no_printk.
>
> The behavior is contrary to documentation found in the CodingStyle and
> header file where these functions are declared.
>
> This patch corrects that behavior by shunting out the call to no_printk
> completely. The format string is still checked by gcc for correctness, but
> no code seems to be emitted in common cases.
>
> fixes commit 5264f2f75d86 ("include/linux/printk.h: use and neaten
> no_printk")
>
The same should/could probably be done for dev_dbg/dev_vdbg
and the netdev and netif variants.
next prev parent reply other threads:[~2015-12-03 23:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 22:45 [PATCH] printk: fix pr_debug and pr_devel to elide function calls Aaron Conole
2015-12-03 23:13 ` Joe Perches [this message]
2015-12-04 16:31 ` Jason Baron
2015-12-04 16:38 ` Aaron Conole
2015-12-04 16:46 ` Joe Perches
2015-12-04 21:51 ` [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments Aaron Conole
2015-12-09 11:52 ` Arnd Bergmann
2015-12-09 15:13 ` Aaron Conole
2015-12-09 15:47 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449184412.17296.6.camel@perches.com \
--to=joe@perches.com \
--cc=aconole@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.