From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH 11/11] mg-schema-test-database: Sort out daemons; provide `daemons' subcommand Date: Mon, 7 Dec 2015 10:18:16 +0000 Message-ID: <1449483496.29724.42.camel@citrix.com> References: <1449257734-26860-1-git-send-email-ian.jackson@eu.citrix.com> <1449257734-26860-12-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a5stY-0001xU-2E for xen-devel@lists.xenproject.org; Mon, 07 Dec 2015 10:19:48 +0000 In-Reply-To: <1449257734-26860-12-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Fri, 2015-12-04 at 19:35 +0000, Ian Jackson wrote: > We arrange for the test configuration to look for the daemons on a > different host and port, and we provide a convenient way to run such a > pair of daemons. I was missing where *Daemon{Host,Port} were set here, it turns out to be in patch 9, which might be a bisection issue? I'm not sure we care for this new code. It also occurred to me while reading this that I didn't know what to do with OSSTEST_CONFIG here, I've not spotted in patch 9 where withtest() behaves in the obvious way, but it might be worth mentioning explicitly in the comments that the script DTRT and it is never(/rarely) necessary to set OSSTEST_CONFIG=local-config.test-database_SUFFIX yourself. But that's a comment on a previous patch, so: > Signed-off-by: Ian Jackson Acked-by: Ian Campbell