diff for duplicates of <1449572444.30729.32.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index a3ea7ab..32c18ea 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,66 +1,38 @@ -On Tue, 2015-12-08 at 12:59 +0200, Andy Shevchenko wrote: -> On Tue, 2015-12-08 at 10:37 +0100, Wolfram Sang wrote: -> > From: Wolfram Sang <wsa+renesas@sang-engineering.com> -> > -> > Switch to the new generic functions. Plain convert, no -> > functionality -> > added yet. -> -> One style nitpick. - -Ah, just seen next patch. Yeah, current make sense. -Never mind below comment. - -> -> > -> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> -> > --- -> > drivers/i2c/busses/i2c-rcar.c | 16 +++++++++------- -> > 1 file changed, 9 insertions(+), 7 deletions(-) -> > -> > diff --git a/drivers/i2c/busses/i2c-rcar.c -> > b/drivers/i2c/busses/i2c- -> > rcar.c -> > index d4322a9096786f..c663f4389bf898 100644 -> > --- a/drivers/i2c/busses/i2c-rcar.c -> > +++ b/drivers/i2c/busses/i2c-rcar.c -> > @@ -162,12 +162,15 @@ static int rcar_i2c_bus_barrier(struct -> > rcar_i2c_priv *priv) -> > return -EBUSY; -> > } -> > -> > -static int rcar_i2c_clock_calculate(struct rcar_i2c_priv *priv, -> > u32 -> > bus_speed) -> > +static int rcar_i2c_clock_calculate(struct rcar_i2c_priv *priv, -> > struct i2c_timings *t) -> > { -> > u32 scgd, cdf, round, ick, scl, cdf_width; -> > unsigned long rate; -> > struct device *dev = rcar_i2c_priv_to_dev(priv); -> > -> > + /* Fall back to previously used values if not supplied */ -> > + t->bus_freq_hz = t->bus_freq_hz ?: 100000; -> -> On one hand it seems enough space to put one more t->bus_freq_hz, on -> the other why not -> -> if (!t->bus_freq_hz) -> = 100000; -> -> I think a bit better to maintain latter. -> - --- -Andy Shevchenko <andriy.shevchenko@intel.com> -Intel Finland Oy ---------------------------------------------------------------------- -Intel Finland Oy -Registered Address: PL 281, 00181 Helsinki -Business Identity Code: 0357606 - 4 -Domiciled in Helsinki - -This e-mail and any attachments may contain confidential material for -the sole use of the intended recipient(s). Any review or distribution -by others is strictly prohibited. If you are not the intended -recipient, please contact the sender and delete all copies. +T24gVHVlLCAyMDE1LTEyLTA4IGF0IDEyOjU5ICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6 +DQo+IE9uIFR1ZSwgMjAxNS0xMi0wOCBhdCAxMDozNyArMDEwMCwgV29sZnJhbSBTYW5nIHdyb3Rl +Og0KPiA+IEZyb206IFdvbGZyYW0gU2FuZyA8d3NhK3JlbmVzYXNAc2FuZy1lbmdpbmVlcmluZy5j +b20+DQo+ID4gDQo+ID4gU3dpdGNoIHRvIHRoZSBuZXcgZ2VuZXJpYyBmdW5jdGlvbnMuIFBsYWlu +IGNvbnZlcnQsIG5vDQo+ID4gZnVuY3Rpb25hbGl0eQ0KPiA+IGFkZGVkIHlldC4NCj4gDQo+IE9u +ZSBzdHlsZSBuaXRwaWNrLg0KDQpBaCwganVzdCBzZWVuIG5leHQgcGF0Y2guIFllYWgsIGN1cnJl +bnQgbWFrZSBzZW5zZS4NCk5ldmVyIG1pbmQgYmVsb3cgY29tbWVudC4NCg0KPiANCj4gPiANCj4g +PiBTaWduZWQtb2ZmLWJ5OiBXb2xmcmFtIFNhbmcgPHdzYStyZW5lc2FzQHNhbmctZW5naW5lZXJp +bmcuY29tPg0KPiA+IC0tLQ0KPiA+IMKgZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1yY2FyLmMgfCAx +NiArKysrKysrKystLS0tLS0tDQo+ID4gwqAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCsp +LCA3IGRlbGV0aW9ucygtKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2kyYy9idXNz +ZXMvaTJjLXJjYXIuYw0KPiA+IGIvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy0NCj4gPiByY2FyLmMN +Cj4gPiBpbmRleCBkNDMyMmE5MDk2Nzg2Zi4uYzY2M2Y0Mzg5YmY4OTggMTAwNjQ0DQo+ID4gLS0t +IGEvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1yY2FyLmMNCj4gPiArKysgYi9kcml2ZXJzL2kyYy9i +dXNzZXMvaTJjLXJjYXIuYw0KPiA+IEBAIC0xNjIsMTIgKzE2MiwxNSBAQCBzdGF0aWMgaW50IHJj +YXJfaTJjX2J1c19iYXJyaWVyKHN0cnVjdA0KPiA+IHJjYXJfaTJjX3ByaXYgKnByaXYpDQo+ID4g +wqAJcmV0dXJuIC1FQlVTWTsNCj4gPiDCoH0NCj4gPiDCoA0KPiA+IC1zdGF0aWMgaW50IHJjYXJf +aTJjX2Nsb2NrX2NhbGN1bGF0ZShzdHJ1Y3QgcmNhcl9pMmNfcHJpdiAqcHJpdiwNCj4gPiB1MzIN +Cj4gPiBidXNfc3BlZWQpDQo+ID4gK3N0YXRpYyBpbnQgcmNhcl9pMmNfY2xvY2tfY2FsY3VsYXRl +KHN0cnVjdCByY2FyX2kyY19wcml2ICpwcml2LA0KPiA+IHN0cnVjdCBpMmNfdGltaW5ncyAqdCkN +Cj4gPiDCoHsNCj4gPiDCoAl1MzIgc2NnZCwgY2RmLCByb3VuZCwgaWNrLCBzY2wsIGNkZl93aWR0 +aDsNCj4gPiDCoAl1bnNpZ25lZCBsb25nIHJhdGU7DQo+ID4gwqAJc3RydWN0IGRldmljZSAqZGV2 +ID0gcmNhcl9pMmNfcHJpdl90b19kZXYocHJpdik7DQo+ID4gwqANCj4gPiArCS8qIEZhbGwgYmFj +ayB0byBwcmV2aW91c2x5IHVzZWQgdmFsdWVzIGlmIG5vdCBzdXBwbGllZCAqLw0KPiA+ICsJdC0+ +YnVzX2ZyZXFfaHogPSB0LT5idXNfZnJlcV9oeiA/OiAxMDAwMDA7DQo+IA0KPiBPbiBvbmUgaGFu +ZCBpdCBzZWVtcyBlbm91Z2ggc3BhY2UgdG8gcHV0IG9uZSBtb3JlIHQtPmJ1c19mcmVxX2h6LCBv +bg0KPiB0aGUgb3RoZXIgd2h5IG5vdA0KPiANCj4gaWYgKCF0LT5idXNfZnJlcV9oeikNCj4gwqAg +PSAxMDAwMDA7DQo+IA0KPiBJIHRoaW5rIGEgYml0IGJldHRlciB0byBtYWludGFpbiBsYXR0ZXIu +DQo+IA0KDQotLSANCkFuZHkgU2hldmNoZW5rbyA8YW5kcml5LnNoZXZjaGVua29AaW50ZWwuY29t +Pg0KSW50ZWwgRmlubGFuZCBPeQ0KLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t +LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkludGVsIEZpbmxhbmQgT3kKUmVnaXN0 +ZXJlZCBBZGRyZXNzOiBQTCAyODEsIDAwMTgxIEhlbHNpbmtpIApCdXNpbmVzcyBJZGVudGl0eSBD +b2RlOiAwMzU3NjA2IC0gNCAKRG9taWNpbGVkIGluIEhlbHNpbmtpIAoKVGhpcyBlLW1haWwgYW5k +IGFueSBhdHRhY2htZW50cyBtYXkgY29udGFpbiBjb25maWRlbnRpYWwgbWF0ZXJpYWwgZm9yCnRo +ZSBzb2xlIHVzZSBvZiB0aGUgaW50ZW5kZWQgcmVjaXBpZW50KHMpLiBBbnkgcmV2aWV3IG9yIGRp +c3RyaWJ1dGlvbgpieSBvdGhlcnMgaXMgc3RyaWN0bHkgcHJvaGliaXRlZC4gSWYgeW91IGFyZSBu +b3QgdGhlIGludGVuZGVkCnJlY2lwaWVudCwgcGxlYXNlIGNvbnRhY3QgdGhlIHNlbmRlciBhbmQg +ZGVsZXRlIGFsbCBjb3BpZXMuCg= diff --git a/a/content_digest b/N1/content_digest index 77111e4..ef428f8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\01449572360.30729.31.camel@linux.intel.com\0" "From\0Shevchenko, Andriy <andriy.shevchenko@intel.com>\0" "Subject\0Re: [PATCH v2 4/9] i2c: rcar: switch to i2c generic dt parsing\0" - "Date\0Tue, 8 Dec 2015 11:00:29 +0000\0" + "Date\0Tue, 08 Dec 2015 11:00:29 +0000\0" "To\0wsa@the-dreams.de <wsa@the-dreams.de>" " linux-i2c@vger.kernel.org <linux-i2c@vger.kernel.org>\0" "Cc\0linux-sh@vger.kernel.org <linux-sh@vger.kernel.org>" @@ -17,71 +17,43 @@ " geert@linux-m68k.org <geert@linux-m68k.org>\0" "\00:1\0" "b\0" - "On Tue, 2015-12-08 at 12:59 +0200, Andy Shevchenko wrote:\n" - "> On Tue, 2015-12-08 at 10:37 +0100, Wolfram Sang wrote:\n" - "> > From: Wolfram Sang <wsa+renesas@sang-engineering.com>\n" - "> > \n" - "> > Switch to the new generic functions. Plain convert, no\n" - "> > functionality\n" - "> > added yet.\n" - "> \n" - "> One style nitpick.\n" - "\n" - "Ah, just seen next patch. Yeah, current make sense.\n" - "Never mind below comment.\n" - "\n" - "> \n" - "> > \n" - "> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>\n" - "> > ---\n" - "> > \302\240drivers/i2c/busses/i2c-rcar.c | 16 +++++++++-------\n" - "> > \302\2401 file changed, 9 insertions(+), 7 deletions(-)\n" - "> > \n" - "> > diff --git a/drivers/i2c/busses/i2c-rcar.c\n" - "> > b/drivers/i2c/busses/i2c-\n" - "> > rcar.c\n" - "> > index d4322a9096786f..c663f4389bf898 100644\n" - "> > --- a/drivers/i2c/busses/i2c-rcar.c\n" - "> > +++ b/drivers/i2c/busses/i2c-rcar.c\n" - "> > @@ -162,12 +162,15 @@ static int rcar_i2c_bus_barrier(struct\n" - "> > rcar_i2c_priv *priv)\n" - "> > \302\240\treturn -EBUSY;\n" - "> > \302\240}\n" - "> > \302\240\n" - "> > -static int rcar_i2c_clock_calculate(struct rcar_i2c_priv *priv,\n" - "> > u32\n" - "> > bus_speed)\n" - "> > +static int rcar_i2c_clock_calculate(struct rcar_i2c_priv *priv,\n" - "> > struct i2c_timings *t)\n" - "> > \302\240{\n" - "> > \302\240\tu32 scgd, cdf, round, ick, scl, cdf_width;\n" - "> > \302\240\tunsigned long rate;\n" - "> > \302\240\tstruct device *dev = rcar_i2c_priv_to_dev(priv);\n" - "> > \302\240\n" - "> > +\t/* Fall back to previously used values if not supplied */\n" - "> > +\tt->bus_freq_hz = t->bus_freq_hz ?: 100000;\n" - "> \n" - "> On one hand it seems enough space to put one more t->bus_freq_hz, on\n" - "> the other why not\n" - "> \n" - "> if (!t->bus_freq_hz)\n" - "> \302\240 = 100000;\n" - "> \n" - "> I think a bit better to maintain latter.\n" - "> \n" - "\n" - "-- \n" - "Andy Shevchenko <andriy.shevchenko@intel.com>\n" - "Intel Finland Oy\n" - "---------------------------------------------------------------------\n" - "Intel Finland Oy\n" - "Registered Address: PL 281, 00181 Helsinki \n" - "Business Identity Code: 0357606 - 4 \n" - "Domiciled in Helsinki \n" - "\n" - "This e-mail and any attachments may contain confidential material for\n" - "the sole use of the intended recipient(s). Any review or distribution\n" - "by others is strictly prohibited. If you are not the intended\n" - recipient, please contact the sender and delete all copies. + "T24gVHVlLCAyMDE1LTEyLTA4IGF0IDEyOjU5ICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6\n" + "DQo+IE9uIFR1ZSwgMjAxNS0xMi0wOCBhdCAxMDozNyArMDEwMCwgV29sZnJhbSBTYW5nIHdyb3Rl\n" + "Og0KPiA+IEZyb206IFdvbGZyYW0gU2FuZyA8d3NhK3JlbmVzYXNAc2FuZy1lbmdpbmVlcmluZy5j\n" + "b20+DQo+ID4gDQo+ID4gU3dpdGNoIHRvIHRoZSBuZXcgZ2VuZXJpYyBmdW5jdGlvbnMuIFBsYWlu\n" + "IGNvbnZlcnQsIG5vDQo+ID4gZnVuY3Rpb25hbGl0eQ0KPiA+IGFkZGVkIHlldC4NCj4gDQo+IE9u\n" + "ZSBzdHlsZSBuaXRwaWNrLg0KDQpBaCwganVzdCBzZWVuIG5leHQgcGF0Y2guIFllYWgsIGN1cnJl\n" + "bnQgbWFrZSBzZW5zZS4NCk5ldmVyIG1pbmQgYmVsb3cgY29tbWVudC4NCg0KPiANCj4gPiANCj4g\n" + "PiBTaWduZWQtb2ZmLWJ5OiBXb2xmcmFtIFNhbmcgPHdzYStyZW5lc2FzQHNhbmctZW5naW5lZXJp\n" + "bmcuY29tPg0KPiA+IC0tLQ0KPiA+IMKgZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1yY2FyLmMgfCAx\n" + "NiArKysrKysrKystLS0tLS0tDQo+ID4gwqAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCsp\n" + "LCA3IGRlbGV0aW9ucygtKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2kyYy9idXNz\n" + "ZXMvaTJjLXJjYXIuYw0KPiA+IGIvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy0NCj4gPiByY2FyLmMN\n" + "Cj4gPiBpbmRleCBkNDMyMmE5MDk2Nzg2Zi4uYzY2M2Y0Mzg5YmY4OTggMTAwNjQ0DQo+ID4gLS0t\n" + "IGEvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1yY2FyLmMNCj4gPiArKysgYi9kcml2ZXJzL2kyYy9i\n" + "dXNzZXMvaTJjLXJjYXIuYw0KPiA+IEBAIC0xNjIsMTIgKzE2MiwxNSBAQCBzdGF0aWMgaW50IHJj\n" + "YXJfaTJjX2J1c19iYXJyaWVyKHN0cnVjdA0KPiA+IHJjYXJfaTJjX3ByaXYgKnByaXYpDQo+ID4g\n" + "wqAJcmV0dXJuIC1FQlVTWTsNCj4gPiDCoH0NCj4gPiDCoA0KPiA+IC1zdGF0aWMgaW50IHJjYXJf\n" + "aTJjX2Nsb2NrX2NhbGN1bGF0ZShzdHJ1Y3QgcmNhcl9pMmNfcHJpdiAqcHJpdiwNCj4gPiB1MzIN\n" + "Cj4gPiBidXNfc3BlZWQpDQo+ID4gK3N0YXRpYyBpbnQgcmNhcl9pMmNfY2xvY2tfY2FsY3VsYXRl\n" + "KHN0cnVjdCByY2FyX2kyY19wcml2ICpwcml2LA0KPiA+IHN0cnVjdCBpMmNfdGltaW5ncyAqdCkN\n" + "Cj4gPiDCoHsNCj4gPiDCoAl1MzIgc2NnZCwgY2RmLCByb3VuZCwgaWNrLCBzY2wsIGNkZl93aWR0\n" + "aDsNCj4gPiDCoAl1bnNpZ25lZCBsb25nIHJhdGU7DQo+ID4gwqAJc3RydWN0IGRldmljZSAqZGV2\n" + "ID0gcmNhcl9pMmNfcHJpdl90b19kZXYocHJpdik7DQo+ID4gwqANCj4gPiArCS8qIEZhbGwgYmFj\n" + "ayB0byBwcmV2aW91c2x5IHVzZWQgdmFsdWVzIGlmIG5vdCBzdXBwbGllZCAqLw0KPiA+ICsJdC0+\n" + "YnVzX2ZyZXFfaHogPSB0LT5idXNfZnJlcV9oeiA/OiAxMDAwMDA7DQo+IA0KPiBPbiBvbmUgaGFu\n" + "ZCBpdCBzZWVtcyBlbm91Z2ggc3BhY2UgdG8gcHV0IG9uZSBtb3JlIHQtPmJ1c19mcmVxX2h6LCBv\n" + "bg0KPiB0aGUgb3RoZXIgd2h5IG5vdA0KPiANCj4gaWYgKCF0LT5idXNfZnJlcV9oeikNCj4gwqAg\n" + "PSAxMDAwMDA7DQo+IA0KPiBJIHRoaW5rIGEgYml0IGJldHRlciB0byBtYWludGFpbiBsYXR0ZXIu\n" + "DQo+IA0KDQotLSANCkFuZHkgU2hldmNoZW5rbyA8YW5kcml5LnNoZXZjaGVua29AaW50ZWwuY29t\n" + "Pg0KSW50ZWwgRmlubGFuZCBPeQ0KLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t\n" + "LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkludGVsIEZpbmxhbmQgT3kKUmVnaXN0\n" + "ZXJlZCBBZGRyZXNzOiBQTCAyODEsIDAwMTgxIEhlbHNpbmtpIApCdXNpbmVzcyBJZGVudGl0eSBD\n" + "b2RlOiAwMzU3NjA2IC0gNCAKRG9taWNpbGVkIGluIEhlbHNpbmtpIAoKVGhpcyBlLW1haWwgYW5k\n" + "IGFueSBhdHRhY2htZW50cyBtYXkgY29udGFpbiBjb25maWRlbnRpYWwgbWF0ZXJpYWwgZm9yCnRo\n" + "ZSBzb2xlIHVzZSBvZiB0aGUgaW50ZW5kZWQgcmVjaXBpZW50KHMpLiBBbnkgcmV2aWV3IG9yIGRp\n" + "c3RyaWJ1dGlvbgpieSBvdGhlcnMgaXMgc3RyaWN0bHkgcHJvaGliaXRlZC4gSWYgeW91IGFyZSBu\n" + "b3QgdGhlIGludGVuZGVkCnJlY2lwaWVudCwgcGxlYXNlIGNvbnRhY3QgdGhlIHNlbmRlciBhbmQg\n" + ZGVsZXRlIGFsbCBjb3BpZXMuCg= -4936e927329edb70b61bddff0a9efc8793560ee87adaac20b821924c2338856c +18d045b10e2ab0eb442895be12cac2fa695c276220b571f0e2dce28a99b25ca8
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.