Re: [PATCH i-g-t] RFC: split PM workarounds into separate lib

From: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
To: "david.weinehall@linux.intel.com"
	<david.weinehall@linux.intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] RFC: split PM workarounds into separate lib
Date: Tue, 8 Dec 2015 13:22:14 +0000	[thread overview]
Message-ID: <1449580934.4929.18.camel@intel.com> (raw)
In-Reply-To: <1449564640-6001-1-git-send-email-david.weinehall@linux.intel.com>

Em Ter, 2015-12-08 às 10:50 +0200, David Weinehall escreveu:
> Since the defaults for some external power management related
> settings
> prevents us from testing our power management functionality properly,
> we have to work around it. Currently this is done from the individual
> test cases, but this is sub-optimal.  This patch moves the PM-related
> workarounds into a separate library, and adds some code to restore
> the
> previous settings for the SATA link power management while at it.
> 
> This patch should be seen as a RFC; there might be other workarounds
> for external issues that should be moved into the library, and if
> those
> workarounds aren't related to power management it might be better to
> choose a different name for the library.

I didn't deeply look the implementation, but you have my Acked-by on
the idea.

You may also consider adding a function to just run "sudo powertop --
auto-tune" in addition to the other things, but you can't undo this
later.

But in the end, it all depends on your machine. A bad machine will
never reach the deepest expected PC states. That's the problem when
automating things...

Since you're interested in PM, you may also want to look at:
http://patchwork.freedesktop.org/patch/66392/
maybe there's some code there that you may want to take.

> 
> David Weinehall (1):
>   lib/pm_workarounds: Lib for PM workarounds
> 
>  lib/Makefile.sources |   2 +
>  lib/igt.h            |   1 +
>  lib/igt_aux.c        |  15 +---
>  lib/pm_workarounds.c | 233
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  lib/pm_workarounds.h |  31 +++++++
>  tests/pm_lpsp.c      |  25 +-----
>  tests/pm_rpm.c       |  29 ++-----
>  7 files changed, 279 insertions(+), 57 deletions(-)
>  create mode 100644 lib/pm_workarounds.c
>  create mode 100644 lib/pm_workarounds.h
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx