All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] axs10x: add support of generic ECHI USB 2.0 controller
Date: Tue, 8 Dec 2015 14:34:42 +0000	[thread overview]
Message-ID: <1449585282.2881.5.camel@synopsys.com> (raw)
In-Reply-To: <201512012023.24636.marex@denx.de>

Hi Alexey,

On Tue, 2015-12-01 at 20:23 +0100, Marek Vasut wrote:
> On Tuesday, December 01, 2015 at 08:08:10 PM, Alexey Brodkin wrote:
> > Hi Marek,
> 
> Hi!
> 
> > On Mon, 2015-11-30 at 19:06 +0100, Marek Vasut wrote:
> > > On Monday, November 30, 2015 at 06:53:25 PM, Alexey Brodkin wrote:
> > > > This commit adds support of USB 2.0 storage media on AXS10x boards.
> > > > 
> > > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > > > Cc: Marek Vasut <marex@denx.de>
> > > > Cc: Simon Glass <sjg@chromium.org>
> > > > ---
> > > 
> > > Ad subject -- It's EHCI, not ECHI ;-)
> > 
> > Good catch!
> > 
> > > > diff --git a/configs/axs101_defconfig b/configs/axs101_defconfig
> > > > index 52d5e2f..a541d9d 100644
> > > > --- a/configs/axs101_defconfig
> > > > +++ b/configs/axs101_defconfig
> > > > @@ -8,6 +8,7 @@ CONFIG_DEFAULT_DEVICE_TREE="axs10x"
> > > > 
> > > >  CONFIG_SYS_PROMPT="AXS# "
> > > >  # CONFIG_CMD_IMLS is not set
> > > >  # CONFIG_CMD_FLASH is not set
> > > > 
> > > > +CONFIG_CMD_USB=y
> > > > 
> > > >  # CONFIG_CMD_SETEXPR is not set
> > > >  CONFIG_CMD_DHCP=y
> > > >  CONFIG_CMD_PING=y
> > > > 
> > > > @@ -19,4 +20,9 @@ CONFIG_CLK=y
> > > > 
> > > >  CONFIG_DM_ETH=y
> > > >  CONFIG_ETH_DESIGNWARE=y
> > > >  CONFIG_SYS_NS16550=y
> > > > 
> > > > +CONFIG_USB=y
> > > > +CONFIG_DM_USB=y
> > > > +CONFIG_USB_EHCI_HCD=y
> > > 
> > > You don't need EHCI_HCD in defconfig in case EHCI_GENERIC depends on it I
> > > think.
> > 
> > Yeah but remember in drivers/usb/host it's not a dependency but conditional
> > branch. That's why "savedefconfig" (but not me really) put EHCI_HCD here.
> 
> Right, got it.

Applied to U-Boot-ARC, thanks!

-Alexey

      reply	other threads:[~2015-12-08 14:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 17:53 [U-Boot] [PATCH v2] axs10x: add support of generic ECHI USB 2.0 controller Alexey Brodkin
2015-11-30 18:06 ` Marek Vasut
2015-12-01 19:08   ` Alexey Brodkin
2015-12-01 19:23     ` Marek Vasut
2015-12-08 14:34       ` Alexey Brodkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449585282.2881.5.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.