From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v3 1/6] xl: Return proper error codes for
 block-attach and block-detach
Date: Tue, 8 Dec 2015 17:15:28 +0000
Message-ID: <1449594928.16124.122.camel@citrix.com>
References: <1448970835-2706-1-git-send-email-george.dunlap@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1448970835-2706-1-git-send-email-george.dunlap@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <george.dunlap@eu.citrix.com>, xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@citrix.com>, Wei Liu <wei.liu2@citrix.com>
List-Id: xen-devel@lists.xenproject.org

T24gVHVlLCAyMDE1LTEyLTAxIGF0IDExOjUzICswMDAwLCBHZW9yZ2UgRHVubGFwIHdyb3RlOgo+
IFJldHVybiBwcm9wZXIgZXJyb3IgY29kZXMgb24gZmFpbHVyZSBzbyB0aGF0IHNjcmlwdHMgY2Fu
IHRlbGwgd2hldGhlcgo+IHRoZSBjb21tYW5kIGNvbXBsZXRlZCBwcm9wZXJseSBvciBub3QuCj4g
Cj4gQWxzbyB3aGlsZSB3ZSdyZSBhdCBpdCwgbm9ybWFsaXplIGluaXQgYW5kIGRpc3Bvc2Ugb2YK
PiBsaWJ4bF9kZXZpY2VfZGlzayBzdHJ1Y3R1cmVzLsKgwqBUaGlzIG1lYW5zIGNhbGxpbmcgaW5p
dCBhbmQgZGlzcG9zZSBpbgo+IHRoZSBhY3R1YWwgZnVuY3Rpb25zIHdoZXJlIHRoZXkgYXJlIGRl
Y2xhcmVkLgo+IAo+IFRoaXMgaW4gdHVybiBtZWFucyBjaGFuZ2luZyBwYXJzZV9kaXNrX2NvbmZp
Z19tdWx0aXN0cmluZygpIHRvIG5vdAo+IGNhbGwgbGlieGxfZGV2aWNlX2Rpc2tfaW5pdC7CoMKg
QW5kIHRoYXQgaW4gdHVybiBtZWFucyBjaGFuZ2VzIHRvCj4gY2FsbGVycyBvZiBwYXJzZV9kaXNr
X2NvbmZpZygpLgo+IAo+IEl0IGFsc28gbWVhbnMgcmVtb3ZpbmcgbGlieGxfZGV2aWNlX2Rpc2tf
aW5pdCgpIGZyb20KPiBsaWJ4bC5jOmxpYnhsX3ZkZXZfdG9fZGV2aWNlX2Rpc2soKS7CoMKgVGhp
cyBpcyBvbmx5IGNhbGxlZCBmcm9tCj4geGxfY21kaW1wbC5jLgoKLi4uIGFuZCB0aGUgb2NhbWwg
YmluZGluZ3MuCgpJIGNhbid0IHJlbWVtYmVyIHdoYXQgd2UgZGVjaWRlZCByZWdhcmRpbmcgbGli
eGwgImdldHRlciIgZnVuY3Rpb25zIGFuZAppbml0aWFsaXNhdGlvbiBvZiB0aGUgZGF0YSB0eXBl
IChpLmUuIHdob3NlIHJlc3BvbnNpYmlsaXR5IGl0IGlzKSwgYnV0IGl0CnNlZW1zIHRoYXQgY2hh
bmdpbmcgYSBnaXZlbiBjYWxscyBzZW1hbnRpY3MgaXMgcmF0aGVyIGRhbmdlcm91cyBBUEktd2lz
ZS4KCldlaSwgSVNUUiB5b3Ugc3R1bWJsaW5nIG92ZXIgdGhpcyBvbmNlIGFuZCB0aGUgZm9ybXVs
YXRpb24gb2YgQSBQbGFuKHRtKSwKYnV0IEkgY2FuJ3QgcmVtZW1iZXIgd2hhdCBpdCB3YXMsIGNh
biB5b3U/Cgo+IAo+IFNpZ25lZC1vZmYtYnk6IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBA
ZXUuY2l0cml4LmNvbT4KPiAtLS0KPiBDQzogSWFuIENhbXBiZWxsIDxpYW4uY2FtcGJlbGxAY2l0
cml4LmNvbT4KPiBDQzogSWFuIEphY2tzb24gPGlhbi5qYWNrc29uQGNpdHJpeC5jb20+Cj4gQ0M6
IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+Cj4gQ0M6IEtvbnJhZCBXaWxrIDxrb25yYWQu
d2lsa0BvcmFjbGUuY29tPgo+IAo+IHYzOgo+IMKgLSBSZWJhc2VkIHRvIHRpcAo+IAo+IHYyOgo+
IMKgLSBSZXN0cnVjdHVyZSBmdW5jdGlvbnMgdG8gbWFrZSBzdXJlIGluaXQgYW5kIGRpc3Bvc2Ug
YXJlIHByb3Blcmx5Cj4gwqBjYWxsZWQuCj4gLS0tCj4gwqB0b29scy9saWJ4bC9saWJ4bC5jwqDC
oMKgwqDCoMKgfMKgwqAyIC0tCj4gwqB0b29scy9saWJ4bC94bF9jbWRpbXBsLmMgfCAyOSArKysr
KysrKysrKysrKysrKysrKy0tLS0tLS0tLQo+IMKgMiBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRp
b25zKCspLCAxMSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGwvbGli
eGwuYyBiL3Rvb2xzL2xpYnhsL2xpYnhsLmMKPiBpbmRleCBiZDNhYWM4Li44MTRkMDU2IDEwMDY0
NAo+IC0tLSBhL3Rvb2xzL2xpYnhsL2xpYnhsLmMKPiArKysgYi90b29scy9saWJ4bC9saWJ4bC5j
Cj4gQEAgLTI3MzgsOCArMjczOCw2IEBAIGludCBsaWJ4bF92ZGV2X3RvX2RldmljZV9kaXNrKGxp
YnhsX2N0eCAqY3R4LAo+IHVpbnQzMl90IGRvbWlkLAo+IMKgwqDCoMKgwqBpZiAoZGV2aWQgPCAw
KQo+IMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiBFUlJPUl9JTlZBTDsKPiDCoAo+IC3CoMKgwqDC
oGxpYnhsX2RldmljZV9kaXNrX2luaXQoZGlzayk7Cj4gLQo+IMKgwqDCoMKgwqBkb21wYXRoID0g
bGlieGxfX3hzX2dldF9kb21wYXRoKGdjLCBkb21pZCk7Cj4gwqDCoMKgwqDCoGlmICghZG9tcGF0
aCkgewo+IMKgwqDCoMKgwqDCoMKgwqDCoGdvdG8gb3V0Owo+IGRpZmYgLS1naXQgYS90b29scy9s
aWJ4bC94bF9jbWRpbXBsLmMgYi90b29scy9saWJ4bC94bF9jbWRpbXBsLmMKPiBpbmRleCAyYjYz
NzFkLi4yYmEyMzkzIDEwMDY0NAo+IC0tLSBhL3Rvb2xzL2xpYnhsL3hsX2NtZGltcGwuYwo+ICsr
KyBiL3Rvb2xzL2xpYnhsL3hsX2NtZGltcGwuYwo+IEBAIC01NzAsOCArNTcwLDYgQEAgc3RhdGlj
IHZvaWQgcGFyc2VfZGlza19jb25maWdfbXVsdGlzdHJpbmcoWExVX0NvbmZpZwo+ICoqY29uZmln
LAo+IMKgewo+IMKgwqDCoMKgwqBpbnQgZTsKPiDCoAo+IC3CoMKgwqDCoGxpYnhsX2RldmljZV9k
aXNrX2luaXQoZGlzayk7Cj4gLQo+IMKgwqDCoMKgwqBpZiAoISpjb25maWcpIHsKPiDCoMKgwqDC
oMKgwqDCoMKgwqAqY29uZmlnID0geGx1X2NmZ19pbml0KHN0ZGVyciwgImNvbW1hbmQgbGluZSIp
Owo+IMKgwqDCoMKgwqDCoMKgwqDCoGlmICghKmNvbmZpZykgeyBwZXJyb3IoInhsdV9jZmdfaW5p
dCIpOyBleGl0KC0xKTsgfQo+IEBAIC0zMzQwLDYgKzMzMzgsOCBAQCBzdGF0aWMgaW50IGNkX2lu
c2VydCh1aW50MzJfdCBkb21pZCwgY29uc3QgY2hhcgo+ICp2aXJ0ZGV2LCBjaGFyICpwaHlzKQo+
IMKgwqDCoMKgwqB4YXNwcmludGYoJmJ1ZiwgInZkZXY9JXMsYWNjZXNzPXIsZGV2dHlwZT1jZHJv
bSx0YXJnZXQ9JXMiLAo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHZpcnRkZXYsIHBo
eXMgPyBwaHlzIDogIiIpOwo+IMKgCj4gK8KgwqDCoMKgbGlieGxfZGV2aWNlX2Rpc2tfaW5pdCgm
ZGlzayk7Cj4gKwo+IMKgwqDCoMKgwqBwYXJzZV9kaXNrX2NvbmZpZygmY29uZmlnLCBidWYsICZk
aXNrKTsKPiDCoAo+IMKgwqDCoMKgwqAvKiBBVE0gdGhlIGV4aXN0ZW5jZSBvZiB0aGUgYmFja2lu
ZyBmaWxlIGlzIG5vdCBjaGVja2VkIGZvciBxZGlzawo+IEBAIC02NjQ5LDYgKzY2NDksNyBAQCBp
bnQgbWFpbl9ibG9ja2F0dGFjaChpbnQgYXJnYywgY2hhciAqKmFyZ3YpCj4gwqDCoMKgwqDCoHVp
bnQzMl90IGZlX2RvbWlkOwo+IMKgwqDCoMKgwqBsaWJ4bF9kZXZpY2VfZGlzayBkaXNrOwo+IMKg
wqDCoMKgwqBYTFVfQ29uZmlnICpjb25maWcgPSAwOwo+ICvCoMKgwqDCoGludCByYyA9IDA7Cj4g
wqAKPiDCoMKgwqDCoMKgU1dJVENIX0ZPUkVBQ0hfT1BUKG9wdCwgIiIsIE5VTEwsICJibG9jay1h
dHRhY2giLCAyKSB7Cj4gwqDCoMKgwqDCoMKgwqDCoMKgLyogTm8gb3B0aW9ucyAqLwo+IEBAIC02
NjYwLDYgKzY2NjEsOCBAQCBpbnQgbWFpbl9ibG9ja2F0dGFjaChpbnQgYXJnYywgY2hhciAqKmFy
Z3YpCj4gwqDCoMKgwqDCoH0KPiDCoMKgwqDCoMKgb3B0aW5kKys7Cj4gwqAKPiArwqDCoMKgwqBs
aWJ4bF9kZXZpY2VfZGlza19pbml0KCZkaXNrKTsKPiArCj4gwqDCoMKgwqDCoHBhcnNlX2Rpc2tf
Y29uZmlnX211bHRpc3RyaW5nCj4gwqDCoMKgwqDCoMKgwqDCoMKgKCZjb25maWcsIGFyZ2Mtb3B0
aW5kLCAoY29uc3QgY2hhciogY29uc3QqKWFyZ3YgKyBvcHRpbmQsCj4gJmRpc2spOwo+IMKgCj4g
QEAgLTY2NjgsMTQgKzY2NzEsMTcgQEAgaW50IG1haW5fYmxvY2thdHRhY2goaW50IGFyZ2MsIGNo
YXIgKiphcmd2KQo+IMKgwqDCoMKgwqDCoMKgwqDCoHByaW50ZigiZGlzazogJXNcbiIsIGpzb24p
Owo+IMKgwqDCoMKgwqDCoMKgwqDCoGZyZWUoanNvbik7Cj4gwqDCoMKgwqDCoMKgwqDCoMKgaWYg
KGZlcnJvcihzdGRvdXQpIHx8IGZmbHVzaChzdGRvdXQpKSB7IHBlcnJvcigic3Rkb3V0Iik7IGV4
aXQoLQo+IDEpOyB9Cj4gLcKgwqDCoMKgwqDCoMKgwqByZXR1cm4gMDsKPiArwqDCoMKgwqDCoMKg
wqDCoGdvdG8gb3V0Owo+IMKgwqDCoMKgwqB9Cj4gwqAKPiDCoMKgwqDCoMKgaWYgKGxpYnhsX2Rl
dmljZV9kaXNrX2FkZChjdHgsIGZlX2RvbWlkLCAmZGlzaywgMCkpIHsKPiDCoMKgwqDCoMKgwqDC
oMKgwqBmcHJpbnRmKHN0ZGVyciwgImxpYnhsX2RldmljZV9kaXNrX2FkZCBmYWlsZWQuXG4iKTsK
PiAtwqDCoMKgwqDCoMKgwqDCoHJldHVybiAxOwo+ICvCoMKgwqDCoMKgwqDCoMKgcmMgPSAxOwo+
IMKgwqDCoMKgwqB9Cj4gLcKgwqDCoMKgcmV0dXJuIDA7Cj4gK291dDoKPiArwqDCoMKgwqBsaWJ4
bF9kZXZpY2VfZGlza19kaXNwb3NlKCZkaXNrKTsKPiArCj4gK8KgwqDCoMKgcmV0dXJuIHJjOwo+
IMKgfQo+IMKgCj4gwqBpbnQgbWFpbl9ibG9ja2xpc3QoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+
IEBAIC02NzI2LDE4ICs2NzMyLDIzIEBAIGludCBtYWluX2Jsb2NrZGV0YWNoKGludCBhcmdjLCBj
aGFyICoqYXJndikKPiDCoMKgwqDCoMKgwqDCoMKgwqAvKiBObyBvcHRpb25zICovCj4gwqDCoMKg
wqDCoH0KPiDCoAo+ICvCoMKgwqDCoGxpYnhsX2RldmljZV9kaXNrX2luaXQoJmRpc2spOwo+ICsK
PiDCoMKgwqDCoMKgZG9taWQgPSBmaW5kX2RvbWFpbihhcmd2W29wdGluZF0pOwo+IMKgCj4gwqDC
oMKgwqDCoGlmIChsaWJ4bF92ZGV2X3RvX2RldmljZV9kaXNrKGN0eCwgZG9taWQsIGFyZ3Zbb3B0
aW5kKzFdLCAmZGlzaykpIHsKPiDCoMKgwqDCoMKgwqDCoMKgwqBmcHJpbnRmKHN0ZGVyciwgIkVy
cm9yOiBEZXZpY2UgJXMgbm90IGNvbm5lY3RlZC5cbiIsCj4gYXJndltvcHRpbmQrMV0pOwo+IC3C
oMKgwqDCoMKgwqDCoMKgcmV0dXJuIDE7Cj4gK8KgwqDCoMKgwqDCoMKgwqByYyA9IDE7Cj4gK8Kg
wqDCoMKgwqDCoMKgwqBnb3RvIG91dDsKPiDCoMKgwqDCoMKgfQo+IC3CoMKgwqDCoHJjID0gbGli
eGxfZGV2aWNlX2Rpc2tfcmVtb3ZlKGN0eCwgZG9taWQsICZkaXNrLCAwKTsKPiAtwqDCoMKgwqBp
ZiAocmMpIHsKPiArwqDCoMKgwqBpZiAobGlieGxfZGV2aWNlX2Rpc2tfcmVtb3ZlKGN0eCwgZG9t
aWQsICZkaXNrLCAwKSkgewo+IMKgwqDCoMKgwqDCoMKgwqDCoGZwcmludGYoc3RkZXJyLCAibGli
eGxfZGV2aWNlX2Rpc2tfcmVtb3ZlIGZhaWxlZC5cbiIpOwo+IC3CoMKgwqDCoMKgwqDCoMKgcmV0
dXJuIDE7Cj4gK8KgwqDCoMKgwqDCoMKgwqByYyA9IDE7Cj4gwqDCoMKgwqDCoH0KPiArCj4gK291
dDoKPiDCoMKgwqDCoMKgbGlieGxfZGV2aWNlX2Rpc2tfZGlzcG9zZSgmZGlzayk7Cj4gKwo+IMKg
wqDCoMKgwqByZXR1cm4gcmM7Cj4gwqB9Cj4gwqAKCl9fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxp
c3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==