From: Ian Campbell <ian.campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH] tools/libxc: Identify problematic file in error messages
Date: Tue, 8 Dec 2015 17:20:54 +0000 [thread overview]
Message-ID: <1449595254.16124.127.camel@citrix.com> (raw)
In-Reply-To: <1449493748-2639-1-git-send-email-andrew.cooper3@citrix.com>
On Mon, 2015-12-07 at 13:09 +0000, Andrew Cooper wrote:
> Error messages along the lines of:
>
> xc: error: panic: xc_dom_core.c:207: failed to open file: No such file
> or
> directory: Internal error
>
> are of very little use.
>
> Include the filename in the error messages, so the user does not have to
> resort to debug level logging to identify the problem.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked + applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2015-12-08 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 13:09 [PATCH] tools/libxc: Identify problematic file in error messages Andrew Cooper
2015-12-08 17:20 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449595254.16124.127.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.