diff for duplicates of <1449656787.3311.25.camel@suse.de> diff --git a/a/1.txt b/N1/1.txt index 13a17c9..c68ce95 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -13,7 +13,7 @@ On Wed, 2015-12-09 at 13:21 +0300, Dan Carpenter wrote: > > /* Allocate bio integrity payload and integrity vectors */ > bip = bio_integrity_alloc(bio, GFP_NOIO, nr_pages); -> - if (unlikely(bip = NULL)) { +> - if (unlikely(bip == NULL)) { > + if (IS_ERR(bip)) { > printk(KERN_ERR "could not allocate data integrity > bioset\n"); @@ -25,11 +25,11 @@ On Wed, 2015-12-09 at 13:21 +0300, Dan Carpenter wrote: > bip->bip_flags |= BIP_BLOCK_INTEGRITY; > @@ -465,9 +465,8 @@ int bio_integrity_clone(struct bio *bio, struct bio > *bio_src, -> BUG_ON(bip_src = NULL); +> BUG_ON(bip_src == NULL); > > bip = bio_integrity_alloc(bio, gfp_mask, bip_src->bip_vcnt); > - -> - if (bip = NULL) +> - if (bip == NULL) > - return -EIO; > + if (IS_ERR(bip)) > + return PTR_ERR(bip); diff --git a/a/content_digest b/N1/content_digest index cc20ca0..2c53b06 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020151209102123.GA3173@mwanda\0" "From\0Johannes Thumshirn <jthumshirn@suse.de>\0" "Subject\0Re: [patch] blk-integrity: checking for NULL instead of IS_ERR\0" - "Date\0Wed, 09 Dec 2015 10:26:27 +0000\0" + "Date\0Wed, 09 Dec 2015 11:26:27 +0100\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>" Jens Axboe <axboe@kernel.dk> " Keith Busch <keith.busch@intel.com>\0" @@ -25,7 +25,7 @@ "> \302\240\n" "> \302\240\t/* Allocate bio integrity payload and integrity vectors */\n" "> \302\240\tbip = bio_integrity_alloc(bio, GFP_NOIO, nr_pages);\n" - "> -\tif (unlikely(bip = NULL)) {\n" + "> -\tif (unlikely(bip == NULL)) {\n" "> +\tif (IS_ERR(bip)) {\n" "> \302\240\t\tprintk(KERN_ERR \"could not allocate data integrity\n" "> bioset\\n\");\n" @@ -37,11 +37,11 @@ "> \302\240\tbip->bip_flags |= BIP_BLOCK_INTEGRITY;\n" "> @@ -465,9 +465,8 @@ int bio_integrity_clone(struct bio *bio, struct bio\n" "> *bio_src,\n" - "> \302\240\tBUG_ON(bip_src = NULL);\n" + "> \302\240\tBUG_ON(bip_src == NULL);\n" "> \302\240\n" "> \302\240\tbip = bio_integrity_alloc(bio, gfp_mask, bip_src->bip_vcnt);\n" "> -\n" - "> -\tif (bip = NULL)\n" + "> -\tif (bip == NULL)\n" "> -\t\treturn -EIO;\n" "> +\tif (IS_ERR(bip))\n" "> +\t\treturn PTR_ERR(bip);\n" @@ -55,4 +55,4 @@ "\n" Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> -d6eea4a9fc313d4e546535fd9d49cf63644603787322e53a0a53bc5ed28d2bc7 +ac8e30b596ac70275038e3586e732ec5fdc218230165c3470ca096740d21da0a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.