From: Ian Campbell <ian.campbell@citrix.com>
To: Jim Fehlig <jfehlig@suse.com>, Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH v2] libxl: update check-xl-disk-parse
Date: Thu, 10 Dec 2015 12:38:54 +0000 [thread overview]
Message-ID: <1449751134.9759.67.camel@citrix.com> (raw)
In-Reply-To: <56688B21.7000901@suse.com>
On Wed, 2015-12-09 at 13:12 -0700, Jim Fehlig wrote:
> On 12/09/2015 03:43 AM, Wei Liu wrote:
> > The block-attach command now returns 1 when fails. Update first test
> > case to expect return value 1 instead of 255.
> >
> > The parser now doesn't generate output for default values. Remove them
> > from expected output.
>
> I made the same changes yesterday to get the tests to pass.
>
> > According to 417e6b70 ("libxl: add option for discard support to xl
> > disk
> > configuration"), the "discard=" variant is never supported, delete two
> > test cases with that variant.
>
> Heh, I didn't realize "discard=" wasn't supported and instead added
> support for
> parsing it in libxlu_disk_l.l :-)
>
> Looks good to me.
>
> Tested-by: Jim Fehlig <jfehlig@suse.com>
Acked + applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2015-12-10 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 10:43 [PATCH v2] libxl: update check-xl-disk-parse Wei Liu
2015-12-09 20:12 ` Jim Fehlig
2015-12-10 12:38 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449751134.9759.67.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jfehlig@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.